From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3EE8C7EE2E for ; Thu, 25 May 2023 06:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00B76900004; Thu, 25 May 2023 02:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFE07900002; Thu, 25 May 2023 02:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEB7A900004; Thu, 25 May 2023 02:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D35B5900002 for ; Thu, 25 May 2023 02:20:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0A14140532 for ; Thu, 25 May 2023 06:20:47 +0000 (UTC) X-FDA: 80827778934.05.B83BA4C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 97E8240011 for ; Thu, 25 May 2023 06:20:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684995646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=avTSaJ+RieePH5Jl/ownDcb+gA97y4py5thaqq+chN8=; b=T5F1HMKMQWdbXPIFBcOVjHLm+rvqJ8CMP9PRJZKB1Rn0/MCCJly/bI9x6V4lj3r8VbG0/t CkwMBsLTiEk4CCUu2c+trJJ3C/2skJIzvrQryXd4Y60+p8hH+F2+mquJ+4muIh5xdRY6KC sx1dmac6qo81Vxqju48xdJDvnOwgfX8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684995646; a=rsa-sha256; cv=none; b=xcwNYSH2AdfuQCP/Iu4bzEIRkBkiSFozpeL1fuhIx5/tjCyysVzbfOLE7FkTDTpi2U5bjB f1Xackccy6ItAkltnkbUGDr2lCX+6NrFrZfqU6WKJcMwLxb6FHm1LjvPKmj/augscTjr63 Zr8PKQ3B9ooFROYlWlQ9iy108Q3c4c8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1AB61042; Wed, 24 May 2023 23:21:29 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F00A23F762; Wed, 24 May 2023 23:20:42 -0700 (PDT) Message-ID: <735dd721-39fe-8f13-b677-17162fbbdb41@arm.com> Date: Thu, 25 May 2023 11:50:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 31/36] mm: Tidy up set_ptes definition Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-32-willy@infradead.org> From: Anshuman Khandual In-Reply-To: <20230315051444.3229621-32-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 97E8240011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: eecg44b7mexii5bdah1pi4xncn753ri1 X-HE-Tag: 1684995645-950049 X-HE-Meta: U2FsdGVkX18AV3wsKEMzsD53tMqsCViuPj1yytwaGwO96gIXgS7h2Dw4HWSam+9sBFmQ9LDIN/qDwHuL7+Bi/Txonm2w54R94VSo3ZJ9YS1JSD7yV8RzFJre+PX0Wc5rfD+5d0eryCA0Lf8hETrWmKGStrLJm+BYQz2Abi4dFD0UoDLB9HvMhoVv3Z1gO5RG3CR3uI6DuWxSMOe7C35uXLGe3hXy8Et42dA+qbo6HwnVNsldfsjTP1KgyCcOIwwZe1pWtYfv+d7vflx4W7pKvJ1B37OJncobTcQn/YfVmaQHsJo3B4VWnPZY6BPSNRWqJsaz61AhyFDLl6oD4QPKrY1vytAHDuZryWwc3tYf19V98qLj5qPvvAApgkmMJ2zzzjW0c/3xSkWUIeihv/6U2kf4mLzxMmO+B7OIt4JHIhuefFXfrhT7pR1McqIRvjyLbT6M3XZlZwnfbCIUT5s5MI4MbFdAgNlewU9vU5xuOHDgi5Vi1UqGzDw8xIkjeNHJ6hAnbtTnuaqDzgzBzeHkhKUVnGDHfefHC4UenirhC5/VJjdV2tAZr7HDdlmaLFThqpP9TrBujUHUHk7XJ6TDuAvjYGVgDKYEVHm+A0k5/uuHXi0pv2NP3jqY+AI/B1gFUeE5FjQOvyypxGPLKI2Rw4zCOi31/sqpq3Q/aSozS03Vhas3KMLNrxbX6GhwxtJgJxhMYuFzW86ZlurU8u6Oz7ssf/A1wuyU4ZmrBakeiz9w/sFTKr6zytIXY6XJy28n4xiSUMPwuCPW02PmwzD05wVsy+EisZ7uXpTifqmt1rkdWD/h75JMaoNmHk8EGKc0pvXN78HII9oFwhgPEFNyzFxfo1qVg1pnY4kHRNOWdei3rQpGs+iXhNgqAZIZoiFJJ/T0Vj5QExTJbr6gE3vLt7TmVhln9u5/JA8jgKp0hI4gv6o5M7/8VfazsSJWDJzVtxUIgLYC05CJ5XUTwQ7 1mGwFYzj dhEouSkPgnIPzbu+al7uWyEUO43OEvrbcGucgn4bfr64+LCsvywiXYz01VO4Ckplmi0NV/9oek8RDNw0CVnGQf7oL6p5oVwh+mkC6IwFFzsOjZiMyewyDHzl2uK7xeOmbVl2lVEQmueJJ0RJ2ZvncZKftqn4Vh7cWg/qHCOC5TKPczT+0seMLkF52XHxnxCEpObXG2WiVjKW0dPKsAOFMxqiHP27Hs+dff3M5woT7qsPCzDfYJ9wQX+YElp8lGYSWJVAuTWJK9n9UqYQnzhkiJFjUuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > Now that all architectures are converted, we can remove the > PFN_PTE_SHIFT ifdef and we can define set_pte_at() unconditionally. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Anshuman Khandual > --- > include/linux/pgtable.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index a755fe94b4b4..a54b9197f2f2 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -173,7 +173,6 @@ static inline int pmd_young(pmd_t pmd) > #endif > > #ifndef set_ptes > -#ifdef PFN_PTE_SHIFT > /** > * set_ptes - Map consecutive pages to a contiguous range of addresses. > * @mm: Address space to map the pages into. > @@ -201,13 +200,8 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > } > } > -#ifndef set_pte_at > -#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > -#endif > #endif > -#else > #define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > -#endif > > #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS > extern int ptep_set_access_flags(struct vm_area_struct *vma,