From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DC8C4332F for ; Wed, 13 Dec 2023 11:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BD2D6B0490; Wed, 13 Dec 2023 06:10:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66D436B0491; Wed, 13 Dec 2023 06:10:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50E126B0492; Wed, 13 Dec 2023 06:10:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F8746B0490 for ; Wed, 13 Dec 2023 06:10:09 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DE2C7A017A for ; Wed, 13 Dec 2023 11:10:08 +0000 (UTC) X-FDA: 81561525696.30.340EA3F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 46FD9A0008 for ; Wed, 13 Dec 2023 11:10:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VSB/pBen"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0e6iPQ0O; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LsYDTbTy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="W9wio/Vb"; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702465805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GqMNj7NL92GZv31m2vvolJIawNqiNIRw7YBZL/+AVUQ=; b=oQgfgrnLD5J72p3zfomot8NkW7pZeuawMzrWU1p7zIelVXT9E4X5TuTA5ZaniD/150zWxk 1JPdAnYlHZL762hR3zE5yl5D9llK+Q0RRKbpKliUegu6pAgLhaBsqdsQ+pCkmyWUKHPSpz Vk2pKBXfx8QkKxQR5YLflvzeFx0wae8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VSB/pBen"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0e6iPQ0O; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LsYDTbTy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="W9wio/Vb"; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702465805; a=rsa-sha256; cv=none; b=xaeUra5hkxq0zVNyC7Px3BbyI1ThOriNKkDoYmEVTXAwSNMW+e2bSdHJ6XxR3IYXCSq6ft MIXoQU7okUElVqvvUAlsr4Se3SwjL0i8yyTf+8wnNlM7O2Ijj4tcdTKfo3YD1BUkcgLRE6 8fP/QD6I9KdlbAVK77x4wy72en7/QIQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DB8D122338; Wed, 13 Dec 2023 11:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1702465803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqMNj7NL92GZv31m2vvolJIawNqiNIRw7YBZL/+AVUQ=; b=VSB/pBenRGO5wNXCiTEwN7bRJCCLdK503RnGh6MsPsSX413eQjivqsL4QTm1DCAQRjnTUb tOTo4nxzzy7OTQ3KslGfuniqY6ZYCVceAb0/7adBSf6s77S3NapDx+N2DjX0vngHqdrg+g gAgwwQxSVdFctMHNVhNT7cXvXmCrRwA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1702465803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqMNj7NL92GZv31m2vvolJIawNqiNIRw7YBZL/+AVUQ=; b=0e6iPQ0ODxEOGKSD1cuh0pgTO0oSdtC+BFK1WCvLBS1Pk9nZRNZLAmp2RZreIyZtG1rUIl bdRaEzITD6Zl5YDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1702465802; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqMNj7NL92GZv31m2vvolJIawNqiNIRw7YBZL/+AVUQ=; b=LsYDTbTyC1Zw53Mw6ih9EuDrjtULfyGmMd1Cw0rG1FCsEekYQ4gkWsvMyGRU0neK4lfZ6r 6j1A/azOe0eq1CESVAyYtPQ7Ncz0kp+XmIVU6fYviYCSjW7RakLApZSDLhLD/nU7sHATio exY3LcPZ0Dru3C6hAs6eIXu3QVTraa0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1702465802; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqMNj7NL92GZv31m2vvolJIawNqiNIRw7YBZL/+AVUQ=; b=W9wio/VbkuEoqaEGV64rwM3baZsgcc1NHrvETuT8uDWSrVc8uqMV6VZ+uuGA/DVkfUbnPy y4BgWYq3WxMDkrAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B8B2C1377F; Wed, 13 Dec 2023 11:10:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DPqyLAqReWXwYwAAD6G6ig (envelope-from ); Wed, 13 Dec 2023 11:10:02 +0000 Message-ID: <73359971-25bc-8ce9-3dd1-b3124c18628b@suse.cz> Date: Wed, 13 Dec 2023 12:10:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v2 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" Content-Language: en-US To: "Song, Xiongwei" , "sxwjean@me.com" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "cl@linux.com" , "linux-mm@kvack.org" Cc: "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "roman.gushchin@linux.dev" , "corbet@lwn.net" , "keescook@chromium.org" , "arnd@arndb.de" , "akpm@linux-foundation.org" , "gregkh@linuxfoundation.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20231203001501.126339-1-sxwjean@me.com> <20231203001501.126339-3-sxwjean@me.com> <75a71276-dff8-ad3a-d238-fcfa3ab39413@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 6wd5swwmwxzto4iut46xk4n5giu3mw51 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 46FD9A0008 X-HE-Tag: 1702465804-827632 X-HE-Meta: U2FsdGVkX19FJgKmA34pKjAMvd1+XYFo2zAwSufxWzIOG9ui2thxyfrtYWGP3wISVc5+bDBE62GQ5I++C5lKl2/6xrh5BPLC+j75/kz2DP/hITTYYuX378rhxvRL1u6VJC97z9sf0QTs//g6wruBEtC1P3EIG4cRZvoRTh35EZX05qKW59U2VGt9JX68/G3a7OWlbwlaKrIkPYlhvZ/bum3QaSd7RNcfn7tnIfLzdYHYutg1NIoXZGuLnPHDjenVfDHHc+7cKRBRPuxd5ZNi2twi1fD5qkU7Z+xP/0+lJMgNUKGvq3l/U6S6HfQKCXoGH9xap6dLpmn1Tul/ZKfU7X0apkEofsnvH9CMuGra5UFrOeJV6Vtjk5G7eCsS66xaYGjEieTtSGE7w005IxQrLlB9ZRBce8saj5z0SKb8STPwqTYkz3pSxcVNuqfwvl+SiauXQaHs6bMJPiCq92wOREk/CP/GItLVBHYu3dUbHoMsouzIUuIz6pMAt6yuxenpsBDzIzTPSZluEYjdweXW7dKYfN/kRzFHLi+JWTfvtuU1yUZKrsTqZ5rdQTG+Sz8vWdpDXT65hsQ5CIH1tDPmVErkL0b0qXhlOmM77ihySvHBRfG0kh67mOaPV7O2wXUbnMaah/hVq+6l+cYmbHhwtuytbN+fNAp+y1bnbvv+gB2y0YbUnl5oVZ91DuzSp8yd3+zyZiy9oTNIAf+5oGo4oyqLqg4t0O5G7QtpgB2MOO4/2wAb/NELbS9fa4bcywZCAnCDGF4aKD+0DiBuuHHGq09WfHhmAHAKqnxlVUaTr0yHEGd15sFgA4+qHMO9TIileg93q9fMXzD29vgUqs5Vil4WjUMEHQSb0HcRlfsuemEjIdysHe/QlEuLLqoCnC1a+Y16KP/iQJV7EMx6IOrf2bjLlxniGSlzTLBUCh56dkx1XrfIWw/8w++vB5qrpfiJDKfv1jj1ozgp0VlCswG 26tBBhDm WPehKgt7a0VxVKniHnAAxr6b6iuRiEM2IhqiG5GTvp/jO6PFQSK8sOcAdWwyRx/KXbxCfRkOEXprSEfQXmLRoQ2tbybWYo508PF0GEie4tuYpv4OH5PygQfjFZw0K3Tieyssl1P+n4FRbL4Jtu9hnk/lPIzcGaIwunIIL2KniJ2I/i1NO9f4Lb5b01CY29/T56yu0PWV94CHZ43wZ1GQB7ODwwBGbLUHKz1eV2xsVvtckzA1sTsZtkhvWA0xpaGWuOpnLg7ZKLVlWwTNmRo8TNgqZFW1LNOwyLq3O+HhejxYFWYWja5vf9dKCCWx3xZXz7y+08j+VVU1KpP8r2f96fiQFDMwBV8mrYcuXhcMsHXQw1sc5ImPq+Rdwc500dNVnhUNpLQ6Fh84I2XE0App0O/T+lfJ2I0eFwyXQt85ICaTHgTOYdzmTzzuOz9qnTZAkowPjrPXGb7LQh+6wJMDm2Lxi2TgZbvYgzUQEQFpqPsBE2RFusUsJDaFoe8rtcUtVpjxlZCUP4WCb3l69fWGRBv3tfDOXuhZadyynAocCG0JZHHkzpSMjEsM4/6p0tjma/b7rjkZjoojvKl49rJdpFNxJD/B7iT5SQFOAVE0SLqMbsRzu5qg3W7p38q/AVQnY7iHuxiJJWdimg4deAuIGEl4WO4fw7aOSammuKp57DF88Ngof4hTSP65WSfSm8L5VqsFo7FU/qOwFRmxOD6zDczszOnQKLxJVFOFHrRtV5MosiRNpPdfBmyWTlOw8t3swysVbH8rpDQqIqt1kVXXOykNycpio5JgQoMIhIP54gkN+3B6VUTx/BjF8NYo2llK9Uuhz0aSqN75AfGxY/sWHeJ7h1lXoNmEQsfRWTRCIs07F5hAiyk8I0eOIXAPxruCVhN8ieSTuLuZDGccxIuuFTwIgPQCSKgXti/4xA38e+Qo0N12FnYbNKIKV1eANLbM/RjPlXuJq6L4txH87XVyaCnoaLvRA 4W25ZoS9 Fu4v9Z/GM7jz6PhA0pzMjHvduTxzOi1jcOcNE1kMhz25HKa6xC5QMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/9/23 02:02, Song, Xiongwei wrote: > > >> -----Original Message----- >> From: Vlastimil Babka >> Sent: Thursday, December 7, 2023 12:15 AM >> To: sxwjean@me.com; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org >> Cc: penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com; >> roman.gushchin@linux.dev; corbet@lwn.net; keescook@chromium.org; arnd@arndb.de; >> akpm@linux-foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; linux- >> kernel@vger.kernel.org; Song, Xiongwei >> Subject: Re: [RFC PATCH v2 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" >> >> >> On 12/3/23 01:15, sxwjean@me.com wrote: >> > From: Xiongwei Song >> > >> > Since the SLAB allocator has been removed, so we need to clean up the >> >> "we can clean up", as we don't really "need" >> >> > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for >> > long-term rather than "slub/SLUB". Hence, we should use "slab_$param" >> >> I'd phrase it: With only one slab allocator left, it's better to use the >> generic "slab" term instead of "slub" which is an implementation detail. >> Hence ... >> >> > as the primary prefix, which is pointed out by Vlastimil Babka. For more >> > information please see [1]. >> > >> > This patch is changing the following slab parameters >> > - slub_max_order >> > - slub_min_order >> > - slub_min_objects >> > - slub_debug >> > to >> > - slab_max_order >> > - slab_min_order >> > - slab_min_objects >> > - slab_debug >> > as the primary slab parameters in >> > Documentation/admin-guide/kernel-parameters.txt and source, and rename all >> > setup functions of them too. Meanwhile, "slub_$params" can also be passed >> >> Not sure about renaming the code at this point, I would just rename the >> user-visible parameters and their documentation and any comment that refers >> to the parameters. Functions and variables can come later as part of wider >> slub/slab change if we decide to do so? > > I think we can rename these global variables: > slub_max_order, > slub_min_order, > slub_min_objects, > slub_debug > , which are used to save values that are from parameters. Because some comments > are referring to parameters, the others are referring to these global variables, which > looks inconsistent, e.g. slub_debug/slab_debug. Is it acceptable to make them > consistent? Yeah, as an additional patch. Thanks.