From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE69C636D6 for ; Fri, 17 Feb 2023 21:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEA296B0071; Fri, 17 Feb 2023 16:47:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C98406B0072; Fri, 17 Feb 2023 16:47:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FEF6B0073; Fri, 17 Feb 2023 16:47:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A6D1E6B0071 for ; Fri, 17 Feb 2023 16:47:54 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 736B2AB393 for ; Fri, 17 Feb 2023 21:47:54 +0000 (UTC) X-FDA: 80478121668.05.5F2AE26 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 86B61C0003 for ; Fri, 17 Feb 2023 21:47:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gaUVGgmR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676670472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=if/tW06TDxxLKgUq7/Etw5p2PggjEQkfj1fwjUBcfbU=; b=s5SOARLv/46UdXkw6pBy9L/koHkMzoHYXn0blDRWhU2fPDFWWXocy7kLuqlMteSBDMcO+D KgbqF+cRbDUVw32E7jpiAu6FMZm8GNjkXEgvrBDzyBa77yW0p4b/U+hVuqMo1l0sjnZv43 cN7G30bI3Bp32fYT3sEFS/C23ho5W20= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gaUVGgmR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676670472; a=rsa-sha256; cv=none; b=5XXLnAr8Va4ECsi2oUnZ2L5cpWD9Er55e1Lm/FQfAj82K2WNCoE/8+rhNNBr95aAEWWwCQ qunEyLP+xUkIVL4zQdAni1Tz1CLvwDSAqYrhlV0fKhWbMNMSBckPxBDG5fcBLnzmT7ewL3 uRh7jXnT70cMMrjuoEqz0o4wt20Cdy4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676670471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=if/tW06TDxxLKgUq7/Etw5p2PggjEQkfj1fwjUBcfbU=; b=gaUVGgmRCGeKph1anuoLJyKyYO4SzEaVK/86ry8g1wal5IUzdlD5AkJ5+Z7O/0QCmds3Dt D23kPDYEcu6eP2s0jGtB6A1QV+YMYjpOTrgD+3Qp4uFfirEiRbEZV934EMrXgFr0UniaDb 4b8FuIsQ30XOgK0SHHFcrKKZloJ0jAU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-80wKAcFcPWuJ9_HZUpt2Bw-1; Fri, 17 Feb 2023 16:47:47 -0500 X-MC-Unique: 80wKAcFcPWuJ9_HZUpt2Bw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 631B23815F7B; Fri, 17 Feb 2023 21:47:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1328F492C3E; Fri, 17 Feb 2023 21:47:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87a61ckowk.fsf@oc8242746057.ibm.com> References: <87a61ckowk.fsf@oc8242746057.ibm.com> To: Alexander Egorenkov Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com, hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz, jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, logang@deltatee.com, viro@zeniv.linux.org.uk, willy@infradead.org, Marc Hartmayer Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <732890.1676670463.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Feb 2023 21:47:43 +0000 Message-ID: <732891.1676670463@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 86B61C0003 X-Stat-Signature: pgxw4ekszpm3kmgf7z4yc7uijikzkce8 X-HE-Tag: 1676670472-113864 X-HE-Meta: U2FsdGVkX19b80x2w2TjqtXkC/U2UUpJ2Wmu3xtYFW5iyMoZa8edsYBLwmcZMoxAvjVRLj5FVVG3Sg6EJQreoxpP425ZryMzq/txcGuScYJqJ9+LfezbrTtqWqaCs2WfePFBb8cxJHOjE14UY346iBnLBR6iX7Bja5euqGZjPgvRPi5x6zChXm985tgvM4wEFE4WD6Gq2b5jQMB5CSBk5X/OaeK6oGzK1YU6mMKD5N0T4kfhTHnOuDFRmjSB21+5wihm2mX/HkwEkW766/FpKjimwYbZc/0qv5Ba80LcTisC8h97MZfcNGrL1yPbeGlAiNUgAwUPM0WgrAW7SCm60l1xzkwnqPVztO/H+DZsCP1GhIsJrEphVT00eYN4ro2ymX+zV6Usdmc17HW2yDvaLPy/F22oI5TwYkvQyrSXXiQqVr9wlZrHZOQroga7KsfA0EPA/UcnyPAZhky4mw5Xu6I/rTxRwXmTy+UbNlrALhaFLo8boPVRDTIPPpm5RP6nghwWy6EF8ImF4biOL4kUPhKw8gnB8knsPuN2zTO8d1siBTwLo4nkWdfooJs7cPj5TAQ1C+1DjcnTtehS7iJYuqDgmuWo1Dmmj1DjWmbiQJarfO4S8fCSBe/QNmlKqNh6Z37p54qIhDVLjJqG2lzBdDb4Fr9wq3zFLWNMBkXwp2Yo3jWzGbGlxI5xmP7OkeCmvMP2/vZktz+2Dt7F+cYhZ+uzZiHN8M+cE5FMuPI82o2sfqjEg97q8xFSLE84IjQtvLPKMskSHE2PSpft25Ku/SbUSg3NZ+BASnpS/WbdQ5vPEUtwK/0g/TBGkueenpqWtk4v87E0AjTO+5LF7ha36gQWOoXOd0v6FB3EuwQ2R3z1jrdAozg9PD+nol/71+HS2FGKXsfxKv/oGPZBxSEF+uQlC43wkM8cEfsUTNTelFMaAR+Ev9KfNZasG3VCzS7ih62FbPsyWaYAxykSUKD e2SEeqQF mzlELVxbJ+IyXZ8g+jRoQN3rqBTOgJdhCfsV4HP22Xd2fPGskh8S5hdPKrFo8hK67z8KSKUWuIaLl0Y4xh7aJh+lzgEi+1EzMqW5GFhe9RB95r1uuAXVyFXx8bgf9pUHF4s+59lvzRFx+XVYgqLqtZrZzFv0Ba2rbqYbRkOX4ICRwLSzIZxk8IHQ/6+Z0uF1CqipCbPGq1a5Y/kFr025K/t+j+dUu09YPdErNjElT+CVnpEwAHja9/NDPyVBteLWW0r2d89T2praMOBHdQDeH1o8lCNvf8grW/pwu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Does the attached fix the problem for you? The data being written into th= e pipe needs to be limited to the size of the file. David diff --git a/mm/filemap.c b/mm/filemap.c index c01bbcb9fa92..6362ac697a70 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2948,7 +2948,8 @@ ssize_t filemap_splice_read(struct file *in, loff_t = *ppos, if (writably_mapped) flush_dcache_folio(folio); = - n =3D splice_folio_into_pipe(pipe, folio, *ppos, len); + n =3D min_t(loff_t, len, isize - *ppos); + n =3D splice_folio_into_pipe(pipe, folio, *ppos, n); if (!n) goto out; len -=3D n;