From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18ECEC433F5 for ; Wed, 19 Jan 2022 09:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59B9E6B0071; Wed, 19 Jan 2022 04:57:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 524446B0073; Wed, 19 Jan 2022 04:57:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7B26B0074; Wed, 19 Jan 2022 04:57:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 293D16B0071 for ; Wed, 19 Jan 2022 04:57:39 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CD3818272EF2 for ; Wed, 19 Jan 2022 09:57:38 +0000 (UTC) X-FDA: 79046584596.10.FBB5C71 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf31.hostedemail.com (Postfix) with ESMTP id 1443D2000B for ; Wed, 19 Jan 2022 09:57:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C401A1F38B; Wed, 19 Jan 2022 09:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642586256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aOo66zzdOMi0rKAhY9iaubkRgFnRqTsRXgFgd3j6mFM=; b=uFW9RzhIJpN4/rZlqR7nXLuC190DVZMJvokDVE16qI38mCEYY9cBcrW+cNx7miZXaCgI3y zw9mSbbTcNWE0x34R5N90vtTjXvLJIFql3cDiVAn+46QWbWJz5s5A2qPUKl7D6hPe+Mvdk x20NcS5GFmXrpMX1oUfXA5RVoPKu/Ao= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642586256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aOo66zzdOMi0rKAhY9iaubkRgFnRqTsRXgFgd3j6mFM=; b=wKxd7NxQ1NZ0+7+Hu9pUfc8w8YfU2CZgp2Oyi/ZhUQ9arOSA/XxE/43M1PxVNTwnoRof/8 WfMWpOP6fckXMYAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A71113E11; Wed, 19 Jan 2022 09:57:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z9cNHZDg52GUNgAAMHmgww (envelope-from ); Wed, 19 Jan 2022 09:57:36 +0000 Message-ID: <7323485e-9385-0171-7e61-6926d9480992@suse.cz> Date: Wed, 19 Jan 2022 10:57:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 37/66] binfmt_elf: Remove vma linked list walk Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-38-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-38-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1443D2000B X-Stat-Signature: eec1tpbstgznchtmyttga7trhk6t33bj Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uFW9RzhI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wKxd7NxQ; dmarc=none; spf=pass (imf31.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam06 X-HE-Tag: 1642586257-491943 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/1/21 15:30, Liam Howlett wrote: > From: "Liam R. Howlett" > > Use the VMA iterator instead. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > fs/binfmt_elf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index f8c7f26f1fbb..d41cca755ff9 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -1622,6 +1622,7 @@ static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata, > static int fill_files_note(struct memelfnote *note) > { > struct mm_struct *mm = current->mm; > + VMA_ITERATOR(vmi, mm, 0); > struct vm_area_struct *vma; > unsigned count, size, names_ofs, remaining, n; > user_long_t *data; > @@ -1651,7 +1652,7 @@ static int fill_files_note(struct memelfnote *note) > name_base = name_curpos = ((char *)data) + names_ofs; > remaining = size - names_ofs; > count = 0; > - for (vma = mm->mmap; vma != NULL; vma = vma->vm_next) { > + for_each_vma(vmi, vma) { > struct file *file; > const char *filename; >