From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3754FC77B7C for ; Mon, 22 May 2023 00:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95AAF900002; Sun, 21 May 2023 20:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E3C06B0075; Sun, 21 May 2023 20:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AB75900002; Sun, 21 May 2023 20:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 68A116B0074 for ; Sun, 21 May 2023 20:07:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0741E1C6E89 for ; Mon, 22 May 2023 00:07:40 +0000 (UTC) X-FDA: 80815952280.04.AAC390D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 4AD76140019 for ; Mon, 22 May 2023 00:07:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jinVW+8e; spf=pass (imf23.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684714058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VKZkdHlo0vaovrHKUVt7LDP5fGNVxr3UGKfBoA9uSSo=; b=ovLv5wElG3qfLq9Fv5PpPSfMZLk+yML1vsQ4z10N79GWq3p8kx/EQPlFpF8QrxRUmKoBv6 IbafcgepRG8DD0gFgmAv62TDQF0xCMtcmPLxoBZ1Qms9LS5cHDolNGEPjJBZnDLYvHwdco qCqbsi8659678VW4fIDBV5mmMPy2E8k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684714058; a=rsa-sha256; cv=none; b=jEveNtFjjl05q4B1ss25Tp4DnMJs1VDozujzKGdPdXPZfciFaAYpDBhnv85Hwvsrt/t9to mDU9++zVf9ZpnSaqsdxAWpzHFnsd6+c3tMeQidXWYLHZ/Dpi8DLIgakf1+/wjRsHzgJn7t usENm+ODXlVhWdKGapur6OMk9bYiaUo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jinVW+8e; spf=pass (imf23.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EC15611F3; Mon, 22 May 2023 00:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21004C433D2; Mon, 22 May 2023 00:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684714056; bh=logUhuMuaDvrFGp87a3eXuBZVgOPH38ZQeOk9oWMxhA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jinVW+8eNfBmMJvPLIRbSMrX3C+ysBP344vv+qMi84FjV2X+zzFwAh8xh+THsy/A8 f7n7CscOp9ldNzbMYKqQROCTt+AS2stpbpTN5qKl4tiJAwkxedNRln1tS95W+JHVfL MlrT+lXxAxiWe2UTwO7ndf3emdaYv3zxBJ5GihMIvhIezJ3AGMv4m3w3sorDMEvyPf FkNSWSW6DtqVfjWPCwUzSDgy0Ug7/6HBtXxZfFSyEx8EAJMuiEkELi3AT9cEPjV+k5 p0DQ1x6g3QKPp4NSjgQJvj1BT18DFRjljg71PKaVdhIQjyEcKo9DHNhzPm+akQ6HSZ HYHWZZRzzH9tA== Message-ID: <73104483-a4ae-b7e9-2383-c28714e9859b@kernel.org> Date: Mon, 22 May 2023 09:07:33 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 09/13] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-10-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-10-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: a7umgcjexqod1rusqy7icmxn1ha1qsbi X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4AD76140019 X-Rspam-User: X-HE-Tag: 1684714058-85083 X-HE-Meta: U2FsdGVkX18VtEr+c/AOCEG00NF2J/p1ohslQTKx4REQR5Rs31vFmrljYStRYYrtJIeUM4fVMWeTOvbTJQnqKOv4s7LFfnp/+sJqTCptl3NfeuAifL2Juj6TBh8qOwoBQn/kn1YJudh7j665/3SnT9fvpuccKZ0Z1VIxqwW1Z9qOrOU3dNeJaApi91cpTN7kDwrCr/0GHYGqaIRtLlNe6GSGgLDONpo8I6kMp7mLE/5YjBOxHwF3uwFOSAJTv3GfTu8GcssF45Tddm0la3YryKFqDvXV1GO2aHQoBjqHjhQboXUSs/wz9gAXmlk46Qu7+cfDXkby7fAWIUbLifP55YvA7uRwTjlcfV4fqPN1roSyjLuYpB+YEAaKrqSwD/0BMUvISD+A61AZ5MWE6loZxlcQsLvQ1CPN05dOAVLl/MMuPXgdnqUKpAJTmrnSjg3SN0vgv10kFFhrUuk1qvo5WB/lRf/er1xFQlUjhbG40SLdNXTFlnDo4e/2quNIy5I/SEWQ78kldGrNNifEBa6+k/OMRijd49pcU2XtxNyAEy89Zeas/PPae9Y9BuBpv/XVsKUB9g5Tkp6ZlX5xY5e7sDgUc4nSOwf200yF7DJmPB/kPsaHDrG+O+8zX5JGlcO4TWY6bVFB8Zfckwm2bn3fqlVkQn02gbwo2QZTxW347l3eJbX9vxXaH2kcw54ZdYFrDQIoBWCtLt9xzKCWCvDzFnoVqK51rGiX38Y/9xnshOqZRFZ1NJetkH9vHheU0GJ3IzUbVZBnuwbrgbUzBewrZa6oPgYwDdmZb2IZ23kP7DLt4GK84+0oS1LeFembuD9O0aWWIudzKdgyhpT0a71FTQD4HtaNYVK+ABZCV4sqiWHLJ4rJzc0MQM7LqpqMBix7FzcfUUFLwIKdeQrSqWPoV/QOML96GyjEgme62lL0nEMS0FLSyX3u0TziX8JBp1Zbb0yN01J0AAlErWBqoJ3 CP2X+8nC pGjxRnE74paUXUEDiLDdN2sh2V46O6Ytw9u7TrfLzez8RbyYyN7rNDmYs0CV7rkysMSP0w1lpqriqtq2yF/I8tnClvlJsSsZF6vbddT4g/EyADdmTwOmbHPbFcof7YXY6z434KhS/kScDCZPKiGtROPliPqF685+hgNEDKF9GGYRIa9DMv3mFtvoI6QYA8qcCpCN1tvXJQYD5tGjrvB4dsXEeby/y7YUkikj5wRwAPK9nEIkBKIBGjz2gznIuOrP30jPUGcwJkhfO2ARYm0PJZhf6iz2WVa8y1WWapuDLZCCvNkxwqLefS4IDlpKz5doX0N/F2o60WamFgxb25FhmWWuSE2ZLUVYqTVCHBL7IlonU/bckcJfFAv/tFg9VJDV3xPHAGAGNqRi7R9b02yeQNFtYiWCj9CzsQv9wQ8UPL0SPeHONrGOGI0ju4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 18:35, Christoph Hellwig wrote: > Use the common helpers for direct I/O page invalidation instead of > open coding the logic. This leads to a slight reordering of checks > in __iomap_dio_rw to keep the logic straight. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research