From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0CBC54ED1 for ; Fri, 23 May 2025 21:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABEB6B0089; Fri, 23 May 2025 17:33:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6AF26B008A; Fri, 23 May 2025 17:33:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5C516B008C; Fri, 23 May 2025 17:33:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B51646B0089 for ; Fri, 23 May 2025 17:33:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 601E9120591 for ; Fri, 23 May 2025 21:33:14 +0000 (UTC) X-FDA: 83475473508.20.8C6D434 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 6872D40003 for ; Fri, 23 May 2025 21:33:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ljx707Rp; spf=pass (imf11.hostedemail.com: domain of khaledelnaggarlinux@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=khaledelnaggarlinux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748035992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qpf4Pbv2LaunBeAGYa0hZONpjIJoOeyE288WoeCcc9A=; b=W1FwhGZwL8UKlpJNVYjNGLUrzY2xWperVpO3sgxbMs7mRZKCZTIFufALJOHZ3ld5ewi8wV 1JMiZ9F9o71r6M9vzTBxY/fQIgx1fMAAVKKFwbr+9uuXp53+Tzsc+XHjNEio3EOttBNSoe IpXYY9YsmmtApzeZmrjVHTtRdB0btxs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ljx707Rp; spf=pass (imf11.hostedemail.com: domain of khaledelnaggarlinux@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=khaledelnaggarlinux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748035992; a=rsa-sha256; cv=none; b=X5CxwIdZS4GtOX2zr+xw7wIyZXWQxtjPs3HdUUCBZoSTgHJMf4mZWqI6d6bqfApyUQwuKK K8qXKQ8IWU0dpS8FKqAwww++1rZKDsJC9jpqEbHQip+18JkJTjx3fNln8Exc135K9i5Tz5 htQ1HlvJm0g0YSde0YJqhUpvr0KUO9Q= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a36e0d22c1so232790f8f.2 for ; Fri, 23 May 2025 14:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748035991; x=1748640791; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qpf4Pbv2LaunBeAGYa0hZONpjIJoOeyE288WoeCcc9A=; b=ljx707RppTP4Bw0hfEGITj8UXsj+WzcpNblgfw1xVAcuryQMaSlNo3C20Oiv0wvGgD zZCl5Ym4WoOO32FJpUlTvpMf8lphHjxzRKibSCyiKlKMh/VfM1CgjltaC+/yYdYC6zMp +XDkNugdtUslqcSCwn/tadhj2Pph4NFtx1lkqryabTZeHB0R/3dsezDvzP5/cFvICCbn s7LS2MFaZQAbXf/Xo+nsrCdVyhAVgr/ot/XwGtm4cFwwkgcIt74cTSiyV+NzwkUCsEGL VNqw6mXKXeIMoU7ZwUk3ydx2ahkux/WEhQwC08HaUEEOrw0JH/WXuZWhQIk8HGvtNECi +ruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748035991; x=1748640791; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qpf4Pbv2LaunBeAGYa0hZONpjIJoOeyE288WoeCcc9A=; b=nY5FdkQ3zQqtU1jY/GE4gMIVL9qd4oxfUaso6TqtS92/ft/PLs/hsW8F5RreA4sChl Mme6jR0T4HGQI4G1cOg/H0jQnwbrt+4vVhp7Hk4Lgf/xq7vT57LWNaFqJ1UWfIPwoTMm KiPQCx//HV0JhU10AH/DwKN4/j9dGOacCkpAdUfBuclVVYRWzpeG9J55zNbVxs+c8QYQ oLfhOgV7Urm9uis4xAGlRp1fOJJ3cxho8IJJo7/FBRYsWKD51D1et26VtltnoiEph5kE 3Ns+hmEtW6CEror55HB78nYKNJ7SxcW24YInZzZ8ChM7mmzhzfkwnydLNGMzu5Sg9arI cLlQ== X-Forwarded-Encrypted: i=1; AJvYcCWM8EpuaIauEel1Y11HVYAy/kg96R5VSN8OQZ321K/k0JS4g7wFu7dJSpWlOKXeJJyhRdGUS9vPfg==@kvack.org X-Gm-Message-State: AOJu0Yy3XtFUc7DPxU7LdLhloKh9H7jFnMTvZa7qcxsBhHmz4IOHebYs pHZ4b8vBUngHSNgVeu0YKxe6mt4LQiTqBFlpOabmki8LNAiX8j3pn+a4 X-Gm-Gg: ASbGncvj89A50lzuNPa/g2yM33gg3Sy6GH1QlpqpcScyR9ItzlhuaUXT6+yAfjSJWYy ayDffnEvM9GWzD4oWC2N0poxhcw/zR0SGy4kWHuK7H2mLSsF9CfvgXWDeJjH2I/2tM/b+Kx37ay OM+0sT4e0QGw/uD+cn0bx+so8vA4XZaeQhy/A7l5rg46KL7AV3X1rp6gAqjBkXp4vCZOPm7mjOM fsjdz8mg4ZjBctdAP5KWCxcE7U8Evp9BMrumznEC3rq2fKUShWKFE9zrUAgf+UPShCE9aU+IglO YBqlxzYBwBpu8BsF9kr/fetplPmxXD6fRx9GjZXMrV1gDEPuQsyJPISd4rDe1qnksAlk X-Google-Smtp-Source: AGHT+IE3WHr7NkotDT0Tn5O4UHcUPRin9SJD8uSEXI0fanie/Wcubh2smOWrZEWwxNVVsR9JC6NhtQ== X-Received: by 2002:a05:6000:2285:b0:3a3:ec58:ebf2 with SMTP id ffacd0b85a97d-3a4cb408fb0mr677310f8f.7.1748035990451; Fri, 23 May 2025 14:33:10 -0700 (PDT) Received: from [192.168.1.46] ([154.183.50.249]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4c8cdc618sm1247221f8f.0.2025.05.23.14.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 14:33:10 -0700 (PDT) Message-ID: <73101285-2854-470e-a3bb-9a363a7c1991@gmail.com> Date: Sat, 24 May 2025 00:33:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] selftests/mm: Skip tests dependent on a binary not built To: Shuah Khan , linux-mm@kvack.org Cc: linux-kernel-mentees@lists.linux.dev, akpm@linux-foundation.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250523184312.2647781-1-khaledelnaggarlinux@gmail.com> <41d3b11b-d269-4ee5-a118-6608c804e068@linuxfoundation.org> Content-Language: en-US From: Khaled Elnaggar In-Reply-To: <41d3b11b-d269-4ee5-a118-6608c804e068@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6872D40003 X-Stat-Signature: uoccyd1wzb5r4eft1i5togeej5dkg9ka X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748035992-820692 X-HE-Meta: U2FsdGVkX19UNX/YoJdrHAydWSfc/kSqcNe0HfFZ4Ny77PhPT9jvE121kzKydVEKdmVhtbDsdRKrmE9qLrl6yobOnqsd9D0myUDKm1Ry33mgm9WkviDDXli3ueFdf3swJBzMhHNI4N/1tE1B3V0qwdtme9Ta7HdJ4HqAj/sk9Z0NTPTfTgeGOufC7CudbFpw8QouEG4aZpfVCsKxIUy4vc+JpMM15EN2eHO6tPTTDyFyDwswnZrmUQ6EQaxizmz68Z4ztPbCj7oJZj7TM6zRqslHOM8Ebw69qg3Uyq7hgG/yV8xm5wnB4VRe28iFcww9ijwSG+LnHeZO2vjmrdTCX3jraVOPuCTcaEnMWfrGXTeFsleT1rsFh9SScbhi/4Etv8oxPoik3cmtqSLMZ9pq+S3oIWGwkAzJyswnUOoSKLhFWSjyiOgtxJwJJRCGEMJv2qEtrxKII+gjSt93vaZn+7oKcAMr56GmnwdDKnSYP/5MwyQ96Qachi0ln97Vy0hCeibjYVAHpsbrbThaDpUrgRIgZwv0XQ2Cxk5Z60UaZcuKlfDTHO8vvEpeYlfUdMZ5DnFwsREcPNKdym/p9e+UTSKv+5I0keQY5nIHpnpk28lPHbomEWBX1Wl53GRcAy3cLZ1DOVc3+zrLakNka7nM2Pa4tJjiZyumKm2XYQYUMbn/cK4t42d9C+0YfAAxWbrHfqfuLiWbnB5iOPx3Vb0/QmW03flg8B77wuj6yR9rgy2SD6uh7cxRyQiUaE0Pb3pIyG/2i0Uf2qhVg+Ga01o3BdybyQyJeq+GqlU5dcAAt3bJMOWTR+cUErL1SsYfTbcu7ovO1XoOCotgKUzrtyFsfUZIWIdpuqf5cz9uWtufM56VF7bDZbkDf1IjchhyUojxrL3vZG2LBeo/7Z2flFJzRAm8CSlpjT1w4NqdomUm0CrLtX+x3UwaqFo+vGYPGH1KTn2c8qo3uXHTDLC9o34 5syGTYYM gDV1a9XKpcGNv2SgsW38m0qEYMJP94kWg5elvlrZFkrwev46T2JIw3VERcu25rtPHQbM/13S9EE5kbyTsWgNXS2ZEcVF+A0U1pX5F+HVos7hjWlkAmipjf2+lZrk6/XooOqEY4FS0VMWhxKqmK4egjTC6jYrcBWT1A2V8AC9ABO4kuq2nMXOaq69sl3sJ98qyh4lWh1sxgw/6r1YEFg/ROofOEx5muLHl7qeX+EOpbU27sjcGPoaflJ+BPnzDs37/tKO9Fr7Fy/eNFGDvrj34xNlrMq3MBVlSXBtzAB6eSGBAbNvp4uM6yl92RXtpXeyiUaQUywUs1nAmTOGaHO7eGiGkNoXq7ntYrFKqcBEZlyHOG7CuRfuhuRgv2DXbGB/Cx715C8Vn5qwQXhphTGqE30/FG+xx3LO9d6K5m7Z3jce4jaWjHFrYcoUJL29NQsb7d/xB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/05/2025 12:09 am, Shuah Khan wrote: > On 5/23/25 12:43, Khaled Elnaggar wrote: >> Hello. >> > > The above doesn't belong in change log. Refer to a few change logs > in the repo to learn  how to write them. > > You can also check the kernel documentation - this change log > is way too long. It doesn't clearly state what is being fixed. > > In this case, "write_to_hugetlbfs" is missing because the right > config isn't enabled. Test stalls waiting for write_to_hugetlbfs > to run. > > You are fixing this by checking if write_to_hugetlbfs exixts > from /mm/run_vmtests.sh > > Summarize this in short description so people can understand > the change. > > thanks, > -- Shuah Oh, I mistakenly thought since RFC does not get merged into source tree, it could have a relaxed tone, hence the much text. Appreciate your feedback, I will rewrite the patch considering the points mentioned. Thank you.