From: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>, linux-mm@kvack.org
Cc: linux-kernel-mentees@lists.linux.dev, akpm@linux-foundation.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] selftests/mm: Skip tests dependent on a binary not built
Date: Sat, 24 May 2025 00:33:08 +0300 [thread overview]
Message-ID: <73101285-2854-470e-a3bb-9a363a7c1991@gmail.com> (raw)
In-Reply-To: <41d3b11b-d269-4ee5-a118-6608c804e068@linuxfoundation.org>
On 24/05/2025 12:09 am, Shuah Khan wrote:
> On 5/23/25 12:43, Khaled Elnaggar wrote:
>> Hello.
>>
>
> The above doesn't belong in change log. Refer to a few change logs
> in the repo to learn how to write them.
>
> You can also check the kernel documentation - this change log
> is way too long. It doesn't clearly state what is being fixed.
>
> In this case, "write_to_hugetlbfs" is missing because the right
> config isn't enabled. Test stalls waiting for write_to_hugetlbfs
> to run.
>
> You are fixing this by checking if write_to_hugetlbfs exixts
> from /mm/run_vmtests.sh
>
> Summarize this in short description so people can understand
> the change.
>
> thanks,
> -- Shuah
Oh, I mistakenly thought since RFC does not get merged into source tree,
it could have a relaxed tone, hence the much text.
Appreciate your feedback, I will rewrite the patch considering the
points mentioned. Thank you.
next prev parent reply other threads:[~2025-05-23 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 18:43 Khaled Elnaggar
2025-05-23 21:09 ` Shuah Khan
2025-05-23 21:33 ` Khaled Elnaggar [this message]
2025-06-02 23:22 ` [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to_hugetlbfs is missing Khaled Elnaggar
2025-06-03 2:12 ` Andrew Morton
2025-06-04 22:35 ` Khaled Elnaggar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73101285-2854-470e-a3bb-9a363a7c1991@gmail.com \
--to=khaledelnaggarlinux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox