From: Nico Pache <npache@redhat.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Rafael Aquini <aquini@redhat.com>,
Waiman Long <longman@redhat.com>,
mhocko@suse.com
Subject: Re: [PATCH] vm_swappiness=0 should still try to avoid swapping anon memory
Date: Mon, 9 Aug 2021 18:31:25 -0400 [thread overview]
Message-ID: <7301b496-d2fd-b5d1-8159-6613c958f487@redhat.com> (raw)
In-Reply-To: <CALvZod6Kv_eZcZeJOvypXe_XVzkvLDau7faiDQ2mrqV8kOqq3g@mail.gmail.com>
> First, the shrink_list() will not be called for anon LRU if get_scan_count()
> has decided to not scan the anon LRU.
get_scan_count() will decide to scan the anon LRU if(sc->is_file_tiny) which is set in shrink_node().
In shrink_node() the MAY_DEACTIVATE/DEACTIVATE_ANON allows this the be activated.
> Second, I would like to get your attention to the following comment in
> get_scan_count():
>
> "Global reclaim will swap to prevent OOM even with no swappiness"
AFAIK my patchset doesn't prevent any of the OOM cases. It only prevents the anon workingset refaults
from challenging the anon if swappiness=0.
> It seems like the behavior you are seeing is actually working as intended.
> You may decide to change that behavior but you will need to motivate the
> change.
My V3 has a lot more in the commit log. Hopefully it will clear up my motivation. I will post that now.
prev parent reply other threads:[~2021-08-09 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 23:17 Nico Pache
2021-08-07 1:00 ` Shakeel Butt
2021-08-07 1:37 ` Nico Pache
2021-08-07 5:23 ` Shakeel Butt
2021-08-09 11:49 ` Michal Hocko
2021-08-09 22:31 ` Nico Pache [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7301b496-d2fd-b5d1-8159-6613c958f487@redhat.com \
--to=npache@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox