From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8B6C07E95 for ; Tue, 13 Jul 2021 09:51:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E239F60E0B for ; Tue, 13 Jul 2021 09:51:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E239F60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2345D6B0095; Tue, 13 Jul 2021 05:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E4FB6B0096; Tue, 13 Jul 2021 05:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05CDD6B0098; Tue, 13 Jul 2021 05:51:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id CB8A86B0095 for ; Tue, 13 Jul 2021 05:51:51 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CBF5427700 for ; Tue, 13 Jul 2021 09:51:50 +0000 (UTC) X-FDA: 78357097980.35.1865125 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 56BA2F00038D for ; Tue, 13 Jul 2021 09:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626169909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tbVpCJ8GLa0hxilOdeafb29laMr4Nxg08S4wR66Adcc=; b=c+eewRcHtVVKGKC5SwnXRKXGKSMZpYu2N7YYwpr+PCH/NRn2a78oZ6MIBgrTG0uJH0hI3P dNYvPeUO7noB9qGPjYACqi3NdXdAMmV8QBfv/tvDm6uFlM5Ca3KScuHcWsC7jPCzrN4CK+ MzMcSfI/5uHu+wZNCNV+x7Mafh0i87A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-UyHCTBgQPUC8fhOxI8ya7g-1; Tue, 13 Jul 2021 05:51:48 -0400 X-MC-Unique: UyHCTBgQPUC8fhOxI8ya7g-1 Received: by mail-wm1-f69.google.com with SMTP id l33-20020a05600c1d21b029021c6168367bso1851464wms.9 for ; Tue, 13 Jul 2021 02:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=tbVpCJ8GLa0hxilOdeafb29laMr4Nxg08S4wR66Adcc=; b=PhOEEbQwIg2QWARqDuxu/RmizdVKa01NO9poRoGhSWNXpYyfciaAnSy5JDFuVLuH/k mn8Qrz6/9a7QhhdYxlN1y4BoNVRm8PNepAm0Z586EN7IoRxCsV54j67+nYz6aOGFS1QW E5+ZQBG+/ljqE1/3X4TBTw2fYC9WC2hsO2u5pmFavWJ8Siiw7HnKuB5ilpwEETXy5dSA MPc0IBFkfnva9woplM0R+IO2l4Wmakxo5MkOg1xCfUhBB1VS9uKuqdM8jWcuYL7OWHNh jRCmmFW3IrNoAqCtOodzwxaL3bt/npp1JR5hGJQo5uEQbfoa6QHx6evTm6GsL+dlXJ2Z 2Lew== X-Gm-Message-State: AOAM530Abtnqvsvzm/A6X+JAEB+fGWuj+sPKCisp/enWFQs+FgBBAFyU eMWLVuzmgve9qBSIeWP/zCgs68H+lEdD7Qn71w8wxKyW/+H4Vydv0KuwrrS0YCSyFM8cqXRzPse u727zpuVO1HpQkPrWjk5w8wWg/hczJYToCYdBGowjaArzgDKZYKL3csmcmg8= X-Received: by 2002:a5d:46cc:: with SMTP id g12mr4415731wrs.136.1626169907635; Tue, 13 Jul 2021 02:51:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/GqNgtzZRWmYLDz80dEOp59PHsbGvCWr4Au8zvbhBgLzCZbb2+X12ymf+JjOj9uQxKghRiw== X-Received: by 2002:a5d:46cc:: with SMTP id g12mr4415706wrs.136.1626169907427; Tue, 13 Jul 2021 02:51:47 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id n7sm1756180wmq.37.2021.07.13.02.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 02:51:47 -0700 (PDT) Subject: Re: [PATCH 1/2] mm: remove pfn_valid_within() and CONFIG_HOLES_IN_ZONE To: Mike Rapoport , Andrew Morton Cc: Greg Kroah-Hartman , Mike Rapoport , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210713080035.7464-1-rppt@kernel.org> <20210713080035.7464-2-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <7300dfe1-0c6a-ae2e-2c48-c885248ec263@redhat.com> Date: Tue, 13 Jul 2021 11:51:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713080035.7464-2-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c+eewRcH; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 4dj8uzzkhmqa5o9wf34euyw6o61p6zmt X-Rspamd-Queue-Id: 56BA2F00038D X-Rspamd-Server: rspam01 X-HE-Tag: 1626169910-678199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.21 10:00, Mike Rapoport wrote: > From: Mike Rapoport > > After recent changes in freeing of the unused parts of the memory map and > rework of pfn_valid() in arm and arm64 there are no architectures that can > have holes in the memory map within a pageblock and so nothing can enable > CONFIG_HOLES_IN_ZONE which guards non trivial implementation of > pfn_valid_within(). > > With that, pfn_valid_within() is always hardwired to 1 and can be > completely removed. > > Remove calls to pfn_valid_within() and CONFIG_HOLES_IN_ZONE. > > Signed-off-by: Mike Rapoport There is currently the discussion to increase MAX_ORDER, for example, to cover 1GiB instead of 4MiB on x86-64. This would mean that we could suddenly, again, have holes insides MAX_ORDER - 1 pages. So I assume if we ever go down that path, we'll need something like this again. For now, this looks like the right thing to do Acked-by: David Hildenbrand -- Thanks, David / dhildenb