From: Shakeel Butt <shakeel.butt@linux.dev>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Usama Arif <usamaarif642@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] alloc_tag: introduce Kconfig option for default compressed profiling
Date: Wed, 16 Apr 2025 14:41:50 -0700 [thread overview]
Message-ID: <72pac6pkjebt6xo7engiuuu7r3zr7fu6fh6bj77f22m7gslxgr@3gjawofplas2> (raw)
In-Reply-To: <CAJuCfpEKrX+1_SJ5fOyT6JLDSNcDxjcfBMj9_siVZt-rX5WQ=w@mail.gmail.com>
On Wed, Apr 16, 2025 at 02:08:31PM -0700, Suren Baghdasaryan wrote:
> On Wed, Apr 16, 2025 at 11:06 AM Usama Arif <usamaarif642@gmail.com> wrote:
> >
> > With this Kconfig option enabled, the kernel stores allocation tag references
> > in the page flags by default.
> >
> > There are 2 reasons to introduce this:
> > - As mentioned in [1], compressed tags dont have system memory overhead
> > and much lower performance overhead. It would be preferrable to have this as
> > the default option, and to be able to switch it at compile time. Another
> > option is to just declare the static key as true by default?
> > - As compressed option is the best one, it doesn't make sense to have to
> > change both defconfig and command line options to enable memory
> > allocation profiling. Changing commandline across a large number of services
> > can result in signifcant work, which shouldn't be needed if the kernel
> > defconfig needs to be changed anyways.
>
> The reason tag compression is not the default option is because it
> works only if there are enough free bits in the page flags to store a
> tag index. If you configure it to use page flags and your build does
> not have enough free bits, the profiling will be disabled (see
> alloc_tag_sec_init()).
Is it possible to fail the build in that case i.e. check the page flags
availability at build time?
next prev parent reply other threads:[~2025-04-16 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 18:06 Usama Arif
2025-04-16 21:08 ` Suren Baghdasaryan
2025-04-16 21:41 ` Shakeel Butt [this message]
2025-04-17 0:11 ` Suren Baghdasaryan
2025-04-17 15:47 ` Shakeel Butt
2025-04-17 16:00 ` Suren Baghdasaryan
2025-04-17 17:50 ` Usama Arif
2025-04-17 18:35 ` Usama Arif
2025-04-17 18:38 ` Suren Baghdasaryan
2025-04-16 21:52 ` Usama Arif
2025-04-17 0:15 ` Suren Baghdasaryan
2025-04-17 14:33 ` Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72pac6pkjebt6xo7engiuuu7r3zr7fu6fh6bj77f22m7gslxgr@3gjawofplas2 \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox