From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8361FC433F5 for ; Sat, 9 Apr 2022 08:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7F2C6B0071; Sat, 9 Apr 2022 04:15:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C08506B0074; Sat, 9 Apr 2022 04:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A827E6B0075; Sat, 9 Apr 2022 04:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 95E246B0071 for ; Sat, 9 Apr 2022 04:15:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 249BC183EC5BD for ; Sat, 9 Apr 2022 08:15:39 +0000 (UTC) X-FDA: 79336631598.21.A75FAF5 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 9AB65C0004 for ; Sat, 9 Apr 2022 08:15:38 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id i20so2930456wrb.13 for ; Sat, 09 Apr 2022 01:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sw+fQbvS6SFTnotjqrxbhqCVHIPsenv7yxMzOYGId1I=; b=swx5mkkbJNix1TPl46oJjK+Fw0+J2z/XHhCyUPh+dcKkTNBekj88xkgZeDCIEgfzZd +FA0t7ckuNM4K4OwCilxgo/M+WNIfDm8hTC88nPXmxm39Wp7Y3PlmqfYEyysUU8hQUUf QcFmQYaxbOUrhMO1omCXZ8F/Rog5zixS+JPWEUQR0KkNkX4orlWG0JIiavrTh9qI4888 PfuJYdextltFDNT3Q+47ZPQuPkokUbAa0jhifptu2z1GSQMaUF7eHMsw0ukFDymbedqA fJT7coHgReWy+GC/y+kW2UJS/DziuPPZTxFTP9KzlhdtF9p6DIhUJyZVoMiIdhtFkJM+ cESQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sw+fQbvS6SFTnotjqrxbhqCVHIPsenv7yxMzOYGId1I=; b=EfTtrNt2nYNDFUacV00BbgGaCDUS8c6KfvM+OLKtl9bONNpX3WtT9oJ4+n7+vOTlgZ 404LGbpU7OMZ6HbS+habkgjKh5MYeTTqg/N4m4jLRBLIoXKllnQxKfeZzxg06BXLcpiG vTUw1HkmXTeYaUD9OamM/PKvijRKGFibFdZLGkiEo03Gcoj5HzYvBLn82lVYQOv7Orl6 uxquOD8KChKtgR+za2hjKiJ2krN1NNvdw3g10ZwfgPs9Pv0Auh9PO3xXG8zUU7GM59w8 ezGpJfOVQ07hN2hGWwQyUCOlFCDzXLEq1BGfV8Eo+NVR9VC/XFATgWEcaz6AU2Qeyhps 498Q== X-Gm-Message-State: AOAM53354/626Euzq94XYSbetJKVhyehC379yvLEQV72ILm8B3WDN8dP pdGxrMWNfodQL1iAvBmMoSCOug== X-Google-Smtp-Source: ABdhPJzQQyyFsXyXf3Tt03078VjcrkSv2k98fwj9oToPATRHlAVDyH773lIm4bEik17KjObuot5lIg== X-Received: by 2002:a5d:6c6b:0:b0:1ea:77ea:dde8 with SMTP id r11-20020a5d6c6b000000b001ea77eadde8mr17920640wrz.690.1649492137216; Sat, 09 Apr 2022 01:15:37 -0700 (PDT) Received: from [192.168.169.127] (178.115.52.210.wireless.dyn.drei.com. [178.115.52.210]) by smtp.gmail.com with ESMTPSA id m20-20020a05600c4f5400b0038b5162260csm16809052wmq.23.2022.04.09.01.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 01:15:36 -0700 (PDT) Message-ID: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> Date: Sat, 9 Apr 2022 10:15:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD Content-Language: en-US To: Christoph Hellwig Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Jens Axboe , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" , Coly Li References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> From: =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= In-Reply-To: <20220409045043.23593-25-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9AB65C0004 X-Stat-Signature: g9iwmqh36rerqeroj6ok9r9nracxfo1h Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=swx5mkkb; dmarc=none; spf=pass (imf28.hostedemail.com: domain of christoph.boehmwalder@linbit.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=christoph.boehmwalder@linbit.com X-Rspam-User: X-HE-Tag: 1649492138-831106 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.04.22 06:50, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. >=20 > The only places where needs special attention is the RAID5 driver, > which must clear discard support for security reasons by default, > even if the default stacking rules would allow for it. >=20 > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Christoph B=C3=B6hmwalder = [btrfs] I think you may have a typo there: my ACK was for drbd, not btrfs. > Acked-by: Coly Li [bcache] > --- > arch/um/drivers/ubd_kern.c | 2 -- > block/blk-core.c | 2 +-