From: "André Almeida" <andrealmeid@igalia.com>
To: guanjing <guanjing@cmss.chinamobile.com>
Cc: linux-fsdevel@vger.kernel.org, krisman@kernel.org, tytso@mit.edu,
brauner@kernel.org, akpm@linux-foundation.org, hughd@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v1] tmpfs: Unsigned expression compared with zero
Date: Wed, 20 Nov 2024 08:10:54 -0300 [thread overview]
Message-ID: <72e793e3-e31e-4caa-b2a8-96886036964b@igalia.com> (raw)
In-Reply-To: <20241120105150.24008-1-guanjing@cmss.chinamobile.com>
Hi guanjing,
Em 20/11/2024 07:51, guanjing escreveu:
> The return value from the call to utf8_parse_version() is not
> of the unsigned type.
>
> However, the return value is being assigned to an unsigned int
> variable 'version'. This will result in the inability to handle
> errors that occur when parsing a UTF-8 version number from
> a string.
>
> Additionally, this patch can help eliminate the following
> Coccicheck warning:
>
> mm/shmem.c:4378:6-13: WARNING: Unsigned expression compared with zero: version < 0
>
> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
Another fix was already sent:
https://lore.kernel.org/lkml/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/
next prev parent reply other threads:[~2024-11-20 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:51 guanjing
2024-11-20 11:10 ` André Almeida [this message]
2024-11-22 3:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e793e3-e31e-4caa-b2a8-96886036964b@igalia.com \
--to=andrealmeid@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=guanjing@cmss.chinamobile.com \
--cc=hughd@google.com \
--cc=krisman@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox