From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F40C2D0CD for ; Sat, 17 May 2025 20:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DE276B000A; Sat, 17 May 2025 16:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98B5F6B0083; Sat, 17 May 2025 16:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82CCB6B0085; Sat, 17 May 2025 16:21:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 621676B000A for ; Sat, 17 May 2025 16:21:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4CD83E57D3 for ; Sat, 17 May 2025 20:21:51 +0000 (UTC) X-FDA: 83453520822.30.85B57F3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id D11C41C0007 for ; Sat, 17 May 2025 20:21:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wlQCTkRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZLTwommR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jBlXuGoH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Uu32mP+B; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747513309; a=rsa-sha256; cv=none; b=8baZ/IJ2LvMGI9yneMuaieClgFxXxzHCwOwYYPFMNEK5O4rohcJNsdn5w4fJhLX09e19He h1xHJZgzA4HVWoUILX6rzj3wXykACdmM9EyuKPyOY6zU5iQHBZr4UWyvrIgJHAwL0JJef1 Lm9qMQ4RM1xl67ymmF2ngZ/Vjk2kYwg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wlQCTkRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZLTwommR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jBlXuGoH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Uu32mP+B; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747513309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kw0CpV37ybvRZaO1RGP6IG8fm4GRJXF9rmX9jolZzNk=; b=NY3YrzXZM9hZ4wAgxHlCJaudXy+7USOKxMHt7WkKz7K4/n55RTKTrPYPgNFyu/fAIvgVld iwx3tBF54XZF+TQOhLmDElbHn1kz07n1Kn52oCNse1gTPBnhx2UG/RUAqJbrcUNq0DsnyS ZuWFB8OHyfi3NZiD1RCZczz2jK75uXQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DB23C1FF3D; Sat, 17 May 2025 20:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747513307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kw0CpV37ybvRZaO1RGP6IG8fm4GRJXF9rmX9jolZzNk=; b=wlQCTkRX33y2vx0CHYnFZHQRcySLnal89IWQHfIU3ku1Qle+Znx+ZpjPMHHRYO0s5l42xU 6u2Sbxi6XGw2FBhm3vbjD5QR4AAiRmDY4u5gd+oIZA30pMQR7/i9HnhDRhlJ+SMK06ygo4 S+C3DKKyTiIq90sR1U/IbC9gMBq+WAM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747513307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kw0CpV37ybvRZaO1RGP6IG8fm4GRJXF9rmX9jolZzNk=; b=ZLTwommRciZy5NlAh/fujmRGi80SAS69548Bc5aRN/yZUSPDiuhqb8too0h53mj8lUJMxF Bp0cZkAkvtdgwdDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747513306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kw0CpV37ybvRZaO1RGP6IG8fm4GRJXF9rmX9jolZzNk=; b=jBlXuGoHv+4wP9c2d7xmQ5xBSS0Ra1W5EMXqp0YRxdNPVYoaFbZSVQhYr46z17Z0WsTeml fMMLJXAVmFNclfyzqS0WaKD8a0FbwFQXHjAF/qDynOjs5c1E+f/CAnfDHLTA0YB2un7dI7 U95y+JcZVipAnLs4u3rslm26feootlI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747513306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kw0CpV37ybvRZaO1RGP6IG8fm4GRJXF9rmX9jolZzNk=; b=Uu32mP+BrXIkMX5Jmb4ZL/r3mlMW/l4e0G3FSSalKN7JjkWcnZ6Sk1/N450SZFR1JxvAoA W1cGbhihuOuZ4ADA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B75631325F; Sat, 17 May 2025 20:21:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NOrSK9rvKGgrfQAAD6G6ig (envelope-from ); Sat, 17 May 2025 20:21:46 +0000 Message-ID: <72e15406-ffd2-4344-8cc6-1d54005138ce@suse.cz> Date: Sat, 17 May 2025 22:21:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] mm/page_isolation: remove migratetype parameter from more functions. To: Zi Yan , David Hildenbrand , Oscar Salvador , Johannes Weiner , linux-mm@kvack.org Cc: Andrew Morton , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250509200111.3372279-1-ziy@nvidia.com> <20250509200111.3372279-5-ziy@nvidia.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20250509200111.3372279-5-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D11C41C0007 X-Rspam-User: X-Stat-Signature: b4pywo3f4n6kehn8rjk4181uchqrteam X-HE-Tag: 1747513308-273540 X-HE-Meta: U2FsdGVkX1+O3pyOENldTAPrdWLIQ8qX91aQlvq1X3E/2j5wLhSD9w19SpMqTd+7cv8c7MYV6g7zbZjZSfSf+6JauNjISfRHDQnd52Ek37sRIYTkIUBy8DmpGwqopjl7Mi81fcbEF2tgzCsrWh7VSpt97dytmyu3e0LJMgLYXirFzmmGkciM3bItlA/81bKLORo7J2JGqnB7fw1VUuMVr+vMRrqnu21ofqwEDApvFDQPCAtT2cVorDMyGfcobQ4BwQfevEdRabKtkjYZ9iW/3gppPXBMbrF6J39gUXvkWWj+UgNdOXhE2Lyyj7WVg3hO5ASxt6K8zTK/7vxPSXsakJC2KyJtiUrz8KHrluovg8vdK0gywhzjuy11Hdz2vOVD7oqrO9UtEF2zUXhyEJV1/37hBsu6k7ncZqxJjKhp9aikFAgtfds2rBj45w9bznAVPPpwgUbRjLzJIQAi2WPH0YIdCQ7u1ZKKnF+HPt76/s6MMwnMV90qJswiRfat9Gnp3Ie1/72wHPRMJ0Jg/RYMQf15Pj0WunWbOCnaBQsD0gz7AFebXBZnepUxlSbRxeYL8IUTkIS/20RfJRuIUQOAWr+O1VAnoUVpDitJVcHULCO0vCYKcTErAj3EBD9mjcqzb0iZlIeJvsbp5rgyYUm1FhSQIHMO/jLxUh+xhIwgRwwNOEmJV94qY5pF+dAQDm6whpUblJfi1Wh6AK6XxHabpVl0imkDc7WgCGZYVoblGox5wS7PZNoZa/VIKp+5StnOwmWa1IhQ70HRZGs8pk5ecw1OA4+CyJuBLPeq1eGygL8jjP0HkykCqBVLUGeY6YQuXiPrxwODG/hD4khfvs4z/Uh2TD1skzCiEv+BA1DlHi1ZDLQ0+MJbuWFTr+Tph8P9wi2Bv2ZVaO6jM5e4Lv/LQVNApT2VHh+NZT5AAK4NRfpwKHhQ3m41TzVIxoQxd71AjAclQS+TNWrFqHbXHNv jJMdHbvO 045gAbR6trA3lTUjGmMJdKtrLOrtY7abNuxCuJQmCmO+0JFbNR7pntj4PKsNc1uQXJYXMZ9IU+oRtYGtSBzw2vWtZeJEYaS8Wz/5qr09AP3uozJnu/JpDnMskr39LeVAOVcRAvFQPXfVoIO87tcFPZ2EzOIYcNQbdBxkhq6z1DPt4hd+3VOr9mCP4e5Pa+Mrhvvg0MIAPrkS0L+ryUrMz2E5lf/WXvXbyrWUSYbNCvOi9D9i76uPja+jf/GNwCgu6Fw4PK7gwj2x5OYorxXwEgNe30+RfloyNy0kqvDnUpZzc+DGSMvcIW7axpZi2diygM18zHfXI3qezbtnYNW8LiL3Fx1q7msqC5QzUgHEUXsYaiYg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/9/25 22:01, Zi Yan wrote: > migratetype is no longer overwritten during pageblock isolation, > start_isolate_page_range(), has_unmovable_pages(), and > set_migratetype_isolate() no longer need which migratetype to restore > during isolation failure. > > For has_unmoable_pages(), it needs to know if the isolation is for CMA > allocation, so adding CMA_ALLOCATION to isolation flags to provide the > information. > > alloc_contig_range() no longer needs migratetype. Replace it with > a newly defined acr_flags_t to tell if an allocation is for CMA. So does > __alloc_contig_migrate_range(). > > Signed-off-by: Zi Yan AFAICS has_unmovable_pages() adds the flags parameter but doesn't use it. But also, I think having both mode and flags is just unnecessary complexity in this case? CMA_ALLOCATION could be just a new flag? Even if some flag combinations wouldn't logicaly make sense, this has only so few users so we don't have to care to make them exclusive with the mode thing. Also I think REPORT_FAILURE is only used with MEMORY_OFFLINE so it could be squashed?