From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B37C38142 for ; Tue, 31 Jan 2023 14:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E82BC6B0072; Tue, 31 Jan 2023 09:30:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E32B66B0074; Tue, 31 Jan 2023 09:30:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFA976B0078; Tue, 31 Jan 2023 09:30:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BFDA36B0072 for ; Tue, 31 Jan 2023 09:30:08 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89446160318 for ; Tue, 31 Jan 2023 14:30:08 +0000 (UTC) X-FDA: 80415328896.29.442B12B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3E5B24001D for ; Tue, 31 Jan 2023 14:30:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dq6cG/DZ"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675175406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CnMa8Dx5VcMMm/Zxziptz0YY6DNnRe7DuNVWJX2ZiNI=; b=jLWHGEzukMgGwJUuFzpWUIQ4Ivv+JguOaC7M7abqHoT/RpJHz6f2BD8XpdXiFjkvh2yTfh b9IcVLvN5ns4AuF3VtKVFHOU7Y482caPtg1aFD+yiRlRVSZt0WfG297p3yO8CxvC4m4ngV oeWm4w253CjblN1IaqVvBLWBSxs2fy0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dq6cG/DZ"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675175406; a=rsa-sha256; cv=none; b=cceRph/f48Hr7oc/Kb3AWg6RB2NViyBHXOt/5wFOR9A0S83koACf4kdfIW34BkRDdn15Jw DfRvT4q1Q0bclcXZnKslC3aoh4rdJErfajSiAtiX7yyTDheOsP6ph30eNT1xdLIIOghggz RTscM2sPbvZQ98MGZ2RQfk2bl13Lxk8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675175405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnMa8Dx5VcMMm/Zxziptz0YY6DNnRe7DuNVWJX2ZiNI=; b=dq6cG/DZ/h9RRc8J8dsNmpzxeSJVMXa2HY3RWX9clegaonSMjksa+E84RZtjEO60EMJmg3 hGLLMEWwjZySX2shTia2O5WiL7i05qXsDzwCeAM0+5K7GvVf/HpjCjwV24bGsD1dWQnKpU 9TdXfFXvsRczAohsF/Vf3x8936splCk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-77-S1dBr7I4PN2YRfpAGJCD-A-1; Tue, 31 Jan 2023 09:30:04 -0500 X-MC-Unique: S1dBr7I4PN2YRfpAGJCD-A-1 Received: by mail-wm1-f69.google.com with SMTP id bd21-20020a05600c1f1500b003dc5cb10dcfso2646359wmb.9 for ; Tue, 31 Jan 2023 06:30:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CnMa8Dx5VcMMm/Zxziptz0YY6DNnRe7DuNVWJX2ZiNI=; b=VueA8dTImu6wHAA90td/Sf/4i7jHmqZTn1Qci2qXYrM4SuUG2md1LVAzY84cNUWo0f pil/2Gsd4gZmUphuE5COOyT/CZSO5CrzNxdqcQSo9HktVQge4Xs/5ZWJ4gD9ZI1CGhZv O2hJtFg6eSyUamB9lnFVeKAs61HCAL0+pt/ewAZ7Zci2hgZRp+Mozw2yqUAzbcVAfRQJ r3g3TcTi2OFdZQxacf2qVMZpyj2kwZbM6cNV+ToMhOtQSlVA6mPk+GgmDN4u7SJJdXq6 yqu7ZnhJL5smY+xmzwrzew3ohdThndV61TiLDEcX54mLAgymivcGa4YrkJSsZn4y1xfE ickw== X-Gm-Message-State: AO0yUKUHwr+RxHckpk1iXHbNgqvsf56DojPuAUrYaBiX+CKHHVX8y9FB ePJv2nyxL+46F5jWKf9RytGWYJI+jkBThXd9uA6Xp/uwE8UcenMY4VpA4zhug6rEbwfsstrZ9Pr 7RjVWzjYSQZ4= X-Received: by 2002:a05:600c:511c:b0:3dc:5240:53b6 with SMTP id o28-20020a05600c511c00b003dc524053b6mr10041679wms.6.1675175401487; Tue, 31 Jan 2023 06:30:01 -0800 (PST) X-Google-Smtp-Source: AK7set9UX3DPxd3+kgFucScJG+BVpFrT5/64dwE6OpUMXKnU1NbzIRaiLPyFlDQrlDicVTUBQXTBCg== X-Received: by 2002:a05:600c:511c:b0:3dc:5240:53b6 with SMTP id o28-20020a05600c511c00b003dc524053b6mr10041651wms.6.1675175401113; Tue, 31 Jan 2023 06:30:01 -0800 (PST) Received: from ?IPV6:2003:d8:2f0a:ca00:f74f:2017:1617:3ec3? (p200300d82f0aca00f74f201716173ec3.dip0.t-ipconnect.de. [2003:d8:2f0a:ca00:f74f:2017:1617:3ec3]) by smtp.gmail.com with ESMTPSA id n17-20020a1c7211000000b003dc3f07c876sm13450391wmc.46.2023.01.31.06.30.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 06:30:00 -0800 (PST) Message-ID: <72dfedd2-a26a-17f4-87c2-3d71ab3f55b4@redhat.com> Date: Tue, 31 Jan 2023 15:29:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/mmap: Fix vma_merge() offset when expanding the next vma To: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-next@vger.kernel.org, Sanan Hasanov , Matthew Wilcox , Hugh Dickins References: <20230130195713.2881766-1-Liam.Howlett@oracle.com> <97ea66a4-54a0-68a3-c42b-f3c36c69768e@redhat.com> <20230131142452.sfrmubta4ojejct2@revolver> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230131142452.sfrmubta4ojejct2@revolver> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3E5B24001D X-Rspam-User: X-Stat-Signature: 1m6553dn3fnez84bhernuod8k1e5fdcw X-HE-Tag: 1675175405-815912 X-HE-Meta: U2FsdGVkX1+vXW4hcJvvmLaVLWdf9nP6HuSLFfBp8Di+akAZ4FRgNvWgcEKrFk2S1ZIkHsK9BN30msGmDNuMWV+RciIQ9RfaVBK+M2TBveEQleZYTVAkQfjjQm38YMq+sqLbNl/yvsBoxP30OzXJqL7SKgGXpX7cFYL8lZaxoAwRUvREpgntBOjqNjgfEFiHONgGeHk61G0SOFDw8MsBenLUsbivUGfJP44UmFgrnxuN6fqELQ2JQZOFbWNhlTjfaRepGZaRlnsT5KOUaEvbzxXX9MHsv3tOKt6KhcFSh8ARUPb145LMsl9rY5ESYJUuqnWyNw3KeU+HBWy5mWvX/r+uN4wezqHYnUzGuqmFiLtSHXMI04tQ/dMi8h8/lEHRAoO3032cKPd9/liXk+PIqbXRapVKd2IJ7nR9c5/1Ewt5VmVWAZUOvRMNnVtlrD6TEOD6fV3zGlvhMTL+Bq2h+N6qec5slXOG0drvIXGR3vCYs1DxioSSpLHe3a4sNrnSnwB+7GpE2bKANsjYYGZADjnTc3HtUEj3pjB5avJzxn5f75Q21A1xyy4+2b4pFc+8gmkdax2TIplpbeW2l0+xHYljQP+mgesqskn51jMZyvZY3ZuT+rlQHVYei17gIoy5eRZCW70t6xx4PpODgwlq+cBsF3qbaiO+/oX+AuWTdwxugrEZKlkLTZR+0zujZ6V7qZXRNIe89Mgwg8LhnIV1IbSxaYD0C5X/gbVLpy3mC2iRjeNpzH++P19BvcjBMhOP5SYuUzxqvGFMvE3PzY585UVpky7FHQF8F2hOyFNYNB4h5OjjL/BvIJ9ILJ/ntq5Dt4WX877Bf0dfJ4Y+GpsIjsbhg3Pk0yyVcIgb/7At3ru5caNP16LsSgUNsfDt4ZNpBzw7rYTCmGjtSkuNG7ADY04cDRAjKBW294sJQ5rEBJt3+PXp3Gbk0d8qIYCORU6uzVm1YXcRItYHHUhm+/4 2+XRC22m PnDFCXnKvUtpltGA/jDeUXgK/iGBLbQAvXQT2bK5ylN7tDhKHEVCuKzKo52BR09P4VZlUhAQXbihG4vhaqgxaPm0l3zxKlLajRNq/KwpXOmXxvosKFn2HXtIy0VEwoSTrRAq1CSJAASg1Lg8CEuiEg2QfgwdleU16IjTLgxSGTahml6hbqEJflC7cSwec8TGWl/sW8SFr24I6ccrwMU9TbIG8+QgTex0hZEUHTxwLz9BvNawDD/1yrzoLnlxOThqK+Qh26z8HMEoJvIWKGUwhjY+41wIQOSnM7Sj1CEiMNI5vsD35MUWkLe6QU1L8tXQuDEi6CvIimSzhLNeNrtyDvju1beopsF5gF8WHbyn8g8EtJj98bckhIxEWXTEnRpfxUMawUMy2glWi/Uhm6E1nP7QulAn+ONYsxfynrsuCTdezTHbwt1e0N+YnifOoOkSfacXaZoOothrkYfvrSQNlErXjTn50w1BqJQX3yC1IKncaJr/tbcgyQYZRuq3AA+MdP02ex88bJVDF3hwXr8+QVbm71euAJh1MUhO1FXe5NaqYsao4gbNkWsEkgJstoFgkAIjSWdVtfgyZ+tmnplZp6CY6S1DD3CxLAPmI2MRP0io4oj4cduLWxv5iKUbOSNvqadmA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.23 15:24, Liam R. Howlett wrote: > * David Hildenbrand [230131 03:35]: >> On 30.01.23 20:57, Liam R. Howlett wrote: >>> The vm_pgoff was being set incorrectly when expanding the next VMA to a >>> lower address. Fix the issue by using the mid->vm_pgoff value for this >>> merge case (aka case 8). Note that this does not change case 3's >>> vm_pgoff as next and mid are the same VMA. >>> >>> Reported-by: Sanan Hasanov >>> Link: https://lore.kernel.org/linux-mm/IA1PR07MB983017D2FBA174D2FF78CEB6ABCE9@IA1PR07MB9830.namprd07.prod.outlook.com/ >>> Cc: Matthew Wilcox >>> Cc: David Hildenbrand >>> Cc: Hugh Dickins >> >> Fixes: ? > > Fixes: (soon to be invalid git id :) ("mm/mmap: remove __vma_adjust()") Ah, right, upstream was not affected ... :) ... so this should be squashed into that commit instead as long as it doesn't have a stable ID. -- Thanks, David / dhildenb