From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFC6E732D8 for ; Thu, 28 Sep 2023 14:18:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B82E68D00AF; Thu, 28 Sep 2023 10:18:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B31D48D0023; Thu, 28 Sep 2023 10:18:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20E88D00AF; Thu, 28 Sep 2023 10:18:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 93E688D0023 for ; Thu, 28 Sep 2023 10:18:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 60B9BA0E65 for ; Thu, 28 Sep 2023 14:18:10 +0000 (UTC) X-FDA: 81286210740.21.6E22718 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf01.hostedemail.com (Postfix) with ESMTP id 2051240027 for ; Thu, 28 Sep 2023 14:18:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=CdCYM8+4; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695910688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YomJPH360iMASHFc0ge10/1k1MAdU+zIP9mG8pm9jOg=; b=TT+Tw4DBPhNxjlsbUe+EY8Tr15JRC545iSb4Dul+fstWqU/HUQETiEsQEYmnEviJbmh+Rw kzrDqu9TV+kga8xCouivfcmjq6k/j1IXDMMYP9uLFzFu8p7FTNl/L1kr+/Y3WesxEl8tII 9GYJywwf/BlMc+ApSt2hKKDBu/RRULA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=CdCYM8+4; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695910688; a=rsa-sha256; cv=none; b=ZexI0258lzEWBPDl5gARH7BKb744dpoJYc7Ak95ZbEVe9nN0OvBd0Iq+ZQrFVfcWTgUia6 6SAMJD1k0Kgs2zgoyygNA7Ha366gdK9fKPRkjN3hTgXXW30xThuv1RDqvXOqELauxtGM1i Hq/afXPA5PQZv2rz3+hhpyHyFEw3AIY= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1c725fc32f5so6103535ad.1 for ; Thu, 28 Sep 2023 07:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1695910687; x=1696515487; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YomJPH360iMASHFc0ge10/1k1MAdU+zIP9mG8pm9jOg=; b=CdCYM8+41lel34J9KveZHu3f+cRo/9/XgdUEVYOMEAIfq6ZDkZd8GmG8H9in5cMHnh l7mad3WEMejAPkj9sywx4zHOIEYB2OgX4WUiNH59OxeMif0pVZ2zj+UZJAsPiWdauwtn MF9qma+/yJ/OCoK4Oy+JrssLHcTZgmG/U6GuPm+77CAeg5p1b2mq3Q3YM/5ThcHGKMIZ O83ep/GJbaeHYScDDVUf3FgLZ5DgxV69WCos3tPrEyH/3nDBWGQ8uL4BeQj2wqjs24QT e5T21iZfDow7CrRTTXWGJa0kuwnLXqmzblION8XCO43CkfFxZgvxO6WnC3+fUhGZLUOn OPXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695910687; x=1696515487; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YomJPH360iMASHFc0ge10/1k1MAdU+zIP9mG8pm9jOg=; b=lZBHl4I3VXj1bRyrNZ6HiVWQTg1XOXHIcbtdD13ayOgfIxl2Upz2foUoUkjBbGoGQe kmaVe48ao8t7eEoT1NU7a9okKJ8I8rW+1N0/NO04aak0hqid4n/q3INuhvtrnxaKuHvY U2xuYac2Ol+q+OmD/h33f8Z8pUIKBXVTRra74WrC7BY0xbywhkOmOXl5Lc2YgZwPw07T X4KPbQjKPxwXZZpx5PXMOf25QQ57xQNhhacXiJhzJkz1lmYpWwpsC7pZFJ7pSbMg8gnI GiKHa2vZ96IGegjlEDBl6VnNH8b9Wi3gFsxFWPpDCpDLs5FwgUEuRj91EcloxJl2b9bS l00w== X-Gm-Message-State: AOJu0Yx14CQXyqfviy1sWp0mlDyqZhYhtc2SsxSpwRDnu7udVXxfju9P 6rmuz9ujSvNuG1l+xl5rNbaG1Q== X-Google-Smtp-Source: AGHT+IGVwWQyqO2wf9CGPxLwLdRj0KOPVDXo9mh85L/XiM+jqCiUhdBr4+xsXsLxYM46GOI3pLpmGg== X-Received: by 2002:a17:902:e885:b0:1c0:bf60:ba4f with SMTP id w5-20020a170902e88500b001c0bf60ba4fmr1277405plg.4.1695910686732; Thu, 28 Sep 2023 07:18:06 -0700 (PDT) Received: from [10.254.163.112] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id e21-20020a170902d39500b001b9e86e05b7sm15058062pld.0.2023.09.28.07.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 07:18:06 -0700 (PDT) Message-ID: <72d0e76f-2837-f2ca-6451-f8d808f3338a@bytedance.com> Date: Thu, 28 Sep 2023 22:17:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] fixup: mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} Content-Language: en-US To: akpm@linux-foundation.org Cc: david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, dan.carpenter@linaro.org References: <20230911094444.68966-41-zhengqi.arch@bytedance.com> <20230928141517.12164-1-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230928141517.12164-1-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2051240027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dgkfmzg8zdwq4hz9kd3ba95zpj3c3n1b X-HE-Tag: 1695910687-367765 X-HE-Meta: U2FsdGVkX1/fisPJEAjtvfqGCTrYoovSBTIFAFeny5cKzNpSxBaUgyCBloSCmjIcl7SFD5OUkdJ64/aNkOO0/KbjX2WSYmATvbIjAGe0X4jeEf31dV6qhlEkD5Sm4NSG6uA9pGwVOM8gxWzse81s4g74b98h3dYUq8X/bNoGZegdVZwFRFRP/a8d9MZvoE4jm872jrtnd0rTL3ZUgObQF9JyI5O35SUrVdd/vBQPu7b4LME/8FFYQMl4IVl9PkXZq9JkKf5cLrSUjC68f/8CMaaYoLPydFk9kSVDSAl9nlogBu5Eln0yLk352hKzNERQvcoMzV5h0PDc35+zsCc0mNO0CajFEPBeNerNaQ+3WbHdla7uS7CrOTXvHI1vJBSTVQcxLE9iImA/dANF/bgwRN2vzm34FaO/+IJO3lKh6BmQbgJJXGs2xBIUIzQHjwjtkr3PMxkKbuAHD+uOYDW1D23LNAWhVdpNR9ZDHitZ4ngTNwjUQguh9nikVehzfjkRohKqNgCrsoMEZErVp+i7sKqcH7+yo1T16wJj1ZZo/kiBVypEs+G7pG4kglYkR41raxgmBcge/MRI0x7TLddelkYtGt+4fSPmPQhMcMWgQKkr2eReIt4UENiG/F/LtmGq1Ai9SliEkMn1W655oXlN4kNHT+wuT3BlvgkS4iKRJfeN+xpS7S0pSn6qvtNh3j4eejTSXkMwmwUHCpIxfS7UxkjxKTwXFYxcRylM9RKzIMNHGjdSuQk95DlEDCEOxn2iYyZFCihVnF23re/SZz0OK80PU8L2KHMwlVfuPOVeJBYbyLp9Co/WkfiAmE9OgabeVO4XSxFFHpE2acRSJQqUpvCXOgMHOVJaf9llD8xVDEZnHrQwHi2aE0ctWEgQbhWklIkER7i/HA9oXwbAg6U6vY6VIbg0BG38lL4OYaR1J+ysJPb8SBR5e7q2cdAHBVc4JFlvf9Lt1p4hW4eYHnP m2jDGLxE aNdCYgYMDBbynRs0ZYwBORNI06TnZ6+QcwM+TKfnQdFGkYvu6sDIrWopQ2xCkpOpdPi6gIrSFQEEPirP/S0BSz+QWdLtVKq/wEzOGm1s5VhuXUUpYnWWNdDrPNhXW+wAB5slJ88qJQdGykNPKxZoylPztDC2WYDr70GoKI6+AwpceTiw62zXMzy05zdZxBvjJ4HGgmFMPhBRiRe8SMf5Pgn8GPOKuQNN7m+VWbVAtHMobFHE8bM50oWWcL2WQ8kUYJt+r538Zv7xJGmEe2zaDUMlXbG6yPvA3tXbkuVpQeAEuwiCTEY3nJg5syy/NiazL+9RQHVKs9yBq4qLAI3iWikI9L1SEjL507Z16FpIgr5Px7sWtKXcm9uTIZ+0oX0CrWh8xzXr+4WjESr08KcFFpgaQt2M4tfl5PTbSTUUsOsxy9EKVSr1du3qvWmD4qe37eJweRkGuycZI8xTJP1XUjIH6lbIdSourFt/ryWsaaPNZCUXDsMFnMxDhF34025ZEMOzuaeHm6yB7c+kbu+425I7FTSK1hNQ8D1NdZb//rNw3S7E5y7Ecd4+xqMe/vQwso3bm7+xhd/fIZUdleJavxkE2Dg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, After applying this fix patch, the following modifications also need to be applied to the "[PATCH v6 45/45] mm: shrinker: convert shrinker_rwsem to mutex". diff --git a/mm/shrinker.c b/mm/shrinker.c index 6857cbb520ea..dd91eab43ed3 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -96,7 +96,7 @@ int alloc_shrinker_info(struct mem_cgroup *memcg) return ret; err: - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); free_shrinker_info(memcg); return -ENOMEM; } Or do I need to resend the entire patch set? If yes please let me know. Thanks, Qi On 2023/9/28 22:15, Qi Zheng wrote: > Dan Carpenter reported the following bug: > > ``` > The patch b6884b5f15cf: "mm: shrinker: add a secondary array for > shrinker_info::{map, nr_deferred}" from Sep 11, 2023 (linux-next), > leads to the following Smatch static checker warning: > > mm/shrinker.c:100 alloc_shrinker_info() > warn: inconsistent returns '&shrinker_mutex'. > ``` > > To fix it, unlock the &shrinker_rwsem before the call to > free_shrinker_info(). > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/linux-mm/f960ae49-078c-4c00-9516-da31fc1a17d6@moroto.mountain/ > Signed-off-by: Qi Zheng > --- > mm/shrinker.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/shrinker.c b/mm/shrinker.c > index 893079806553..e9644cda80b5 100644 > --- a/mm/shrinker.c > +++ b/mm/shrinker.c > @@ -95,6 +95,7 @@ int alloc_shrinker_info(struct mem_cgroup *memcg) > return ret; > > err: > + up_write(&shrinker_rwsem); > free_shrinker_info(memcg); > return -ENOMEM; > }