Re: [PATCH man-pages v2] process_madvise.2: describe 6.13 behaviour permitting all madvise flags

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Wed, Dec 04, 2024 at 11:13:44AM +0100, Alejandro Colomar wrote:
> Hi Lorenzo, David,
>
> On Fri, Nov 29, 2024 at 04:44:22PM +0000, Lorenzo Stoakes wrote:
> > Since Linux 6.13 it has become possible to use all madvise flags when targeting
> > the calling process. Update the man page to reflect this change.
> >
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Thanks for the patch and the review!  I've applied it, with minor
> tweaks.
> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=7148a8cca8d693731d98c09bb7bf9d585a36e695>

Thanks!

>
> > ---
> >
> > v2:
> > * Use semantic newlines as suggested by Alejandro.
> > v1:
> > https://lore.kernel.org/all/20241129095507.11001-1-lorenzo.stoakes@oracle.com/
> >
> >  man/man2/process_madvise.2 | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2
> > index b78a61553..2ebbfea44 100644
> > --- a/man/man2/process_madvise.2
> > +++ b/man/man2/process_madvise.2
> > @@ -54,7 +54,9 @@ This value must be less than or equal to
> >  or accessible via the call
> >  .IR sysconf(_SC_IOV_MAX) ).
> >  .P
> > -The
> > +If manipulating another process,
> > +or before Linux 6.13,
> > +the
> >  .I advice
> >  argument is one of the following values:
> >  .TP
> > @@ -74,6 +76,10 @@ See
> >  See
> >  .BR madvise (2).
> >  .P
> > +Starting in Linux 6.13,
>
> We use consistently "Since Linux ..." for saying this.  That allows
> grepping for a consistent phrase.  I've applied a fix for all pages that
> still had this old wording:
> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=b159e0d6770a860f0d0ae1693dddb3b6116e7d9b>
>

Sounds sensible, thanks for cleaning that up.

> Have a lovely day!
> Alex
>
> > +when manipulating the calling process,
> > +any advice flag is permitted.
> > +.P
> >  The
> >  .I flags
> >  argument is reserved for future use; currently, this argument must be
> > --
> > 2.47.1
>
> --
> <https://www.alejandro-colomar.es/>