From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B524EB64DC for ; Mon, 17 Jul 2023 09:37:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 067D56B0072; Mon, 17 Jul 2023 05:37:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F326F8D0002; Mon, 17 Jul 2023 05:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD3598D0001; Mon, 17 Jul 2023 05:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C99256B0072 for ; Mon, 17 Jul 2023 05:37:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B794160486 for ; Mon, 17 Jul 2023 09:37:12 +0000 (UTC) X-FDA: 81020600304.27.EA8DFE4 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf09.hostedemail.com (Postfix) with ESMTP id C6463140010 for ; Mon, 17 Jul 2023 09:37:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=qDukg9vA; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689586629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=SiPB7StZZ6x6e5NL3gvnzEWtdfP0XSKdZ/OpGdjTDOg=; b=YWlygU9idgbFfA9vyAzXhh0cpFXdjNbpZ5Wp0ppvv7cJZ8VJA/O8vm8sNlYKXa6QC1FmFH brDDXjBqFRfmpXfDnGVWKnZ/AABuO/mFPBnA4X5eVvsEKbJ92875gPPCHUDU92kAn1cNt0 IJF+zCZdFKkzU7/gUlMIgoRsgP0HbLY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=qDukg9vA; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689586629; a=rsa-sha256; cv=none; b=11LepO6oky4ncOpOkKuqb1Jt1cOHFCptXNiXSV46JNNMY2qugZcebObKsiBndX7TStB34U QpDHMn3LPmrdHXuO81suERZR0oofxKimzKbFvpRPGJzZb1L+PFB/o5qDyZ0tKNtRFjkSCH dKaWheHmK+FBHE2AIRBlEB/nj2z6fVU= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b6ff1ada5dso62702041fa.2 for ; Mon, 17 Jul 2023 02:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689586627; x=1692178627; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SiPB7StZZ6x6e5NL3gvnzEWtdfP0XSKdZ/OpGdjTDOg=; b=qDukg9vAEwT2sB0T34z5aXzyCczq6PyoF+x/8fXh9IahcT4YTQjAYo18TrH8/R361e jkfh2zccQaYkQ34+IRQRShpaRUfi7p6PL460mScMY4u70bGw9QhMX1iqcDd7YeCNxYUC +/eYTFWrDwh2PlsNvUES4TIy8VwJ5cQK6P+a2F5/XwHZ0qY/dHg07+PpFPmp9nDcxxNZ sgLEsWJP6awiNX3xnrVaEi0fhc0ufsHSM/k4EqbAeov9WyfmKQjXuE7ijKiPnuxDrHYX 3Po+wrUE9NSvwMOee7nzVceeewaS5qY8tZc87ELYXZy/2sqNx4EwGzQyvnboePeL4Icg zLzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689586627; x=1692178627; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SiPB7StZZ6x6e5NL3gvnzEWtdfP0XSKdZ/OpGdjTDOg=; b=D3/IF28foSfz9Z6M/+wNElAS1scE0IaJkUgwRvM5EwBX4czZMj9Qi7mpFoyZEh5N2y TL5jJ2dv7tvmUnrxQ+b0qhEZYqt4LH+f7IAwTCoswGv2eNifJsGhNf/v7Mva3hQx0COq 0ZkyFsiatOxoPjj4Z7/CMuzcJyHReZyvTsjKJ0pXTtyFMA8GM62AGmhse5h9ghCmPkHj /J3YJd45uB/QPyIprLYb6ufw14fZ8PcssOyixj3ZqbojvyfeskyATlHnZ3epNDnO5GpU LVaV3wvH2TQ7FvNt3mO4LhUKnFuRcQBEfsYTfll019lKluSbeQH0fZDVvZfss4OxKklN Pp+A== X-Gm-Message-State: ABy/qLYAmjOr97cazjvgz+OMxE6NMB5lBhx+RQKtlXpcRVxelhVfcpNV njhlaPkoeDJXVcLPo0KPYi75BQ== X-Google-Smtp-Source: APBJJlGjZORRm0ekhz8C7J8JyR2K+csJ+uB5Q3POGWsqLgPF0xmoJb/GUfViiCDU1Lj32lCR6BVUEw== X-Received: by 2002:a2e:910e:0:b0:2b6:a5df:c7fb with SMTP id m14-20020a2e910e000000b002b6a5dfc7fbmr7263498ljg.26.1689586627585; Mon, 17 Jul 2023 02:37:07 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id a6-20020a05600c224600b003fbc89af035sm7646689wmm.17.2023.07.17.02.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 02:37:05 -0700 (PDT) Date: Mon, 17 Jul 2023 12:37:01 +0300 From: Dan Carpenter To: lczerner@redhat.com Cc: linux-mm@kvack.org Subject: [bug report] add default quota limit mount options Message-ID: <72c946d7-65c6-4c9f-bf58-9c1ffac20715@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C6463140010 X-Stat-Signature: 8hfx4nb1fbumazk1eoi8iz6a95ruhq1r X-Rspam-User: X-HE-Tag: 1689586629-524035 X-HE-Meta: U2FsdGVkX18Fc6/HXla7dKtbOx94Aac441N7AXYyAASISMlUyVga4IBkt8uWR+MAbODJZB26nZy0TeYP8dxCbJKPO/6ppNrpab1Ecf0LWHEp2hIhw4UxfiX+O0O0RTr2C1aTSraPJAiozUehQdn9n5jMsRWr1iUdwVHWkVTYEkoYdsqYCGwAQ1dFpaC/neURg9VWcILeEVXX+rWcDQYHT33qYKjLb0F3oysP4b3qAwZLIEiM2qiE16Kk6uiW7L172hb/nbj9qwTK0jYhM5qUc+dPNeOOAnulP+E7VBPluHzjd74XF4/gGmbpHxna1K667hZYBX5DY5A8fviRE8j6QZCjgv3OuxgMnsoIhr4gK+h3ZVVpFKPfg+d4/o8zTXLpiTQNZb4TiRpNXWmBL08EC36O+aHeKZqc+G7voGtB0/mv05KWaeMzNpt+Nkc29l4uR2uZkSq9rRs8OLA2+E30M/CqaBplqwvRTLnIGM78MNUjLhHGuOiBN7udxdB/uVQt8nkvpOlEbaell6og+dTgzWWZBSO+yx2+5dYAxx8HGSbKox+BBaqYexZAucce/8jjvoiX32XgaT8jTqPJi4XZ3BRDgvxQ8HtlvoTsdzwyrpB0ttB+MZgy5tUpQ1c5vcv/y44w1c0fhnLrZdn3Mc3QhdCKa7sF1AiR1FCF8VseIGUNhf8ksnHoo7q+DvERiLX0/11WttZvffZurfqwRx4Sx4HZThgGACaztxDgx2M2vTymScGVgW4EnaLZbgpPpH//kd1ZvXWZApT/v/uKATM0aTUQ3bK1dtSne/gTfmhYNqpLulrU7WCkNwxgUNrW886Wxg+4+ifa4sbPihQpS0Tl34x3PPIMIQeCd924hJL7ZQuNv7urfyS6DqREhYdr35rt8IgP2hfaJq4Y2PsY3qzL/nUh/YegtlNZn9pniqvXGIqNQqwxSKB3sB2kF2C5L2Fy0FX20fjjam9HTu1VJhk 7JUf3rl0 UHHX7M8Zmmv2W6JtVl684wdpsoZqOOXqdNi5at9XS8SscDR94FQzRyotY6dd933C35hybYvfvztfloGmST3g90iVbrjyC40OTDnFGxRig8hBjYd7P6Z16qYl/H0cLP/l54OYB4+kKmK9rg/x0ffNl76smfvCqO26ND/s2zBXauouBbCrz3EZ0V+P+/3E7a63oOe+bJHob48p0qCy18CvwEPs6Ekea1vVY+i3V31j0pILW3w7JWGTOGqcxtbj4DuZuPvCfcWyhKo5/9TYuFFMexKoUCm8chBASi0Gk5bGY0zVzTM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Lukas Czerner, The patch 50b6187cfaa2: "add default quota limit mount options" from Jul 13, 2023, leads to the following Smatch static checker warning: mm/shmem_quota.c:253 shmem_is_empty_dquot() error: uninitialized symbol 'bhardlimit'. mm/shmem_quota.c 236 static bool shmem_is_empty_dquot(struct dquot *dquot) 237 { 238 struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info; 239 qsize_t bhardlimit; 240 qsize_t ihardlimit; 241 242 if (dquot->dq_id.type == USRQUOTA) { 243 bhardlimit = sbinfo->qlimits.usrquota_bhardlimit; 244 ihardlimit = sbinfo->qlimits.usrquota_ihardlimit; 245 } else if (dquot->dq_id.type == GRPQUOTA) { 246 bhardlimit = sbinfo->qlimits.grpquota_bhardlimit; 247 ihardlimit = sbinfo->qlimits.grpquota_ihardlimit; 248 } 249 250 if (test_bit(DQ_FAKE_B, &dquot->dq_flags) || Can DQ_FAKE_B be set for PRJQUOTA? 251 (dquot->dq_dqb.dqb_curspace == 0 && 252 dquot->dq_dqb.dqb_curinodes == 0 && --> 253 dquot->dq_dqb.dqb_bhardlimit == bhardlimit && 254 dquot->dq_dqb.dqb_ihardlimit == ihardlimit)) 255 return true; 256 257 return false; 258 } regards, dan carpenter