From: Dan Carpenter <dan.carpenter@linaro.org>
To: lczerner@redhat.com
Cc: linux-mm@kvack.org
Subject: [bug report] add default quota limit mount options
Date: Mon, 17 Jul 2023 12:37:01 +0300 [thread overview]
Message-ID: <72c946d7-65c6-4c9f-bf58-9c1ffac20715@kili.mountain> (raw)
Hello Lukas Czerner,
The patch 50b6187cfaa2: "add default quota limit mount options" from
Jul 13, 2023, leads to the following Smatch static checker warning:
mm/shmem_quota.c:253 shmem_is_empty_dquot()
error: uninitialized symbol 'bhardlimit'.
mm/shmem_quota.c
236 static bool shmem_is_empty_dquot(struct dquot *dquot)
237 {
238 struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info;
239 qsize_t bhardlimit;
240 qsize_t ihardlimit;
241
242 if (dquot->dq_id.type == USRQUOTA) {
243 bhardlimit = sbinfo->qlimits.usrquota_bhardlimit;
244 ihardlimit = sbinfo->qlimits.usrquota_ihardlimit;
245 } else if (dquot->dq_id.type == GRPQUOTA) {
246 bhardlimit = sbinfo->qlimits.grpquota_bhardlimit;
247 ihardlimit = sbinfo->qlimits.grpquota_ihardlimit;
248 }
249
250 if (test_bit(DQ_FAKE_B, &dquot->dq_flags) ||
Can DQ_FAKE_B be set for PRJQUOTA?
251 (dquot->dq_dqb.dqb_curspace == 0 &&
252 dquot->dq_dqb.dqb_curinodes == 0 &&
--> 253 dquot->dq_dqb.dqb_bhardlimit == bhardlimit &&
254 dquot->dq_dqb.dqb_ihardlimit == ihardlimit))
255 return true;
256
257 return false;
258 }
regards,
dan carpenter
reply other threads:[~2023-07-17 9:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72c946d7-65c6-4c9f-bf58-9c1ffac20715@kili.mountain \
--to=dan.carpenter@linaro.org \
--cc=lczerner@redhat.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox