From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296B2C433F5 for ; Tue, 7 Dec 2021 10:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B33FD6B00AE; Tue, 7 Dec 2021 05:18:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5236B00B0; Tue, 7 Dec 2021 05:18:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985416B00B1; Tue, 7 Dec 2021 05:18:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 8B48D6B00AE for ; Tue, 7 Dec 2021 05:18:59 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4A273180889D8 for ; Tue, 7 Dec 2021 10:18:49 +0000 (UTC) X-FDA: 78890599578.22.39F9711 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id D0BA980005 for ; Tue, 7 Dec 2021 10:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638872328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RCZbDnbEh9UK6bU7RJluwKcGq9uZewyX/bt5UOEgz80=; b=GrLhP/VoXEP0dFgWSs1vDF4+RrtRweLnTq2XWmL5lOnIOwLQBB2TSZQYoyrUg6A3W0LP7H pl/Qgi1MAJ0jLA7T2Rpd4e6gv70aNmeoJhOvE0x/PoIG5kNto7ZlfurQPDJoLb8oH0jHm3 V2ZCD85Rzwmdp01UCjeRn1++oChIk10= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-Uvhdx5wjM6WvPSvufyhFAQ-1; Tue, 07 Dec 2021 05:18:47 -0500 X-MC-Unique: Uvhdx5wjM6WvPSvufyhFAQ-1 Received: by mail-wm1-f72.google.com with SMTP id 201-20020a1c04d2000000b003335bf8075fso7534350wme.0 for ; Tue, 07 Dec 2021 02:18:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=RCZbDnbEh9UK6bU7RJluwKcGq9uZewyX/bt5UOEgz80=; b=1oSSDJDtTFzQyCb/90rJ5+XU5klsK7Vxv2LiO8uqJnru6WKRBtQtVZxz220CuvqMNe tRNBNLwYTTUI1iNakeKX4iv2aMATYjGeEtAksUcHAtPHjfoIMUDI3x3cP49hP282X0Y4 NvfVc+Jg+gpY9XXCF5ST5ailEO/YkK5MKRBQD/mBU2xDwI3lS/8iY5jca+kA0D7ii2+b QcqTzPI3uVSVJpUmoDnPtuUIlBMO+6w706Fk3COSSkkBKkIPXKX6Fps6FBtEBFog3E7C BheSyMdufiJ5CZU5pm8V7SA/iAX/DT/JDlBonXQe4idk2qTGsOmkQkvfiaGnwlIbi1ET rJYg== X-Gm-Message-State: AOAM5325ps38eg2YHAKwU1BTnQB38Fo+G/T9mO7nSLmLfNGlnWE10GWP 6rjwGXOKbrc6V/8CFStkUXm1A+sdSIK7oGE/MW92hZKTXQvXPWx9Wai/Vtq2X2IAWw1GsdKJnvT uMuyYkl3brQM= X-Received: by 2002:adf:8b1e:: with SMTP id n30mr49452834wra.75.1638872326202; Tue, 07 Dec 2021 02:18:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyA2Tl2YN9Wye0XvROD5EVAcbTqHiHWYbDy6hHq2NvqLuJKzyLtdSeyX+0nZwRHbRXD6Ex3lg== X-Received: by 2002:adf:8b1e:: with SMTP id n30mr49452821wra.75.1638872326049; Tue, 07 Dec 2021 02:18:46 -0800 (PST) Received: from [192.168.3.132] (p4ff23e57.dip0.t-ipconnect.de. [79.242.62.87]) by smtp.gmail.com with ESMTPSA id w17sm14565391wrp.79.2021.12.07.02.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 02:18:45 -0800 (PST) Message-ID: <72c5006e-fc04-8546-7754-3b03ae0a968e@redhat.com> Date: Tue, 7 Dec 2021 11:18:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] mm:remove unneeded variable To: cgel.zte@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, chiminghao , Zeal Robot References: <20211207083222.401594-1-chi.minghao@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211207083222.401594-1-chi.minghao@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D0BA980005 X-Stat-Signature: t7mef38i9fpaz1yhe5ka71o6rb97mm1t Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GrLhP/Vo"; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1638872328-864587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.12.21 09:32, cgel.zte@gmail.com wrote: > From: chiminghao > > return value form directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > mm/truncate.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index cc83a3f7c1ad..41b8249b3b4a 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -205,7 +205,6 @@ static void truncate_cleanup_page(struct page *page) > static int > invalidate_complete_page(struct address_space *mapping, struct page *page) > { > - int ret; > > if (page->mapping != mapping) > return 0; > @@ -213,9 +212,7 @@ invalidate_complete_page(struct address_space *mapping, struct page *page) > if (page_has_private(page) && !try_to_release_page(page, 0)) > return 0; > > - ret = remove_mapping(mapping, page); > - > - return ret; > + return remove_mapping(mapping, page); > } > > int truncate_inode_page(struct address_space *mapping, struct page *page) > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb