From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFFDBC4332F for ; Fri, 9 Dec 2022 10:25:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 114CD8E0003; Fri, 9 Dec 2022 05:25:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5718E0001; Fri, 9 Dec 2022 05:25:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECF7E8E0003; Fri, 9 Dec 2022 05:25:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DCE118E0001 for ; Fri, 9 Dec 2022 05:25:05 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B27D2A0A90 for ; Fri, 9 Dec 2022 10:25:05 +0000 (UTC) X-FDA: 80222384970.19.A79E5A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 49EA2C001A for ; Fri, 9 Dec 2022 10:25:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CIkrVoLX; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670581503; a=rsa-sha256; cv=none; b=OACAbzGefCqSSmWn98kCn0V1RqMuv7EoeoNZn22RdTfwZXbi6FPIiheRg2Bq0isjDKRwxd n4PzWk0A0LrM1nklJPKg8DkvE4uMkNXfEnMqJhPMZyRVQn7IdVeCDtQp91LJI8dhgTb0vK o/LrPQXSsImcdPSTGdk5AHuOm9ANzrQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CIkrVoLX; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670581503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PQkKlzVgVNRUgJM+r+np7NVae25JNYpyZIMS2uRgl18=; b=DlBluu0//9rNTZt3eCTbeI1P4E989ubfH7krLeJqEoTzS3oK+aOOVUSvGZhNO8cR2At3ev dnhYGhh93AxsiDstfSkPROWvZcmmxjh3bY07QJEYZP186uXjYD+i/aciHbdQo6v24kRNUp Y9l1ZrUVAFgOiyvO9pEfpvVKCAaR2OM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670581502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PQkKlzVgVNRUgJM+r+np7NVae25JNYpyZIMS2uRgl18=; b=CIkrVoLXcu2uZitGMN9OA4wrSKec5LLnwEMu/JxY5HOHoFFFkOVCjVEZBNGeaUxGggD45x koW2K1PasEBHHd0RG7XwMNYJmAXD8QGutLRzhFb+Q+BNM8CbOmMpllm4anc0D1RLls7P07 SKdCF6atD/BMYY5ifkobwLE/15GAz+U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-364-eywLoAM9POy07XlTHhcVMw-1; Fri, 09 Dec 2022 05:24:59 -0500 X-MC-Unique: eywLoAM9POy07XlTHhcVMw-1 Received: by mail-wr1-f71.google.com with SMTP id a7-20020adfbc47000000b002421f817287so887117wrh.4 for ; Fri, 09 Dec 2022 02:24:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PQkKlzVgVNRUgJM+r+np7NVae25JNYpyZIMS2uRgl18=; b=Y0slVbiTUcH4lja/s/83K2+WLkOSgz5JPT49AP++Hn2okneeBnTYQYkA9xzvG3E4+T 1/yvD8IRW1S103jKqnb8+9JVqCkZ4kI/0oy0hywrFwSzTbsfZHtCdDCftUy4qErtkdTb cmOJWpJGgi7X2eJS5W7RVwxcjLKi2dZA+jWS6vVmu3uBVKkUWK5hXU1S9c/AzpDkpVxE XY63IjQpBLii/ufYjYzmOH/Hj3vukL1c3eKh7DAe0EIJ9Uj57AxjUAs4/TX9oiKpNfuJ GFB/yZLbc0l0+RxmFBnBEh1vjhHeVZP9FjE2WbicMj43aC+1h21qlOAFXmKxhd0XAj/m 7SFQ== X-Gm-Message-State: ANoB5pnGVoGsWanQP35uZlA/dIoqaAep5oJ1GxLmiIMUgJ+CRpeLUC1j mGyo/UthPeaZtc0iGLS9kDhQdU5zfGNrisuJOiCTrmrHJfAZ4BqcMCKOgK8SKZlyAPJ30NwjHlo 3vU3Th1tKDjA= X-Received: by 2002:a05:600c:a52:b0:3d1:c8c8:fb5 with SMTP id c18-20020a05600c0a5200b003d1c8c80fb5mr4426556wmq.18.1670581497802; Fri, 09 Dec 2022 02:24:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf6AC1MVa49QaExok8ylkg0NtcgJrwaAsIOv2fo5HH8LibrrJIYX3LQh80457QVA8mABIgg0OA== X-Received: by 2002:a05:600c:a52:b0:3d1:c8c8:fb5 with SMTP id c18-20020a05600c0a5200b003d1c8c80fb5mr4426534wmq.18.1670581497379; Fri, 09 Dec 2022 02:24:57 -0800 (PST) Received: from ?IPV6:2003:cb:c702:2e00:b9ea:114c:a3f5:327e? (p200300cbc7022e00b9ea114ca3f5327e.dip0.t-ipconnect.de. [2003:cb:c702:2e00:b9ea:114c:a3f5:327e]) by smtp.gmail.com with ESMTPSA id y1-20020a1c4b01000000b003d208eb17ecsm1328703wma.26.2022.12.09.02.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 02:24:56 -0800 (PST) Message-ID: <72a62bf5-7633-f35f-75fd-0222fd0ab49f@redhat.com> Date: Fri, 9 Dec 2022 11:24:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 08/10] mm/hugetlb: Make walk_hugetlb_range() safe to pmd unshare To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , John Hubbard , Andrea Arcangeli , James Houghton , Jann Horn , Rik van Riel , Miaohe Lin , Andrew Morton , Mike Kravetz , Nadav Amit References: <20221207203034.650899-1-peterx@redhat.com> <20221207203034.650899-9-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 49EA2C001A X-Rspamd-Server: rspam01 X-Stat-Signature: xk17cobzioh3nbjphffyg7ybjwqasskq X-HE-Tag: 1670581503-233251 X-HE-Meta: U2FsdGVkX1/4Wii6bnOPky/OdaUdQw9O8SLf6t+Hh7bfliF6lATwkfkaSPrm8uzt6bEpi9qxizRLFjBBDL8gUtU+DkF7IN13FbOqvCbOH1KkkZ0X8D6geAmGjzOLCzDdHdS+DRcexOigkv7YueCFpiUJLLSytSX8Cy8sSC/XfwmHOAuOFwzVf2UQi2Xc9sITCbtS4Qobk05R1t9RFzxBpGsSNm8y6/BnCUKZLvK5ZeJCAF2It0oyS4UQPDkwyKTJYWm83Zs1IyXCD/ou6azZZSTElh3RpqCGKWUag69ORsEZS9psGx2FsCss0eQXe6xLrjw9/dE9LtgzXD85ISE1X7er7aiido6Sw05+7S3CSbineAQoRTvY7ukvxoKDlcfWi9Uuvl+VTnfITyHZwxdH3Mc3LMA1GWG+uNRebgcKaMMAKrdPlubQIwA42v1ZGTIENC6u9ouxuHJmh2U02/8SRTnso48ZamDmp/Bhn20Ynj1WynlD6eCEjp/Ucy0g+4XPR0gzIdfz7UcW2nLe8QpwdCBcuIk658+3lajMG6TBRxllGY52RvWOXfCK8+t0P0bQBmfWJ7p02Yb1ztIR88CMzi8+45c4s7ZFgLb30F4TXlDEYEtbaz4ynYsFgZE8dpGlBVw7E1P4rjVXFC3cLj/2kprqaamCCg3YR2YqLQY+dGxSheJnHtbCGd6BcrL3JazimK2XdR/UuIJ39tCcJWmpeVCIF3MMDZkoXyDNO49ivaDsKkHX2PFDAzAnHwZa7MIatW61TmQPeSr3Ck+EluAvITwIQ7ALHc+odq2A2kU5SP8YR7TF9zTuw6nKgz/kDyJEy0PUknwPmEAuGwuiifzAS6yeY7pnIGY6jmPbJFUWBzKZ2Pe3pWvGHfTaqcSMhKcpGWBjmNHXtOglgqUbv0bqaQJh9l4RlkQLh3ovfzcy4RoR1cWyT8NB15PdMBYZeUDDD75o6LNKcJNOxEQKzlm xgy/CHqb 1lLREma1Em9shE7itGRtMVTa3iU73uFybcCPUM7Pex90DndiY1aR7ztcmibhOeAxgAh3J25iXaWubUoR5oyKvZGn4Im3Anqsje+TXRVc0KC6M4Tcmqa4YRvUK3EeXYjXD0QfgtEHYoPk4raaWiB0XR78iVzwxm3bDLH/74JNVoK4KfJ5VLxMFrqNhpZVd94r1I6+/Y4qJqxG3kBKj5NbylHEud8Q6WZyTQjSLNZQ7dnKDHsZjv+TwjpBH3T3TLKvVWCmL/QxCttSwjP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.12.22 21:47, Peter Xu wrote: > On Thu, Dec 08, 2022 at 02:14:42PM +0100, David Hildenbrand wrote: >> On 07.12.22 21:30, Peter Xu wrote: >>> Since walk_hugetlb_range() walks the pgtable, it needs the vma lock >>> to make sure the pgtable page will not be freed concurrently. >>> >>> Reviewed-by: Mike Kravetz >>> Signed-off-by: Peter Xu >>> --- >>> arch/s390/mm/gmap.c | 2 ++ >>> fs/proc/task_mmu.c | 2 ++ >>> include/linux/pagewalk.h | 11 ++++++++++- >>> mm/hmm.c | 15 ++++++++++++++- >>> mm/pagewalk.c | 2 ++ >>> 5 files changed, 30 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c >>> index 8947451ae021..292a54c490d4 100644 >>> --- a/arch/s390/mm/gmap.c >>> +++ b/arch/s390/mm/gmap.c >>> @@ -2643,7 +2643,9 @@ static int __s390_enable_skey_hugetlb(pte_t *pte, unsigned long addr, >>> end = start + HPAGE_SIZE - 1; >>> __storage_key_init_range(start, end); >>> set_bit(PG_arch_1, &page->flags); >>> + hugetlb_vma_unlock_read(walk->vma); >>> cond_resched(); >>> + hugetlb_vma_lock_read(walk->vma); >>> return 0; >>> } >>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >>> index e35a0398db63..cf3887fb2905 100644 >>> --- a/fs/proc/task_mmu.c >>> +++ b/fs/proc/task_mmu.c >>> @@ -1613,7 +1613,9 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask, >>> frame++; >>> } >>> + hugetlb_vma_unlock_read(walk->vma); >>> cond_resched(); >>> + hugetlb_vma_lock_read(walk->vma); >> >> We already hold the mmap_lock and reschedule. Even without the >> cond_resched() we might happily reschedule on a preemptive kernel. So I'm >> not sure if this optimization is strictly required or even helpful in >> practice here. > > It's just low hanging fruit if we need that complexity anyway. > > That's also why I didn't do that for v1 (where I missed hmm special case, > though..), but I think since we'll need that anyway, we'd better release > the vma lock if we can easily do so. > > mmap_lock is just more special because it needs more work in the caller to > release (e.g. vma invalidations). Otherwise I'm happy dropping that too. > >> >> In the worst case, concurrent unsharing would have to wait. >> For example, s390_enable_skey() is called at most once for a VM, for most >> VMs it gets never even called. >> >> Or am I missing something important? > > Nothing important. I just don't see why we need to strictly follow the > same release rule of mmap_lock here when talking about vma lock. > > In short - if we can drop a lock earlier before sleep, why not? > > I tend to just keep it as-is, but let me know if you have further thoughts > or concerns. To me this looks like a possibly unnecessary optimization, requiring additional code. IMHO, possibly unnecessary unlock+relock makes thatthat code harder to get. For such cases, it would be good to have any evidence that it really helps. -- Thanks, David / dhildenb