From: Dave Jiang <dave.jiang@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>, akpm@linux-foundation.org
Cc: keescook@google.com, mawilcox@microsoft.com,
linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
jack@suse.com, dan.j.williams@intel.com,
linux-ext4@vger.kernel.org, ross.zwisler@linux.intel.com,
vbabka@suse.cz, alexander.kapshuk@gmail.com
Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear()
Date: Thu, 16 Feb 2017 09:27:52 -0700 [thread overview]
Message-ID: <7280edbc-ba2b-2b72-680a-9408a8e764b9@intel.com> (raw)
In-Reply-To: <68216ac2-e194-30fa-9dcb-2020e8953bf5@linux.intel.com>
On 02/16/2017 08:42 AM, Dave Hansen wrote:
> On 02/15/2017 12:31 PM, Dave Jiang wrote:
>> The fix introduced by e4decc90 to fix the UP case for 32bit x86, however
>> that broke the SMP case that was working previously. Add ifdef so the dummy
>> function only show up for 32bit UP case only.
>
> Could you elaborate a bit on how it broke things?
So originally 0-day build found that commit a10a1701 (mm, x86: add
support for PUD-sized transparent hugepages) is breaking 32bit x86 UP
config because native_pud_clear() was missing to satisfy
arch/x86/include/asm/pgtable.h. I added a dummy function to satisfy that
with commit e4decc90 (mm,x86: native_pud_clear missing on i386 build).
However in the process of doing that, I broke the 32bit x86 SMP config
that was working before.
>
>> Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build
>
> Which tree is that in, btw?
>
linux-next-20170214 I believe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-16 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 20:31 Dave Jiang
2017-02-16 15:42 ` Dave Hansen
2017-02-16 16:27 ` Dave Jiang [this message]
2017-02-27 18:31 ` Laura Abbott
2017-02-27 19:29 ` Boris Ostrovsky
2017-02-27 19:35 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7280edbc-ba2b-2b72-680a-9408a8e764b9@intel.com \
--to=dave.jiang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.kapshuk@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jack@suse.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox