From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E02C001DE for ; Tue, 1 Aug 2023 02:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DCE02800CC; Mon, 31 Jul 2023 22:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68CCE2800C8; Mon, 31 Jul 2023 22:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57B2F2800CC; Mon, 31 Jul 2023 22:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48D872800C8 for ; Mon, 31 Jul 2023 22:45:34 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0DBDF1A048D for ; Tue, 1 Aug 2023 02:45:34 +0000 (UTC) X-FDA: 81073994988.02.F99E1D4 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf28.hostedemail.com (Postfix) with ESMTP id 0517FC0011 for ; Tue, 1 Aug 2023 02:45:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690857932; a=rsa-sha256; cv=none; b=ThFwpBHauLQwbN3N8pOaCk/vtRTAUCm4mZp191ljvuCLRTWpzU2uf0OxTysiExUgGL+YhC /doC1jMUkYEDETcvstYBEyToEp53tV0pElDQhcV9/Qg7iYdlzYvwzPJGivwTYQrbjbWfSm SEwtZrqPNDAEFdlKAXlN6uDfOzVi1Mo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690857932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O91IMZeiX2U4BcHMAFCgzZaGbLb6gmc6jHYpfiHzAvA=; b=a5F7LbfE+gXcuObu458xhEmp3P7KTYbYBtYK+3Oy0NH0mZZIw0kjJrWb0muPnR+4KiORT8 cyOs3uiDtHgzlGxv/JjGlgJbZ9a83b+kOpL9RIHVovpSuBBPSpJEb2kIm3KXmUtapfNnyn yQp51kN/+CjD9Clw8UN0pHNn0jbeNzE= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VojMvcl_1690857906; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VojMvcl_1690857906) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 10:45:07 +0800 Message-ID: <726ad4b3-3f80-f32c-7a3b-7299f82b0381@linux.alibaba.com> Date: Tue, 1 Aug 2023 10:45:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-6-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230728171037.2219226-6-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0517FC0011 X-Stat-Signature: icgrft3z6xtkedjzgx1okbcu7fen35ac X-HE-Tag: 1690857923-270394 X-HE-Meta: U2FsdGVkX196G6ErkxOwOo7TDX/IIAugW7aGLqRZoFl/VEUIcDNHpv9TChB7LU+nftHwbknFrLL0jNqSnoJHCtyLVaqbX7EuCX3t/aNGn0rEnhIT7jkuSYExNhPZNfx+egaEFD4p7kSocrJjmfObKhU/Y9raD7aR4K5aZiHoKctzmR1J61XQJg8FXdTtRiF5lzZMi1yp2Cokx7SlNyZ1BZH5k9fNLRHtSMy1BVLZwazW0TfifGwEV6U4GEC65c5yXIgPkrRIjM1Lmd8Tv1eqvHQgg6+XMZc+6a6rsCpsXc/YT+XpHQgbG+6NjKizKl7NSbrzve71GzWtwe3UP81Iu47UyKXbZjLetV6IaEApj1JOSeBx5lPQ1iDfqnwTNLjHB3c7Jzt/2wILls8F7rDz58+aqsyBvNAZKQhXv2hZPVtqnHmr+duEOcdquHehsZFd8sbBU/CdU8lB1gEuDdG56LhQ9ygMm544nY6pQ8lZrLhbbMJaKg5O7hfu/U1Yht565f8IaW+yV9xIOKO0OwGpuv/721imOXAehMwtkDGsgxgsplYO2R8aokP1hQqdQtddGTbsHgdMAKEbqQl2wODXxFa3A+LueG5f1CAxH4ddgegSXAZJYZI0eZuxA1o/veCnZFboze2zphPCHz1yKpcSrZ0msssiGmIF+Mcb/2BT0RZzRe/28a6WpW8aCVAuWlXwN4vsdZVchQAOUPgI/MWNxhGlzhMupR52noxWlTEwBd91OAfS3f79hhKsG4vhVmN1fRQYVqmowOq+q4zLgDA1kDd4QUsyJOz4pwgolUkw1qEG7UuCNfYYVI/Vm/x7vVC6X25upJTfHYfoVXy6fQ0S3m6xynx9VPyHnjn0jIObbQmSnqrrk4aLTfflTO/+VOz40v9XPMEUqINUrFK3mDDJtJ+7sgGCJT37+wedwjH9TVXUtPKk2F0Nk3YF/fVaPwTGJusaSWXItBK6ISN04uH EI3E8i5C QymL4aFa9Tf067b8s21Guuh9q0B7fvWa1cQgscqdV42TUegyjhFRWM/VNE0rrvWDb+T5LikI+Wt7FBUZLnjRHdeKbEJIlVbMLLUuW8DD8ZI2CB9uoKobsHr2Uo516tD5+gzcY/JwakYlhRD1L0+ppitdxSrH6PrG6GEre X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/29/2023 1:10 AM, Kemeng Shi wrote: > Commit e380bebe47715 ("mm, compaction: keep migration source private to > a single compaction instance") moved update of async and sync > compact_cached_migrate_pfn from update_pageblock_skip to > update_cached_migrate but left the comment behind. > Move the relevant comment to correct this. > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 09c36251c613..1eebb61a1f63 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -464,6 +464,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) > > pfn = pageblock_end_pfn(pfn); > > + /* Update where async and sync compaction should restart */ > if (pfn > zone->compact_cached_migrate_pfn[0]) > zone->compact_cached_migrate_pfn[0] = pfn; > if (cc->mode != MIGRATE_ASYNC && > @@ -485,7 +486,6 @@ static void update_pageblock_skip(struct compact_control *cc, > > set_pageblock_skip(page); > > - /* Update where async and sync compaction should restart */ > if (pfn < zone->compact_cached_free_pfn) > zone->compact_cached_free_pfn = pfn; > }