From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433ACD5E38E for ; Sun, 10 Nov 2024 02:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 268446B0082; Sat, 9 Nov 2024 21:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 219566B0083; Sat, 9 Nov 2024 21:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DFD46B0085; Sat, 9 Nov 2024 21:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE1F86B0082 for ; Sat, 9 Nov 2024 21:19:33 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 40EC2120CA4 for ; Sun, 10 Nov 2024 02:19:33 +0000 (UTC) X-FDA: 82768578270.04.399153C Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf02.hostedemail.com (Postfix) with ESMTP id 4983780006 for ; Sun, 10 Nov 2024 02:18:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0pukjJHU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of rientjes@google.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731205110; a=rsa-sha256; cv=none; b=uH5mMdaO5541gY3soJJ1edFyJNDMJQhALDZPXpiUSv5QxHvpM2Eyi4qqkuP2l2ZiCepxWz llO1kGRT7pZxdLW3Ch0TcZVkqL7laBIrzxuzoChrlNaLtTMyoCRYjESH6mcAAvy1oXiFVn A3cUFcNNnHURxHbLgr9Y1pcjWZn61Fw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0pukjJHU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of rientjes@google.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731205110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wtYxf79bGu9AQ23SIiIULXTG3CqHwpSP3g6NHEutdz0=; b=m3HyNoGfE5uzsBh466s8Wb4RazpAnKO9twTg4GF3rL8FOWnjW4cGwD7bbFvrOK3X0nuizq vP5345nDN16i6GVPvwxUQye247lYptcvYAqLFs7X0+VH/kLl/grOcCggbgnS5m02/N4Byo XN8+hpLjhzFBYST72Xv7vLq/8+3wQNw= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-3a4e54d3cefso176565ab.0 for ; Sat, 09 Nov 2024 18:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731205170; x=1731809970; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=wtYxf79bGu9AQ23SIiIULXTG3CqHwpSP3g6NHEutdz0=; b=0pukjJHUGWyFKkON7J/fcB+yM0dn0sSir8igKguBukjxEjkcwYSFfa0ERihS2RJNwQ v/0G4FfdH/BfQeFv1MUPab+85zwfAPGv1y8tO3TTQIk8NXo5ndD3znorFYG+61PrExVM +f1zqT3ZoejGfcJLXFfAbjpghzAFi5vtE/erVo/oyCxv7OZuO6+F0C88UIeceJ3YP7ju +tyhgVa75XgydH1sDx2uG20WU3VefNMnwIzjrVQQMlKxBg/xZJk0zPLU+EBy7aSz/qg8 dHXDeL76igZk8Rp2EKoJRc/AzWjs33sHXFj5gtGUwO7ldWsyHG5PGeqAxFTZBPv1cHAx 0OAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731205170; x=1731809970; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wtYxf79bGu9AQ23SIiIULXTG3CqHwpSP3g6NHEutdz0=; b=FdU8lIKG0ekQF0bE8UDdPrcGpBZmj/swIFXlivShImPI7OSHq+dLrA5otZVg25Jc3/ YlF18bs6OlAzNhB+SOtTwYmSEUBly1PEj+g79LPQ5e8MIIhLvyRnbuL189az53xFccJn OJDJkZ0KutLHCF88ncmequDV0sz2BBqkkqm/bnjjZl3bmL9TBMN0V7T0Xp2+1grl+/ws 8Nlf1FDQzJek/bUJew/E/vtxFHKeE8EHe8KG7QFcB4wSH62RJ8hZufOkuV1MgECvWXqn r2cM8B+exlXagA0eU8FTAwD568yOxJpDyfTMY/A7Lq0FRr3fgRuzK/53ebq8Bb4X2Mc0 8xdA== X-Forwarded-Encrypted: i=1; AJvYcCUgv9B6V6iyc+VlLCHKrHGwQDhQuFXo4Mhfa7o9TdT+Fi+DOjBXwAPFGz4nHvPEwGQWJLBfaUrzxg==@kvack.org X-Gm-Message-State: AOJu0YwHnXIuEJWqWczwvXLXouiD3ynac+053IcAIyEiu6zHF+GJRhEQ wGqZLRlfBIQdQM2C6IfOiiZOTXr2ch6oe1oXasfZv6o2BV1LV2A/SguzRkDAkQ== X-Gm-Gg: ASbGncvfvvWaS7U4pvhgjSXiKg1gKWiPhWCnkaWu+ux4bfp3gCRB7GetXfmfxBmM198 Rum9luNIwSrPppsJH66za4fKAyds1MDR7hIEzycmv181X2ld/NxCCIl6yDiuCF6/DiA7YT/s6Hi DTIMGr3buLpjzyim40c9yD6d3nnGz2u7dexH26mnw9V5iumPFthW205ZnLOC6YO8oQeSrCRYtrq 9xr4A7BCffN4fbIXvO65Hmt4bybZY1FLgewmHqa+ycWqqlblCZaWRrC97cCRkZI+mwIozzcRVu8 o77y X-Google-Smtp-Source: AGHT+IGOlRHUbzZ277/dq/Etm+M1ZnIxeb6x0lBP5+1k9gAuZMD69+G3KnUOpKIiYz3VJ0FVMcaicg== X-Received: by 2002:a05:6e02:1946:b0:3a0:a224:eb2c with SMTP id e9e14a558f8ab-3a6f9564132mr2137955ab.25.1731205170261; Sat, 09 Nov 2024 18:19:30 -0800 (PST) Received: from [2620:0:1008:15:c964:b0b2:aab1:6944] ([2620:0:1008:15:c964:b0b2:aab1:6944]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f41f5f048esm5013642a12.50.2024.11.09.18.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2024 18:19:29 -0800 (PST) Date: Sat, 9 Nov 2024 18:19:28 -0800 (PST) From: David Rientjes To: Joshua Hahn cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, chris@chrisdown.name, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg In-Reply-To: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> Message-ID: <72688d81-24db-70ba-e260-bd5c74066d27@google.com> References: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Queue-Id: 4983780006 X-Rspamd-Server: rspam01 X-Stat-Signature: ohg8z7jzsa6swj817gfhriz59f756odm X-HE-Tag: 1731205098-14839 X-HE-Meta: U2FsdGVkX1+pdOFif8DCkYLsIM+yZNVCygxNCCSvJnQjUISnFqbpwxsMqKGnPWImulzMHh+4OknUhx0Gtgp6uRO7IWu+OAA6a7LA9JsHzmiOnv45r6w9cidCOunfwcoPhB/N9ZaLSPt5E34Sw9DDsjvnVWuZQAlzKW7ah8TRUk4nnjkHk1SgyvdmS7QBhbh+lUaSPI8wKhWSG+E04UDgTYps/4tkt1shkM3BU3fmUgIFADB32+kvUtWtNfZvKeM8vt+75xWQNOK4dcSqeKqtLW+As3GXRfNMv6vTV7OuKMQTvxkzwZhS+0a5Qkb1epMaqnwstXX5opnnVsUDKKjyfvsCsG3JbJnfyoFrlFfZvciNoO/SwZ3lu90SOP5ObOm8KyEIEIegbDy1N5U3hOFXYfRfT7L6QFty2gY1L2C8mrJ2qLwqzm6+F+MWHdBWb+I2jQ14B/epAi4f4cqetfYn+iysYfgDL9EyDA8iJyxeLbMaKTB9FaEoXU8d7zB//LNjiDU0Zwklyui+YXLp0XvDMM33yZXTziEbqLcss0nVBM1WPHdVY9brjoiaPcLrMOZA55CjZH2dO0fJBfsnpNGbKw/qJFKY48DKOIXFzzNigBTENIz+08vCIkQDl9/Aoqb8uXHFD2zMxdfjLrG5opRDldqrQhLKr4FOz7y3fNnUdKkhycn9uRpxMF5+CJsKJZc+97PMctJGqngqfYg0b4HtS3BFhUQVCcJn4dM/Qe9aMwvtcrHl2BbT6oOnhAC5FWE3oe3lX66RBAQsHnUrYyLR2vR6ZP8O9KBDVOyCkPYxv+85OrczALDrDvPoECkL3XOzQtXDSmN0qmt8USUyBSV4q3tzQPqWKGy2MzslBuwBNb+cT7bkn9earPuGY1LhO7Np8y1Qlmk3ANPdGh3LzOYBzvl+KJJKgTI1Qw2vkkE9AWdV31+/dMSPXWpJfaxXe0IpkCJInfrAvaBu0aHQRMn r8dfUMdw Om6aHZCeaGact5B6HNKdin0KLYtJQvOBom3RhsYBuNoBgwIigG5SuTKLrdLrVB7Qxvfbeh4z+PBOItZ5EZnsryH4DNlCdr6YeddOQz51veZkENznTQQTaO3pdiLRe45SE0NVfk8YUzX6YeaxSK7+ScdCxHkaPNCqnX48mf5LAy87tJflGyud7zKujISWCjwS/3RWrSFbWRWAItIldtOeoBhdA/EycwqyWIdKp3/eWvVm/28otNpfnKphSdyBokZEF5btKMHGflWhK0WgAq7YeRUcQZeZI8RMRfCic3u82vsc67LZk80lRf5aSrmo0qrXYuyLiySTBSnoFYuTysyXBzgruFxLk33wjRH1Xkp3Tgw17PaEwcNZPx81BWRkJpfEguqhyf5uLSqsoz9G1RQT62l0zl16mAm4/Bqs71johXaG3+ocx1dapjLY0WSlWMH+M908Js1xy36/02f3rC4h5gyBxXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 1 Nov 2024, Joshua Hahn wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 69af2173555f..bd7e81c2aa2b 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1646,6 +1646,11 @@ The following nested keys are defined. > pgdemote_khugepaged > Number of pages demoted by khugepaged. > > + hugetlb > + Amount of memory used by hugetlb pages. This metric only shows > + up if hugetlb usage is accounted for in memory.current (i.e. > + cgroup is mounted with the memory_hugetlb_accounting option). > + > memory.numa_stat > A read-only nested-keyed file which exists on non-root cgroups. > Definitely makes sense to include this. Any reason to not account different hugetlb page sizes separately in this stat, however? IOW, should there be separate hugetlb_2048kB and hugetlb_1048576kB stats on x86?