From: David Rientjes <rientjes@google.com>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com,
shakeel.butt@linux.dev, roman.gushchin@linux.dev,
muchun.song@linux.dev, chris@chrisdown.name, tj@kernel.org,
lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net,
lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg
Date: Sat, 9 Nov 2024 18:19:28 -0800 (PST) [thread overview]
Message-ID: <72688d81-24db-70ba-e260-bd5c74066d27@google.com> (raw)
In-Reply-To: <20241101204402.1885383-1-joshua.hahnjy@gmail.com>
On Fri, 1 Nov 2024, Joshua Hahn wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 69af2173555f..bd7e81c2aa2b 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1646,6 +1646,11 @@ The following nested keys are defined.
> pgdemote_khugepaged
> Number of pages demoted by khugepaged.
>
> + hugetlb
> + Amount of memory used by hugetlb pages. This metric only shows
> + up if hugetlb usage is accounted for in memory.current (i.e.
> + cgroup is mounted with the memory_hugetlb_accounting option).
> +
> memory.numa_stat
> A read-only nested-keyed file which exists on non-root cgroups.
>
Definitely makes sense to include this.
Any reason to not account different hugetlb page sizes separately in this
stat, however? IOW, should there be separate hugetlb_2048kB and
hugetlb_1048576kB stats on x86?
next prev parent reply other threads:[~2024-11-10 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 20:44 Joshua Hahn
2024-11-10 2:19 ` David Rientjes [this message]
2024-11-11 15:58 ` Joshua Hahn
2024-11-11 17:41 ` David Rientjes
2024-11-13 22:42 ` David Rientjes
2024-11-14 1:08 ` Nhat Pham
2024-11-14 5:26 ` Johannes Weiner
2024-11-14 10:33 ` Michal Hocko
2024-11-14 16:36 ` Roman Gushchin
2024-11-17 3:34 ` David Rientjes
2024-11-14 16:42 ` Joshua Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72688d81-24db-70ba-e260-bd5c74066d27@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=lnyng@meta.com \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox