From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF4CCD11DD for ; Wed, 27 Mar 2024 02:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD3B06B0092; Tue, 26 Mar 2024 22:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84466B0093; Tue, 26 Mar 2024 22:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9242A6B0095; Tue, 26 Mar 2024 22:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 835176B0092 for ; Tue, 26 Mar 2024 22:11:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6184A140429 for ; Wed, 27 Mar 2024 02:11:24 +0000 (UTC) X-FDA: 81941192088.28.8E10EAB Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf13.hostedemail.com (Postfix) with ESMTP id B43C420019 for ; Wed, 27 Mar 2024 02:11:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=N5zi5xF7; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711505482; a=rsa-sha256; cv=none; b=XuLaM4vYLmRg8A4/atY/3ux4dYNrWJJvNyA3Xx8dPfnOW+RoOUd/jjrU4PSY8FnES6eCZ3 l/6QFp7GXeisJ4U28C1SQPqBs0vzindPsUJkGYMYyXt8BpW0zNTiovVNRchUCHmBOPwpQ7 HQgOO/AH0gYajAQBHSaOlT6lJhd8ss4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=N5zi5xF7; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711505482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VKgEZz3gqT/qrPZJxtA6ePPIz6oGvyMPjM3uA1fFlqE=; b=2br2YVQ6MsosXUDAsUD5KbJU+XuPA9Uk8yPF4CVie0DuCY83MEZhV4Hx5NCWB87zEmkSUG hIgtJEOPprScwAzHNJbW0mNkhrMVgIiaqFD+Deeq99Ik/9vbWgrYTFpGj3+swVP2vhbhUE ZpzAP1otp0T69ItsKCGr+WzJobUf11g= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-29f66c9ffa5so1062081a91.0 for ; Tue, 26 Mar 2024 19:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711505480; x=1712110280; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VKgEZz3gqT/qrPZJxtA6ePPIz6oGvyMPjM3uA1fFlqE=; b=N5zi5xF7r8Ibqx0KSp40jkEl+1Or5a7oe7FPlefu86AGzcord2Ca8jTvJWHwOkEuCF 6HSHkZM5Y6R+WV2zBJ/yapxKxi5E1+UWraR5sff8esTtHuv3Aw2/qfXEbjVeiFrhiQ9H R4jkhm0FjvQsxy6AFYNASDcknmV9+bjiP+qSE6v7ecIbqXNmEmOY3zV6QGFtlqXXhekn 3CpefJs1NLzYN/iLkzQv/ldG59G7RzF+N/SQOKOhM9rzMVwjYC0CKQsN9Ih5EeJekcdX eyIP2B0m7LBBQFGB4GZNBtgtNvQef8jvEhVdnMLqJJfGolE/PLo8rN4GCbulTFMhSK3v l/Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711505480; x=1712110280; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VKgEZz3gqT/qrPZJxtA6ePPIz6oGvyMPjM3uA1fFlqE=; b=iwIUkUv/0pjENSq5d36ERgMT4RL6pfJutEUs6JF9DjbfYSsSM3U+tdIhfZ1MXMyoQQ ResKC3Nbr4mVH1YKwq8TeZBtFEiaBn6qvSOIJpHp1S8YgRPNmSgX1dmL1aVp3hqVL0Pf wyzeycQP2WjNT9P6D37wUyIU7/6Mzfv3rPtMQL5Okt9gox9bw2OdV2oQBUUDJ0v6/8or HgfbFeUt+9I0/tORn/ovIcvXi/ar+o3knssT8XFZQFcLCl/TJJG7QqSQBfGayw9s6/Et Dpooen3bAKFCgLW/Ee5Wq+gD4YXMpFL32q8gFVv3bEp2s/pEblmhIP8xnO95QkwyCmVx tzJw== X-Forwarded-Encrypted: i=1; AJvYcCW88Kf5XecTtg3AGL53qlyFPPIlK6+4e06IvmAAo22L07/+uZu2K4hnk7EhCNjbgdsPWdPHS7gKmORrFz5xaYHApA8= X-Gm-Message-State: AOJu0YwPW1PRTMFwy9nCe7J/81O46/nKhhBlbSsQCg3aZCgPPMKKa+aK fkR+txgYigrZsgGF0h7HpnAf5cF7R6UeUaWKVgoJgDMf+IKmqjyYjWFCmgZnEhQ= X-Google-Smtp-Source: AGHT+IHOxzsYzXYb2U6hVOGVogL6FmVfZp9EHnweMdH3lzP+3KV1JbtDB3TMm+JsCmDJCYsexHcneA== X-Received: by 2002:a17:90a:9f8b:b0:29b:fab2:8a24 with SMTP id o11-20020a17090a9f8b00b0029bfab28a24mr10290068pjp.3.1711505480542; Tue, 26 Mar 2024 19:11:20 -0700 (PDT) Received: from [10.254.105.249] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id q5-20020a17090ac10500b0029becfcb97esm335753pjt.22.2024.03.26.19.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 19:11:20 -0700 (PDT) Message-ID: <7258d29d-0d4b-4463-8685-e3f21d426d2d@bytedance.com> Date: Wed, 27 Mar 2024 10:11:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] s390: supplement for ptdesc conversion Content-Language: en-US To: Vishal Moola Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <04beaf3255056ffe131a5ea595736066c1e84756.1709541697.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B43C420019 X-Stat-Signature: rq9dckekx6o3tetxst7bhsasip3yuoz9 X-Rspam-User: X-HE-Tag: 1711505481-606431 X-HE-Meta: U2FsdGVkX1/rG6wUyLzxUep1ePhBrQjsK/pEED18f+Ads9rOBQRHtbHqJOruc4YhbrgilqEn+/KXxTaNGmkzrnmjFch98tppU7kEZaVpu107eb2j1EhHcC/xGW8bwny9jsqK93+FaLLPiWCSTWSR24CWdIQRa6hwtK7NYGIAo/6psy3sPVYabnlhYcwpoMsY0XPRv3LNgU1L2R8l8ixj+VrRZMuUFFfmuQWrHTG1wcHodInLo1uak7XdKNMccys/abAYgoJEFmwgDo5fDwj0Mz4yaoDDuVHXiFG/Zexoyoyg5/cGcswZhkMQCW0DmCaaPEkxVFH8sOwYb2EStt55BwvUF5f6seInCIDl/UqRdReiZDQBtcmtQt6g7EOlT2XmXCTiBgPxnYdObaCRiji1BrMdsHclLPmSC7taDkc1vbA0dsqiGWd/gRcvOfQIHaCuSHDUIQg8jZf28lN1oMrHQJUO+bMSuMf1xYZf9TcSvcf9xssydZ5rU2MYXoNqyyC8kM3K9d4yMiVGklGVPyGtLT9fIpwFMFOpSbJLPrUxV99xby9PJyzIiqjLreffHJtTCZ/08Ztzj7O+/6yDAnbjD0x+CnqJrJTNAS9dkMpz1cBvr95J82LrKgUlxmnAzMT2d+JnnSziD/JtUwsBzSj7kWe2O7ZmvAY6VQ4mX8biSL3orbE/VpWcbqFStqSSWhiEkMdhB1MTzggny+lrpAhXpbrR/a+4qXlNGdV6P992InAshCBhj6csL2rWP1VmmvnqAvy/rEzvOf3irsjM6Tq43Y+9Drou6Ah9/8xMpc855+OGA5GCDWvqGdJFd4O62I7flf3VN/Fsu+oGxMkTpKNkJM26tMl1gGaFebcS/RqU4WrAB15idYPUPHzxA5QiiZzXsvaq+kY5sHqSRkvatLlIjzIBD5YHg8v8WR7SKLIoFBQr0eQVRKSrcjH16IUhjfZ6O8ZRq2AfyHzDS9OEOh0 O7sEu+25 OezLl8jWgcKpJXBGrHwyNdweCNFf1i6ATL4WNN9V/30T3M8pFLT6cZGrQn15+3gEqieGhf0NsuMMFmKVgUjR9R+0AIsLXH5gfZ7wucO48B33oc7K/uo6UnxmRhcLfBroM0wZWB99ZoTUcXgmlhxNwoN1rhagLvwxp4JauqjfJPfcEQzn66Z29PQdnYA3X9jjvdnpbJ4KjaWq3IZoBVcN1k6kxH1HjK7FY3WzkpNbrE3OTSguCXRBh9qNBTyDmpngybx5z88CMkiw+uLwjNrvTIdHznbcuVntUdX3A3A1iy16Fpo4TjQDNxFZZgG7t5IozM4ylvo+OAyyOIuWgrTDpwdF0uzcYeEn4J9T23FZQMjSUJxy4UcQt0LMFPGCnt7H4HMfU8RP3hJZTGR2sttvkYWyCHLzIfZzx6XrXQfuAu9oI89Q7rEpZaAdrhrwphU5LWieRdZZVpzxuTDJTPgrM6zELWhUWgPqmSwq9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.015465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/27 03:48, Vishal Moola wrote: > On Mon, Mar 04, 2024 at 07:07:20PM +0800, Qi Zheng wrote: >> --- a/arch/s390/mm/gmap.c >> +++ b/arch/s390/mm/gmap.c >> @@ -206,9 +206,11 @@ static void gmap_free(struct gmap *gmap) >> >> /* Free additional data for a shadow gmap */ >> if (gmap_is_shadow(gmap)) { >> + struct ptdesc *ptdesc; >> + >> /* Free all page tables. */ >> - list_for_each_entry_safe(page, next, &gmap->pt_list, lru) >> - page_table_free_pgste(page); >> + list_for_each_entry_safe(ptdesc, next, &gmap->pt_list, pt_list) >> + page_table_free_pgste(ptdesc); > > An important note: ptdesc allocation/freeing is different than the > standard alloc_pages()/free_pages() routines architectures are used to. > Are we sure we don't have memory leaks here? > > We always allocate and free ptdescs as compound pages; for page table > struct pages, most archictectures do not. s390 has CRST_ALLOC_ORDER > pagetables, meaning if we free anything using the ptdesc api, we better > be sure it was allocated using the ptdesc api as well. According to the code inspection, all ptdescs added to the pmap->pt_list are allocated via page_table_alloc_pgste(). > > Like you, I don't have a s390 to test on, so hopefully some s390 expert > can chime in to let us know if we need a fix for this. Yes, hope so!