From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE85C433DB for ; Wed, 27 Jan 2021 10:51:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E05F2076D for ; Wed, 27 Jan 2021 10:51:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E05F2076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5FEFD6B0005; Wed, 27 Jan 2021 05:51:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5883E6B0006; Wed, 27 Jan 2021 05:51:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 450786B0007; Wed, 27 Jan 2021 05:51:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 2BF466B0005 for ; Wed, 27 Jan 2021 05:51:36 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E7991180AD822 for ; Wed, 27 Jan 2021 10:51:35 +0000 (UTC) X-FDA: 77751238950.06.rub93_240789d27596 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C0E6B10044A5E for ; Wed, 27 Jan 2021 10:51:35 +0000 (UTC) X-HE-Tag: rub93_240789d27596 X-Filterd-Recvd-Size: 2240 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 10:51:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2EA62AD87; Wed, 27 Jan 2021 10:51:34 +0000 (UTC) Subject: Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions To: Yu Zhao Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210122220600.906146-1-yuzhao@google.com> <20210122220600.906146-4-yuzhao@google.com> <85b3e8f2-5982-3329-c20d-cf062b8da71e@suse.cz> From: Vlastimil Babka Message-ID: <725432e0-3a6e-e83b-c478-ffda028ff40e@suse.cz> Date: Wed, 27 Jan 2021 11:51:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/26/21 10:34 PM, Yu Zhao wrote: > On Tue, Jan 26, 2021 at 08:13:11PM +0100, Vlastimil Babka wrote: >> On 1/22/21 11:05 PM, Yu Zhao wrote: >> > The "enum lru_list" parameter to add_page_to_lru_list() and >> > add_page_to_lru_list_tail() is redundant in the sense that it can >> > be extracted from the "struct page" parameter by page_lru(). >> >> Okay, however, it means repeated extraction of a value that we already knew. The >> result of compilation is rather sad. This is bloat-o-meter on mm/built-in.a >> (without CONFIG_DEBUG_VM, btw) between patch 2 and 5: > > Thanks for noticing this, Vlastimil. Should I drop the rest of the > series except the first patch? I didn't check how 6-10 look (and if they are still applicable without 3-5), this was just between 2 and 5.