From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47BCC25B78 for ; Tue, 4 Jun 2024 12:42:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 585D16B00C5; Tue, 4 Jun 2024 08:42:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CAC56B00C6; Tue, 4 Jun 2024 08:42:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 392126B00C7; Tue, 4 Jun 2024 08:42:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1AFC26B00C5 for ; Tue, 4 Jun 2024 08:42:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B21AA406EE for ; Tue, 4 Jun 2024 12:42:30 +0000 (UTC) X-FDA: 82193169660.28.776C022 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 988F41C0023 for ; Tue, 4 Jun 2024 12:42:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LncN57U8; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717504948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E/n7qDUO8vNDyhk1OfOnQdEu1R0VNUdXXI3i796MnfM=; b=geYt1e7KQhEzvkE+vZF1rU5R7Wllw7bDQb+UQ6gGucSacGLq119ARFA0XjIC9FHjp+JT/J lyolFW1GsGVmVCohm+3D2Q0kdSuXNXPtLmuVY9WoLGK7vp2heC1wTsRu84msd8L13jPtdK IjKqntor5Am4EujJUV4belp4UHM6U4w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LncN57U8; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717504948; a=rsa-sha256; cv=none; b=K6FhfvgA7UV/0HD/V6FMa+sCWUttRrNCbqL62bGrPHdGYUm5sSho/ClJoAeGivKyYubAqc u7MS0cEUvKmwzAk/KAeem6tTkzi7Q7zsSy9lRka9EGjrPMn81PqP4/D+IRsvLpHb02Zu1z Myn5wnaiNLLaU6+voE6KS2TZ7CXLzpY= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a691bbb7031so249538566b.1 for ; Tue, 04 Jun 2024 05:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717504947; x=1718109747; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E/n7qDUO8vNDyhk1OfOnQdEu1R0VNUdXXI3i796MnfM=; b=LncN57U8Wt33M3Xh2CUj9JzZkFnViN4dyNqNRIQDn+ivKUDkpVcIiCGGPk/vFuQIl/ xjnzJsTzyWYE1IDFDtKzhHqQyxlvE9uzmhFks+qjap36VMwe/cAYHTn9za00emx5IAPz aaVob6T5mO26Xv8PI4uBoVjvtdglDncyPkjzNJ2qwA5nnzyf1vECvjkrflgWTgNG/rGx t6H6casVJLAobPXMkvsrOwUTifGFXzncgPkcvUivM1Y8PCChSCUSydl0eR53D8o/9qzZ 5pPNRmz3CqhJIc9zqh4hLgoMB6ZvSXSPdxv9n5CEeZysYnMCRdCPqJlMFZSLn3lFPFrh CtgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717504947; x=1718109747; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E/n7qDUO8vNDyhk1OfOnQdEu1R0VNUdXXI3i796MnfM=; b=qJYxEDz4Puq6lhw4cnO4NWhFHE3VmjnU78AlpLphd0Xi3qLqF5TwMK2LZ5SLLuYXdy u04lwiVzkm1IjSkx6vq+poIEWlmPzMdlf5AisJHn+Gp/0ca4OTSqrvVkAaIjPq6+uswH 6awOi7m0amgLWdxOIqBVklIO0I+8W+evlNwj4/l3gGjJjyiuSKTUqKMXQY01DQTOJ2QD Nsw0B7l/+2EpqQqk0hIg/t7G2e8qSYK6pXa9GFbEDO7r1hTd4G9b4Iff1tsbowzOd4zr cXoYspRGYlyREH2+W6Cq+ie1pvHatNS7Joug59l1HIIGNN8zoxqy+fWayB61vy1gICvI YT8g== X-Forwarded-Encrypted: i=1; AJvYcCXkJudgvEj51wdl5bZVUb98nhc56NM4YbTCdLKjN7Tj0+sZRCZr5gK13kUR0OVI3cqgkMCM5TXZOwxOtIHyiba0dyI= X-Gm-Message-State: AOJu0YwBiOK6+hmdLplCAW4cPJiKH+vtJMgxGHr1UzQIN7DxiNn9NZsH mqVFi6TkfbW0sqrjpd+pnAqNDxfH0tuAwRjU3T3YdYqXtBIJtTKX X-Google-Smtp-Source: AGHT+IG1f3N8E8h8dd5RXfWarq1rkORxg30YgDuAutOa3Hlj7zfGb3DMFpeDTx0wjEmdM/jgwBqo+g== X-Received: by 2002:a17:906:ecb6:b0:a68:2d37:fb5a with SMTP id a640c23a62f3a-a682d37fd6amr799648866b.4.1717504946805; Tue, 04 Jun 2024 05:42:26 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::5:89fc]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68f2d64203sm367906666b.212.2024.06.04.05.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 05:42:26 -0700 (PDT) Message-ID: <7253d276-1bbc-47a8-a5c3-c7c8ec43bab0@gmail.com> Date: Tue, 4 Jun 2024 13:42:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: clear pte for folios that are zero filled To: Matthew Wilcox Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240604105950.1134192-1-usamaarif642@gmail.com> <20240604105950.1134192-2-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 988F41C0023 X-Stat-Signature: xnhmuxms5e7cjpnob6uiy1apd7yxctxt X-HE-Tag: 1717504948-614978 X-HE-Meta: U2FsdGVkX1+sB4xTY7XhgidGvhfFXUz5uPK6ggBT/nBHZooC3Dbi/qxGtkOi0OdZgi8ExRjECbW/3OE/gcaXW8SGV9ZCMztnRf5TZra0InfEpHDbB1Y0NE1YEtLa143nQPoVAk9MgyDoZCd1+uhVTEiJ16AI4f2KAIa5I5nhmM0r0VwpoCWLHYm6zjBVQfVumBAhr6nXC0g5hD9BrecgJEXsrJ/crbDbYqJHs8GzNQStLwo1hCtZO3D2DxDtkGnevjkjqEkucRCPE8G1brWOgEsu+7ej72l4wPAVCJ1/+YPRbxMc2kfwwVQtEw/qNnnARRsLX2zrXd8PtvYO9ARHwZgo1DZ82J5Ga5cqrENG1EZyZk4yqtiD7e+BiSF14IH1joi782kOcOKAMSXH6dTEMYuvdNuvuJsNQ8D7iaNQDunuiColXuf67djw31nO2MrX4HCjxQZkz2UY0nxVHhS20qD6xvyVSF19x+NQJBdum8xcPwBodMS97FlYM34U64ymqbBr0ao82UEIwi5C7hsqHdiBXXeVuN6ktHLCl4x9TO8Rhw3pMukEV3F4O+JEL75Zo8yLSJQHafUkJX+w+d/L1YaErWFIAPMcEO/k/NkmGIFOZw6EPOm/vYpxFl0CIkaP9yrK1f6F7fu2BMG7OIffliCqBTnsQUrTDV3o73fqwNgal9vAYzP2WSwV+nZagNga+WL7H9R9upapBUdHLR/h6DsNqpefqPhjVFZyfTGJQkz/CS/jDoMJyXHrk/6u9/fQo32zm+ixlp0mXPy3o5vpiQtRWmr/8tUud5MDgsQlmBsn2gtyBbZLh7vCeIe6IENbyVH0Vf62UqRgtprsENpCrBwj9ch78f9MLxaaEQ6Nr+upDZcxVaigAovVz4xTAspYsoleTtTVhcQbTHTCvC3tOMwTh/C5KCvFuAn4Ris815b4vog8EUYjVPOBERqtkN+PUw3e3WVQXcsaSIR01QW Z4WVnZhJ uaxOAboW7zTyAL2vu4JRTb0moSlMgysKHKNgxtpsK2AkGcuEQHvAymfX+0kCEfXDAMoW75TdY5h31HbdFtj4L68rMzA41xbEoxfqMd88464IW4OXnY2EaiCg63ok1iZErAODjEalfkdJzkfYgG7ekLVOw2S2xhLzkPXFeSJb+KDmONBQUkoW8BZnZKYn8+5Zz21pR/ZUIk4Vf44RphAfXttwJMirnnXGfOtn734wwmxPnDfZwe/QquFeE0DWm3i55+nrmOdx9l4ptuvTUDUk8v6f5wURkAtY98GWL/sB+YoNM30bxUurn7bwy+N6KK+HRKfHLrPJ0gNLzmg5sxc+LtLdi8J1Gs8Ol1cPjv5nDqu+PWWFDN3Gcvn2k243Ldzwc0vYcQDEU0nIFIFUo5bmulws8A6j0SCoy1Xidt4e3vhjU2mb/ZL1Px+clyBirPHzcznd9LSTrWV/hDdXOzLYepIVLtjuIVo1o668WQtup4tR8vlvKyG9Su89qLSYgU+j3gbuz X-Bogosity: Ham, tests=bogofilter, spamicity=0.015989, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/06/2024 13:18, Matthew Wilcox wrote: > On Tue, Jun 04, 2024 at 11:58:24AM +0100, Usama Arif wrote: >> +++ b/mm/rmap.c >> @@ -1819,96 +1819,101 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, >> */ >> dec_mm_counter(mm, mm_counter(folio)); >> } else if (folio_test_anon(folio)) { >> - swp_entry_t entry = page_swap_entry(subpage); >> - pte_t swp_pte; >> - /* >> - * Store the swap location in the pte. >> - * See handle_pte_fault() ... >> - */ >> - if (unlikely(folio_test_swapbacked(folio) != >> - folio_test_swapcache(folio))) { >> + if (flags & TTU_ZERO_FOLIO) { >> + pte_clear(mm, address, pvmw.pte); >> + dec_mm_counter(mm, MM_ANONPAGES); >> + } else { > This is very hard to review. Is what you've done the same as: > > if (flags & TTU_ZERO_FOLIO) { > pte_clear(mm, address, pvmw.pte); > dec_mm_counter(mm, MM_ANONPAGES); > goto discard; > } > > ? I genuinely can't tell. > Yes, thats what I am doing, will switch to above in next revision, Thanks!