From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286A7C021AD for ; Tue, 18 Feb 2025 18:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD3E5280174; Tue, 18 Feb 2025 13:02:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5C61280170; Tue, 18 Feb 2025 13:02:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD4F280174; Tue, 18 Feb 2025 13:02:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 716B8280170 for ; Tue, 18 Feb 2025 13:02:23 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24F691203B1 for ; Tue, 18 Feb 2025 18:02:23 +0000 (UTC) X-FDA: 83133834966.02.DCADB5A Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf08.hostedemail.com (Postfix) with ESMTP id 2E8BC160029 for ; Tue, 18 Feb 2025 18:02:21 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739901741; a=rsa-sha256; cv=none; b=NLnADVYv3kz5hTFrVFcH/JSo4bZ0LoEQ2M3JaLmBlXZE0NYl4S+wc3B9Cc/Dv+3psyumaL R4zjr6mbSW28KXTurJUtZ/7NCRTHL/ES9iMpzdcLsdMsRl5JGvw9DEZEyVIHofNoYeVKP1 fNV/vxYBEq/l+TJ856jdnF97TuLwve4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739901741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KOVvCh4pLecDfyQgzxX3559XIpIwaJlJhLw8/AdGG9E=; b=HLF4JShjHixd5mKkv5gdifl4lu7w5i+Z7f/hVVbAGAGkLf7uCerOrZBcVW+lYS8F89Ucww TaBd8M/7/mTVOjTjcSdIsHT02KIWd/QCHvjonLN5H0/4W+Yi4mfnDzk4rN9JNAZWtUCMvb FMr+un9at28pb8oxMjG01fuWfSg0hO8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tkRte-000000003Qj-2e40; Tue, 18 Feb 2025 13:00:38 -0500 Message-ID: <724d17ce3fbe07d1d9404f8f32ba518071bcfa4a.camel@surriel.com> Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Yosry Ahmed Cc: Dave Hansen , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Tue, 18 Feb 2025 13:00:38 -0500 In-Reply-To: References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 2E8BC160029 X-Rspamd-Server: rspam12 X-Stat-Signature: 5eqrs66cdpiqoj1kp8jumsfnwhrywmp9 X-HE-Tag: 1739901741-884459 X-HE-Meta: U2FsdGVkX19YlUmZxe60sga9lVGoW2D0Ync9qulq+ftDzdjJ4ty/yLOTTG8Fx5e0Zt4nUne6oDOuQsegFjvIw9YxvZON5hGBea4nczhuTx+cnJsMmIiZ1zWM+7bK2jZmz1JYfSTd+jd/1uHLFkonTRaSVhlyWVeo+7FRIvOUkHIYKTyMQQbg7PyfPdUwuZxbveYp6S438sWlfmPZtt0U/6LPK9Yx+FMwn2g50TUJAnxdrmLjVmJY5bEHvHv7191M6mfhiyiGjGS6G73jQ8/fbfKeuugUOxSXjonN2XUCb3GEtmMUD8HzH3JcvK1lUw2whjCGYHO2PF1IMfhQVaUDDPGeARyZBd0s7k04FslMbmBN8myMRoeKLlE/Mx57woi2ntzRSa9mOPff4ruIeDA1AyEhQ0L6Vn2rxzsla6sbGxk3csEzENQChwdRjiSE5nTpq4iFN98sJoHzNsiSyPvsBP4wvpW5NeGfPSAUZ5fL8nx3KnaYSi0e5qvztI3MYuUMD6b2lV9RGNfojsUCJydt+r5izPbDj0mQ4BlHMbU6ixiFdrmDKqm8NkI02jmQtfuziepJdF7ilUFhCXCG65sO8/KBcaYp4d38e2GhhIR7NCG0aioAJCnRPcab7SFV1hFk62yGnIedu3kMdNGXATBmcjHNIdz+GExnVshJxg3BOwLSGhQXGuJpa/jdnR65y5ubyEyj3Su34UiSw+HB6sbYMcrzmO6B9LKVNC+I3/HRGmrV7GCmIAuHblVn/0NCWQ1at0UiSqnV8cccLk2VVsImmTB7zO4/3L0qb07C4jh4XKCUBKT8bucQtn+F+SbK2Jh/2ahXB4tUzrmGmqX0UI9Zrttvo+pdTHcY4Xsb0ZCnNftcVTOT/J2H8QMto8YketD/XLpXn3e32MwJGdUBDw17+dYtL3ge70FvB/ls5dn/dNVUZuUv+J0QUmwACvgs7GPoZgwqJW3usvesUPEDwFI PdRIjk7O RmZDP8dhf/Vncu48SWn3tSD3FZxoGM+5vZGmYCkKk91ejQfuPmm+19c13gi5qPa0inB269Osq80cLys9FUq/UGpezWCVXB1p75r+DBVPB0XZvuN/ZldfLjPh69oiLLS3DJF4VUeAY3MLZS1Xm5v45p0k5l8BzidjDobszPkXp5DHpkc4HHbtBqmq9E1budSgRUQZiGf2DlIKvG7h4yvB8CI9Wl/rxemfRLJbqAtV4u+E0NIvqVlwmakRQlBJFseF3wt4RgoxqqP320ha6CWYqDzaSZJQAD6RhvvKT3DSY+n5d9FWT7oymjjFhGlVyCyH5+88K3+C0Cj5888grGL4S0yxsMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 2025-02-15 at 02:08 +0000, Yosry Ahmed wrote: >=20 > So I think what Dave wants (and I agree) is: > if (!broadcast_kernel_range_flush(info)) > ipi_kernel_range_flush(info) >=20 > Where ipi_kernel_range_flush() contains old_thing1() and oldthing2(). I like this idea. I changed the code to add that for the next version! Thank you. --=20 All Rights Reversed.