From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D9FCA9EB6 for ; Wed, 23 Oct 2019 18:07:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C47082086D for ; Wed, 23 Oct 2019 18:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cdTsj9JB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C47082086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 727856B0007; Wed, 23 Oct 2019 14:07:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D82F6B0008; Wed, 23 Oct 2019 14:07:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EE8B6B000A; Wed, 23 Oct 2019 14:07:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 3E2A86B0007 for ; Wed, 23 Oct 2019 14:07:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id DB31C441E for ; Wed, 23 Oct 2019 18:07:35 +0000 (UTC) X-FDA: 76075832070.05.lace85_80eba62b0004 X-HE-Tag: lace85_80eba62b0004 X-Filterd-Recvd-Size: 3581 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Oct 2019 18:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571854054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dJ7zg/nfTRnTIg9LMwikxyAPQbbTem0V3IKC5Taois=; b=cdTsj9JBd2bHULyMKY6xE7bOfLNG8B9m5qTkTI7Bog3oPItk1zn7wpKv8kNN7WsQw3mmC9 DHC59gEaSotm4KqqkgzxOICOP02AJZTq4wWiZOFR/MckYdat9qDdaV0Y1fS+Jf8INT5aKq 6X8NfGBNcJPB7geA6czG3CtgL6lTwcY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-iF2ObA_CNoecP4FMtzToVA-1; Wed, 23 Oct 2019 14:07:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A8E91005500; Wed, 23 Oct 2019 18:07:13 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-59.bos.redhat.com [10.18.17.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18DD85C222; Wed, 23 Oct 2019 18:07:08 +0000 (UTC) Subject: Re: [PATCH 2/2] mm, vmstat: List total free blocks for each order in /proc/pagetypeinfo To: Michal Hocko Cc: Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Johannes Weiner , Roman Gushchin , Vlastimil Babka , Konstantin Khlebnikov , Jann Horn , Song Liu , Greg Kroah-Hartman , Rafael Aquini References: <20191023102737.32274-3-mhocko@kernel.org> <20191023173423.12532-2-longman@redhat.com> <20191023180217.GO17610@dhcp22.suse.cz> From: Waiman Long Organization: Red Hat Message-ID: <724cbfa3-2a04-718b-5c98-942a452566f4@redhat.com> Date: Wed, 23 Oct 2019 14:07:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191023180217.GO17610@dhcp22.suse.cz> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: iF2ObA_CNoecP4FMtzToVA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/23/19 2:02 PM, Michal Hocko wrote: > On Wed 23-10-19 13:34:23, Waiman Long wrote: > [...] >> @@ -1419,6 +1419,17 @@ static void pagetypeinfo_showfree_print(struct se= q_file *m, >> =09=09} >> =09=09seq_putc(m, '\n'); >> =09} >> + >> +=09/* >> +=09 * List total free blocks per order >> +=09 */ >> +=09seq_printf(m, "Node %4d, zone %8s, total ", >> +=09=09 pgdat->node_id, zone->name); >> +=09for (order =3D 0; order < MAX_ORDER; ++order) { >> +=09=09area =3D &(zone->free_area[order]); >> +=09=09seq_printf(m, "%6lu ", area->nr_free); >> +=09} >> +=09seq_putc(m, '\n'); > This is essentially duplicating /proc/buddyinfo. Do we really need that? Yes, you are right. As the information is available elsewhere. I am fine with dropping this. Cheers, Longman