From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D43C48260 for ; Thu, 8 Feb 2024 22:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 771966B009E; Thu, 8 Feb 2024 17:09:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 721C46B009F; Thu, 8 Feb 2024 17:09:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 638356B00A0; Thu, 8 Feb 2024 17:09:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 553E76B009E for ; Thu, 8 Feb 2024 17:09:05 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 19DC2140CEA for ; Thu, 8 Feb 2024 22:09:05 +0000 (UTC) X-FDA: 81770027850.15.8E0AC6F Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf05.hostedemail.com (Postfix) with ESMTP id 90E4A100004 for ; Thu, 8 Feb 2024 22:09:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=HHhUTNHw; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf05.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707430143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6PrCD58EUrdXCM4jPYA4pXyZvQ7Crv+B7Ue5tXxGPgM=; b=AXFZgXt1L61MJkCApYHosCdt4SzCTFvJY7ZYTzOV5rxbZNRm/JaIilVC7Can3rW2Z3w0j6 iLJ5//a5RNh6EUoLTYCpv1BROytmwmP5/Klqhhs5KJVp8qzhHfILB0OBLp1Ddq27w5/Ws7 Po381rbRFbRbnEbmUPAGfDeZTJQzWzA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=HHhUTNHw; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf05.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707430143; a=rsa-sha256; cv=none; b=mcNr8CVEFh3TdVSd1JaEA22HeWNIlcWwNVq0MJYBPwoS7dLvnrjPOIyRSG1mhuMNXaUzwE XVCqYw72OVeYaWQ5Q0q9wwCRZe2ExO1lJmlaRA0HKJcQ7g60tnogBDkwRi/rVAkbs85t0o FQEkIFXRZfdBzRHuqGYN1abTvCzHqCU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707430142; bh=kv1G4rauL0V/ovkZqlyZV/zCcYxt4nw+B1HaObpBsBg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HHhUTNHwp9t4GjQ6d/I8PbBxZ5Ysc2qEEV48aH3lVN1VoGAv71YymOYZyjOFWPGMd 4SWLdtwlCkB5t2w+1ELwTPFHxTxxuha5Qxjd5h8qyTccFlmpSB/a7d1RmAW7d+vZE2 q/a5IoQJ3CEfwEgxipUsLOBDKGi1bpWHfP47Vw94wLHOsjm2DoP3neVCVsFgrAwah4 vvA8ewXKzgrCnLgx4wejOxSONJJHYgBAy6pqeYLy32KpZTKnoJjwCfdEknNRXwE2+3 5eXO3k9W9vD4setJ/qKQQVlQ/I+pavp1S/Pu537Q1V3SZrJwiKFTHXnFYFBq8AR41q zWLNcSgcR+RYg== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TWB322PvSzY2X; Thu, 8 Feb 2024 17:09:02 -0500 (EST) Message-ID: <72457cf2-c8c3-4c3e-b5d7-c39f55669812@efficios.com> Date: Thu, 8 Feb 2024 17:09:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Content-Language: en-US To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-6-mathieu.desnoyers@efficios.com> <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch> From: Mathieu Desnoyers In-Reply-To: <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 90E4A100004 X-Stat-Signature: tzdzft88msj61s5z4u3rjrfufgmpgcjy X-HE-Tag: 1707430143-853746 X-HE-Meta: U2FsdGVkX1/mb5aOkHvwPpQag2HZcec6mVOC6bDSapfhEf5D5dh4jkylzyasZ3VzX51+jmN/EfMQ0E8Swv2/bz2z+xJZBQS2h0591ji2tZODeWaAJpFq4kYMqpdxXRUVtW9THSU/+VRrfJXzKKlgnTwS2D0/LSczdZO+NjYMOl9qz84GFYvici6il7+wosK174p7pS0hkwLjqLk7i7I252ZYdD9y3l37fqpRNq6lNXzAB2ZlRby5+Uo/APdbg7f+B4acG96PfL08JFjjtEyQ2daSbUF11+fhhFMCZZDWcGATCsqgBnycg9p7rktS7OzJfg1Ea8/aDzdRFq53KuPjZuNqfexClA0cPi2E3pqGDTFG9mdusu4hNmiWExRtRN2ZwWuVLIWIBVO3240zaaWh3UFcqSqH1k1myOqhKCkZKMJ2e1A3FXSWxoBDqkf7b3bBzWGeekzo/6omKAFerLrtKbNS8bhG4wROSGCg8DDtqzf5qov42dP2JurKKwCB2zcBuHeTbsZYmxgMgjotu+48g6dv2OOR5dxv2KMSaJ8RWlY3icEXcPtNjHVTI8hIdjzZW9Psr1DrskUTxxV9+5NKr2IIXroaNq0B/VHR12q9SIAiQ6zbjMnrcQ5hTfDJ/S2tRwsk+Bc9f5txKKRJ67pukohbwmwyEKbdchk5zNhhwwB5m0/n3nSzURbCKZnnjXqAKDGm2GxCTYG4tR62WKy839RC0+WDNdIrYubyHvzHHBfhU3QhUnxOjkfAEwy5A8oIfGTQEQFzUoSWKQS9Q0L+INATKGZeOD9Qcs/DPOsrmHwV+izKHlirZcrdegL+GaL/P/hueFPNftv2YCa7/TWQdEN0MFB7CgRFlNecMl4/8nnDSxb42Zf+KJkX02ubfgY+uIAMKvNGA/MDkHku1CNr5V0/BXwIJosE58BYa0sX0Se9JeyE9+FVD4juzJ+lqd8k5DQg+kiSjt3ck3vXgE4 Uido13XI LIl0FBGd67ATa/i8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-08 16:37, Dan Williams wrote: [...] >> +DEFINE_FREE(cleanup_dax, struct dax_dev *, if (!IS_ERR_OR_NULL(_T)) virtio_fs_cleanup_dax(_T)) > > This IS_ERR_OR_NULL is ok because dax_dev is initialized to NULL, but > maybe this could just be IS_ERR() and then initialize @dax_dev to > ERR_PTR(-EOPNOTSUPP)? Done. Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com