From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04A5C5B543 for ; Thu, 5 Jun 2025 16:15:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8C86B05BF; Thu, 5 Jun 2025 12:15:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 399406B05C1; Thu, 5 Jun 2025 12:15:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5E86B05C4; Thu, 5 Jun 2025 12:15:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E3646B05BF for ; Thu, 5 Jun 2025 12:15:59 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B150F80EBE for ; Thu, 5 Jun 2025 16:15:58 +0000 (UTC) X-FDA: 83521848396.25.A6EB7A0 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id E5A4A1C000F for ; Thu, 5 Jun 2025 16:15:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F1C3ytCw; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749140157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5chTMrgQJS2vmZa5XplnJeYkwgfYEOhwNWxnlCNJXYg=; b=u3jbkWAgC2kg/Um4evGuQQkOC11Gxwv98gwDsLPJ7c1n7wD8fuMVvhfvtfLSXUhwWm9yQE C3hPz0TlLWYWXde1b03n2oS8hXM/0aoTX66hdtYACM0MTk9TX95KJghClnFfHWJ7P2pDdy 9FdESlP1i2obm234NWgP0Fax2tE930c= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F1C3ytCw; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749140157; a=rsa-sha256; cv=none; b=C//dcb1lDA8Xq0wVg9ihQYv95EHdc1NAZ9KQK5K//yxGG+4lIjJaii0Llk04Q6bhGcUIzL YVx8n/2ZrOCD6EWFZN4HAD9NICso26+e/FvRSVAeOvpS1T8MUuWwrNHToSf4LgVrgLpEVh BjppTyadxGq9ySY2QrsA1W11DLvlEr8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B9B2C49C0B; Thu, 5 Jun 2025 16:15:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E121C4CEE7; Thu, 5 Jun 2025 16:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749140155; bh=5chTMrgQJS2vmZa5XplnJeYkwgfYEOhwNWxnlCNJXYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F1C3ytCwGT18Y0qV/xxv2qNGYZHjS2yR3yFvxeeLYQlVyOq/+vXAAYBPJs1YqQCnP 889PwElOGACTCQKo+AvCCl7OBZ9u/NQ7v335m5+aytdAek5Imq9G/rkaQJO5Iod1e/ rt9KIx7u8zSAQPV6ydutJ5WhT3ipEzF2d2EyI7/i0Eq1YQV3k0ToMb5Kefb6kE/i3G wtM94kOgQLc5wlDfNI/1SeVzcewZw7RMTHREhuJMmMOOzKxeW+sUprTTmLv7lVAe3X XlzEuIO78m4dMsPOLp8OH2ljQZ0h1JuRMnQU1yRhSa3+t2HeX8U3W/MEyKYJe+SwLZ 26su1QQ4Y0d/g== Date: Thu, 5 Jun 2025 17:15:51 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: Andrew Morton , Shuah Khan , David Hildenbrand , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm Message-ID: <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y5zP/ODICYjBWB2e" Content-Disposition: inline In-Reply-To: X-Cookie: That's no moon... X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E5A4A1C000F X-Stat-Signature: 4fbiebs385nubnkeghxumufapbqzqcid X-Rspam-User: X-HE-Tag: 1749140156-5295 X-HE-Meta: U2FsdGVkX1/MJiPdECXWinIYhCBSYtqCSostUGDjplI9h+nyLwYYHLt75HrfC/61H2+L3Gzalvu0s+ii2xZI0257FFB56kkV74jKtqZtvx7GCHPo4upIySGVMPbzkTAdcNxBIgVL8TuiCVP3Z/l/X05z+TfoOI2YfEdVCCuH898GFn+kMUMiRGf2cfIbKXFNKtsvS9uTsnTdn3EREr/wZ+Okqa3z4yg5x13Zv24bvutx4sQr3ogIB4+uviI0XzCf8ziy3Merd/kbeNepbijRKj77DMKyrT6TNrnNO2CPRqDR1yzk1x4n1IDa1nHR351DArnvFcaNNmFY76RVMg4UvEcVeQQ1MDpQjb52AN/5RBqGxiwixt+l3hnUOzFFrNYuhj87ThlypLLf1IFYMEgOi1bYWBMZulCYUZIe6SmhHRtIyBLgssW9vOuCTOwzeY4hte8Uu6HSQUht139y56x81M+g7qf8QLr20xITiGTeNwygVaFWsOycfdVXliAVf6Y3ANveTU/CnMm7LlNG3lN6cc9y0LMJXNPuy7XLL/IXYZMLfXrtSQ39ZbHvvUyFLrmbFph2WLJXrjOBIwolY55KIpq6/zYvXm3VOZVHYFzxJoVmynTHitmTqnAtWkdoJpvDYMj5RAgaJ4kRvIkAgCdT5aFSgv8Ua52gLVwzYHDEfc1l7vqqcbXpDJAd97Ia6cqiPi65sdfe9rVQ1vQbBgOHykoqi5aEOrEGQEvh6+3uoS2Pdd1qlaV/w3gXA0+FwytE5xxmZcd0iO+JiVtTalB4otytXtzQata/vLgRrwB1/6QaLmK2ystgZcGuMeGWCZKh7G4Quyzb/3XUrycM/TIYyBgpmIYCdH9s+D/M+tzsn/dONeCftNUyuS2wgpIxaBKj1UnAoYR8TQq4I20xW+Zql5RS4jTAVbE1HOItUdK4cbaIw7QnSyyRBOkgsS/4JfW0znrfyj9bfqmmfeCFbxG enAecuRg /U8+/10b7LCt+WSJ/QCpUL0d3iA6DxD4UCZKa2VmAN6IZW+0na097tE197PtkJX16FUNNCtdEb0gKF24Q9NUzCZgLVKOP5GiAhZymjkXfRfla03jwYvnltakh7hhbONuIEki1v2AUFgBKLGaSsvAE540r1q3svUgRZ3Ep3kxKOBNSlSeDPBCU3m48xE+pBQlN41845mQ9qACRPRObQVhZhxq87/8zb9+wT/lHNnl0DJv/LlAg5T7gXYJeJ/mqmnHomoAEoLiGVF+ra/wx8kRSwXPFNnnn1A9uyOprPo6N6zOIPPABx41XhwzEONt1C/GdG7GfVBYK8kukxXYJCPG7x7DEjDbPr8VsYlRbwz2lSqlHhso= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --y5zP/ODICYjBWB2e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > This seems to be causing tests to fail rather than be skipped if hugetlb > isn't configured. I bisected the problem to this patch so it's definitely > changed how things are handled (though of course it might just be > _revealing_ some previously existing bug in this test...). > Using a couple of tests as an example: > Before this patch: > # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with me= mfd hugetlb (2048 kB) > # memfd_create() failed (Cannot allocate memory) > not ok 39 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with = memfd hugetlb (2048 kB) > # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with me= mfd hugetlb (1048576 kB) > # memfd_create() failed (Cannot allocate memory) > not ok 40 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with = memfd hugetlb (1048576 kB) That's the thing with memfd being special and skipping on setup failure that David mentioned, I've got a patch as part of the formatting series I was going to send after the merge window. =20 --y5zP/ODICYjBWB2e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhBwrYACgkQJNaLcl1U h9BZfgf/ZkJKx9DMIc/WRlEi/afFnFOqjI8V2apX7B3CuS7klARJ57l1fyMdKlRd 3MRc5VRV31VuwmfYdIFPwqHzOnn6PEy7PHvtCwSKO9uCs/po21b3wMlknaaloFwn 2sDENLSd39sWNBlnqqcOVK7A8p2rjTkidUo8Qhhy3NfaoOCwL2b9iiL5gr59cily YkwCy4Un4qDCryspKDr90H1wZGOnt0GbILGTWd/hNIsnwqvXVCG7WAZf0CvIoXSE e3LHCIoLXa7w/qhdakdrV+MHWf7MYmFbbG86hks1Kl0Q1yy+/9pNAgLtYm4vQmZz il0Wv7YKAdwiLTWWn/o2cL6qDoufDw== =Cxj0 -----END PGP SIGNATURE----- --y5zP/ODICYjBWB2e--