From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F1FC433E0 for ; Sun, 21 Feb 2021 23:38:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A73464E41 for ; Sun, 21 Feb 2021 23:38:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A73464E41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D455F6B0071; Sun, 21 Feb 2021 18:38:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0428D0005; Sun, 21 Feb 2021 18:38:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96308D0003; Sun, 21 Feb 2021 18:38:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id A07776B0071 for ; Sun, 21 Feb 2021 18:38:14 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 62479180ACEEE for ; Sun, 21 Feb 2021 23:38:14 +0000 (UTC) X-FDA: 77843890908.12.DED320A Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 6FF6E407F8F7 for ; Sun, 21 Feb 2021 23:38:09 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id n10so9126405pgl.10 for ; Sun, 21 Feb 2021 15:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ewxqEQFZCqRPZepFJZrArWqJzNzRyrMy8DlI7kZWdbY=; b=tBabDsQM88C48+TrDFasmGxRf9lo5KwLdwTxTlg6mOAIgYZzAu1QYqLxKOml6fQOpU sRCdc7uSzDIWN6ysldM0C5UOcR78C8eihFm52FXeZeU+HQ4csvIauJLeaLgfzaUJ8Qnr 5JJNoaB/g4w2yfmgFyCLRE7Ps4aKp6JA1lhrUFiAc2A2JIjLe+3z1R0c/lJrPe9Ll3N/ J2mJXNLavJiiqF/v9E+t0MVLpwv3xigXA33nIZlLGhFCGxR2J11FiNfdpT0diMrfrxQE imsmjKZfRkFo6vfVn41CuIorDhu+QEmQ3y9hFxktPLlCaY0wJ8AWWG96mxJpPBkj7MRL K8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ewxqEQFZCqRPZepFJZrArWqJzNzRyrMy8DlI7kZWdbY=; b=p1c6TZ3AIXrVEmweHEwpOL+vffiIIVmOZIYRNIMTyvd1cb0js63NtjIAwR1HHda9Bl gJGy9DRgNscH7AUYmQQml5WOBkZmyyTunWTaY4MHlk8Pu5QgorsS6IBpJe1IGxTa1htF PkxJNGL7M4X039Y/TncQ+3WAEi+OmiIqRH5NTHuVg94cvHmHzsEL9xb5MKSVAOyXEpP0 qqeB2zDN0DB6XvGD9SKAodK8n4+C84qAXEBFpGO5HVS95WWI9J+yHAk7DnL/DVv1Z05D l+PMiIyZkP+OrWil9idEpVQPKgtxjZ5iAE30DEs8s6bcFokToym/6hHwcJqWd1o9SYJU 5bLA== X-Gm-Message-State: AOAM531IR/BPvvX0efV+WkqSsZDWhd5XMAJuwKp8uMrBuZUJq39HqJBq QFsELnWClaO2VZbRrjN/CX4AeQ== X-Google-Smtp-Source: ABdhPJzdBl7iEW57AktQz1trvZZaWXb2g0jBAcCa1BGnJzyovv2hB07dcYLx+z1UHy8R8jqqeRueQA== X-Received: by 2002:a63:c042:: with SMTP id z2mr17881788pgi.201.1613950692408; Sun, 21 Feb 2021 15:38:12 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id h20sm15842126pfv.164.2021.02.21.15.38.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 15:38:11 -0800 (PST) Subject: Re: [PATCH v6 3/7] Reimplement RLIMIT_NPROC on top of ucounts To: Alexey Gladkov , LKML , io-uring@vger.kernel.org, Kernel Hardening , Linux Containers , linux-mm@kvack.org Cc: Alexey Gladkov , Andrew Morton , Christian Brauner , "Eric W . Biederman" , Jann Horn , Kees Cook , Linus Torvalds , Oleg Nesterov References: <72fdcd154bec7e0dfad090f1af65ddac1e767451.1613392826.git.gladkov.alexey@gmail.com> From: Jens Axboe Message-ID: <72214339-57fc-e47f-bb57-d1b39c69e38e@kernel.dk> Date: Sun, 21 Feb 2021 16:38:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <72fdcd154bec7e0dfad090f1af65ddac1e767451.1613392826.git.gladkov.alexey@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: ihjx53dh5zuuwuaynw8howjhas755pfg X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6FF6E407F8F7 Received-SPF: none (kernel.dk>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-pg1-f174.google.com; client-ip=209.85.215.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613950689-602481 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/15/21 5:41 AM, Alexey Gladkov wrote: > diff --git a/fs/io-wq.c b/fs/io-wq.c > index a564f36e260c..5b6940c90c61 100644 > --- a/fs/io-wq.c > +++ b/fs/io-wq.c > @@ -1090,10 +1091,7 @@ struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data) > wqe->node = alloc_node; > wqe->acct[IO_WQ_ACCT_BOUND].max_workers = bounded; > atomic_set(&wqe->acct[IO_WQ_ACCT_BOUND].nr_running, 0); > - if (wq->user) { > - wqe->acct[IO_WQ_ACCT_UNBOUND].max_workers = > - task_rlimit(current, RLIMIT_NPROC); > - } > + wqe->acct[IO_WQ_ACCT_UNBOUND].max_workers = task_rlimit(current, RLIMIT_NPROC); This doesn't look like an equivalent transformation. But that may be moot if we merge the io_uring-worker.v3 series, as then you would not have to touch io-wq at all. -- Jens Axboe