From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC214C5B543 for ; Fri, 6 Jun 2025 01:11:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 739D36B00D1; Thu, 5 Jun 2025 21:11:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E33E6B00D2; Thu, 5 Jun 2025 21:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A9D86B00D4; Thu, 5 Jun 2025 21:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A0956B00D1 for ; Thu, 5 Jun 2025 21:11:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CECE41D756C for ; Fri, 6 Jun 2025 01:11:50 +0000 (UTC) X-FDA: 83523198780.01.56D1704 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf07.hostedemail.com (Postfix) with ESMTP id 519F24000A for ; Fri, 6 Jun 2025 01:11:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749172308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tl2gwBh7Tm7WeLTeiondviaVHNaqUBnNm33uu+7otHs=; b=1LLgKK2VFisMA7eezRkRv/GU6b7aOu/LUuJbN0jRUGW7YmJKlAA09OEgzwv71tdOZz82vM iPtj0pgyXsT9yjysVL76jz6whC0GN8GAVZ78SaoZSdZo0atodUgL0T8inUPZUnUUnM1zLS XOkHFNjYR32cKErVI/+WenbjP0HOKRI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749172308; a=rsa-sha256; cv=none; b=zCuFMA0sEQoFjJnMPE53r9t6YvNQHpYYuTMnOSfuAHVBeRrcLtoU/zT3eYMuBHsTafnvRi exytQ92cPnne/6yKS6PaMhyqhG+0kIrfll4WSGMn0h5Kt7zhU+bCIsijBUm89HTKnhuqBq OzNHIw7sSTWZzfsg+UE4aWfBy4dtw1Y= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4bD3Dr3R40zYQvPp for ; Fri, 6 Jun 2025 09:11:40 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 828221A0AD5 for ; Fri, 6 Jun 2025 09:11:39 +0800 (CST) Received: from [10.174.99.169] (unknown [10.174.99.169]) by APP3 (Coremail) with SMTP id _Ch0CgBnB8JJQEJotWmmOQ--.56805S2; Fri, 06 Jun 2025 09:11:39 +0800 (CST) Subject: Re: [PATCH 1/7] mm: shmem: correctly pass alloced parameter to shmem_recalc_inode() to avoid WARN_ON() To: Andrew Morton Cc: hughd@google.com, baolin.wang@linux.alibaba.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250605221037.7872-1-shikemeng@huaweicloud.com> <20250605221037.7872-2-shikemeng@huaweicloud.com> <20250605125724.d2e3db9c23af7627a53d8914@linux-foundation.org> From: Kemeng Shi Message-ID: <721923ac-4bb1-1b2b-fce5-9d957c535c97@huaweicloud.com> Date: Fri, 6 Jun 2025 09:11:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20250605125724.d2e3db9c23af7627a53d8914@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgBnB8JJQEJotWmmOQ--.56805S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xw1rtw48Jw48uFWDXw1rCrg_yoWkXrc_XF 4Iv39rCFW8XFsrAa1DXw4SqFZYka1kur4qvrW3JF92vryYq3WDCrnrXrySyryxXa1UKFZx Cwn3X3W5KFyj9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4AYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AK xVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j 6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1veHD UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Queue-Id: 519F24000A X-Stat-Signature: r5ufad47cn58ijfgmdu156r6a4z4sft5 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749172304-138522 X-HE-Meta: U2FsdGVkX1/8AN2WP4tnoPlN4aJMouObAOHKA6+cvSYcyNnSXBXJ8ktz6VT2EJ16cPYCUyDJnLP3BcKpElNxdA7F6LMliVkJJ+q2o3YyjiCHBhRPt3ZmGpSjPD6ZJOjeWRzNq8mgzRiflifuWrHnrFV4Nc0Dh/gfnOkmZjkSBAi+yO6Z8OCeKPZSNPNm9ckWh6BK299Yh+bw8TC584D5VUxhX7dOY6G/+cGW1Dqa/gCwUq48CwjIz4J22nMVBG7i2kDOgzFPj5RCGsXG6gB60JOByUb4VwN8OOcIvIev7gRdM+jroMQGl3+PFWN5QF69KfezeZKXHCBA3IHpQ30zerixna+aJWyz29wwP7fF2hlFlSuSRVhUsMaxqiBnu/aX53jewVV/+nmEkM0VTVGGqjCm1KHD/qvuVqNgEfjGw7zdJxsdKa0BEM1TVJmAz71lUJjqG7VxIVwgqSbHowMMUx7p9Y1q72Kbboob9aLBc1zW+Hcp5VHwl5n5sT/FWuv0D2Dd6fi3w+wyMbwVk0YcRl0rus3CpLXsIu7jwjgsTCApHwfNwsirsJT5EStPaPkqVZei4ZXwVKSRDuqyb/MSlst4K+094mo6L6mKqpeVhubKqJP1cLeQ6uzLphaXNwyENXZra0QKulgccg3vejwkkyK4ARFFaEtlvgXf0/NxDkF1uBPI7CkpyjjPPswRLd9irLiTDaXeyYeeAFACmMlM2bTcZASLIEUiP+PHgoB5LqNvYvRYKafPc53iHmpwGBlZs5t099f5jAm8VbLCBkm1sYSoz7lqCU/XQ+raqVGg1GRUyC7Duk6+vTNK41LeBv4Nvjvi3zvqCBfu0tmkE2jKrxYlcXgnP9GKXxaPa90pjYb7H8B9G+UpEyuUKCd2EaKM8mphtPTZNbDNeU1Q2Jvyb/V1l1sjlJvvuKdqU7aakVSIp7EBBiNYfuAZMMV0g4qpI38AldHaikkj9tUUeNN WEL59ENi DgELvBC1CDPkR6HNsm3gfzzsOJtxgvDuVeKMpEUBINLP1UDxafxBAE/WaRd7U+ofFSZ9lZdHnfsBkoIazdRRTR22abUTSuDx0rCJXIOWLH0Bb+jRK5GHRvlRJe2/WpS5xWptYj0EzHWpyPfeIPNGaihFN2lhdeU9nBb7U/DXohA09oDBRmg/++0L9jXFELxDwEsqu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 6/6/2025 3:57 AM, Andrew Morton wrote: > On Fri, 6 Jun 2025 06:10:31 +0800 Kemeng Shi wrote: > >> As noted in the comments, we need to release block usage for swap entry >> which was replaced with poisoned swap entry. However, no block usage is >> actually freed by calling shmem_recalc_inode(inode, -nr_pages, -nr_pages). >> Instead, call shmem_recalc_inode(inode, 0, -nr_pages) can correctly release >> the block usage. >> >> ... >> >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -2145,7 +2145,7 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index, >> * won't be 0 when inode is released and thus trigger WARN_ON(i_blocks) >> * in shmem_evict_inode(). >> */ >> - shmem_recalc_inode(inode, -nr_pages, -nr_pages); >> + shmem_recalc_inode(inode, 0, -nr_pages); >> swap_free_nr(swap, nr_pages); >> } > > Huh, three years ago. What do we think might be the userspace-visible > runtime effects of this? This could trigger WARN_ON(i_blocks) in shmem_evict_inode() as i_blocks is supposed to be dropped in the quota free routine. > >