From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65283C6FD1F for ; Tue, 26 Mar 2024 09:39:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C29036B0085; Tue, 26 Mar 2024 05:39:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDA8B6B0087; Tue, 26 Mar 2024 05:39:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA15C6B0088; Tue, 26 Mar 2024 05:39:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9A5EC6B0085 for ; Tue, 26 Mar 2024 05:39:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A00780403 for ; Tue, 26 Mar 2024 09:39:07 +0000 (UTC) X-FDA: 81938691534.06.6490B99 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id B629D40015 for ; Tue, 26 Mar 2024 09:39:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZbIU7G5D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=a0eJdvzO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZbIU7G5D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=a0eJdvzO; spf=pass (imf01.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711445945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kGl36ZnVCOBSUYs46//SH0vHjzvfLhWPNt9V5YwfBJE=; b=C5ennmGrIqh64qh/9fC8fNUUIs9+WGnXU1UzZfRL7BhirFFalXiscK6wTW/gsYsbznZibk 4mfDGe53zpNzCcxu3pVuyJKifiV87Le2YFc6FlEs7h9IP1YjAAbK8smv3C1xLg5U7hCWSd /JjMnOCQ8f2N95G6CpEXN+WoHifaJ9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711445945; a=rsa-sha256; cv=none; b=F7rJJSsjHtj2l1psNThqhRLncZLBhJoJyJhhLnn2kegu3oresdju1oxv2u5sJUyvrFsjs+ +SXAtt7UvpU63mDrY/QP3E4iqjy9GUCThcLegcbLYgpPSz2ooyzEwm492FU5p/Sa1jaYX9 l5a2SjI/XkVYB76MEdwxxg5nALnUPgw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZbIU7G5D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=a0eJdvzO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZbIU7G5D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=a0eJdvzO; spf=pass (imf01.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F31485D3D7; Tue, 26 Mar 2024 09:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711445943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGl36ZnVCOBSUYs46//SH0vHjzvfLhWPNt9V5YwfBJE=; b=ZbIU7G5DkSH+jpZAFdb+J2b0NX74xsnNDpOY1ITDpfwH4Bom+dmZlmUihPYQhqYaG3gt2C hcjA/Ko4BvCTVTFS8bxlYEPvbL7ukootV7TjUPVG8ZbHtpG9nDe8n7w7TtpNcedHFpuzeE maTDQMbsyjlVmrGkoLdHQcP5sgMYyK8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711445943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGl36ZnVCOBSUYs46//SH0vHjzvfLhWPNt9V5YwfBJE=; b=a0eJdvzOIyEJSe9rsEYCU6FGOTEjDMObliszcUoPG1w9ANsSUmhK2+hgDcueK2UTQC+asC 0+wSYiwa0SNXwBAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711445943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGl36ZnVCOBSUYs46//SH0vHjzvfLhWPNt9V5YwfBJE=; b=ZbIU7G5DkSH+jpZAFdb+J2b0NX74xsnNDpOY1ITDpfwH4Bom+dmZlmUihPYQhqYaG3gt2C hcjA/Ko4BvCTVTFS8bxlYEPvbL7ukootV7TjUPVG8ZbHtpG9nDe8n7w7TtpNcedHFpuzeE maTDQMbsyjlVmrGkoLdHQcP5sgMYyK8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711445943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGl36ZnVCOBSUYs46//SH0vHjzvfLhWPNt9V5YwfBJE=; b=a0eJdvzOIyEJSe9rsEYCU6FGOTEjDMObliszcUoPG1w9ANsSUmhK2+hgDcueK2UTQC+asC 0+wSYiwa0SNXwBAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEF96138A1; Tue, 26 Mar 2024 09:39:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id EEwMKbaXAmZpcgAAD6G6ig (envelope-from ); Tue, 26 Mar 2024 09:39:02 +0000 Message-ID: <7217df4e-470b-46ab-a4fc-1d4681256885@suse.de> Date: Tue, 26 Mar 2024 10:39:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/11] readahead: rework loop in page_cache_ra_unbounded() Content-Language: en-US To: Matthew Wilcox , "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav References: <20240313170253.2324812-1-kernel@pankajraghav.com> <20240313170253.2324812-5-kernel@pankajraghav.com> From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B629D40015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: b9kpc116cihqao8ipydd5kifwu9xwzg8 X-HE-Tag: 1711445944-840299 X-HE-Meta: U2FsdGVkX19WFOADwsrd1lWOGJMt1Zq0//ss6fIN3Xa3fA7yvGnkQBwNw9fCNj06+PaBKm5pixr4TStkzYu34bifJhV/QNw5dkNtbR/bYO4d0d8el39aT9msF8DAFlsz6WlbqpwhX395eOp3ePu4g0zZwd+oo9ulxFvKe9qyI5My2bE4r2ZDlPezSw0+mDV7CjcYh/zQAWX6oo8AC3JwLbwRtKPV0kzdccejWCpeF848kZp92/7pw0CnpLwHGZ5OgdR2xKj/KTYkQ6MT50wXv7XTgxGWYo4yKU51f5ChY/kgsmfgidYio3ImOoGQtL4rRkea1GMWC3YZD6khpNy6+JB4ukIncBCXYwX+DyUpKDta7cbFpuBFsUxizrmy/IebRXDtAkJNe9V6N4LNa/xRoL/RUVJIwL9hqHKArlzrik9N+GRpZGD/LF62qD0lrqHVPdhYlCSB3gO4a3pW8nFczpih+IbLbNK7B3GizIRl7IaD1CoaarqwX62/xKT1mGt2yg575UcihS+60wsgydHPIzbvnM++g2OxNCHv2beB0zZZcg+MYGQCyFkxUwiiq9+QMQUHLAxX1W0AborNKa2f4q8ao+wcRGLPm+3KEHkw9MWrgyJhVdeLxrcMLScY4TtqnTfwG7aabSxiu/pqAiWYU5AXtxp4/72/qOgf8n1NCymQD1hCjmHh0akL6XSSb+I1u4K4HsjYRwP43FRBGiFp4y7vIIdqG7JT36C1erWYI9rm//A+C8OGqLazaqUu4EijfBwLsmUsVIBqeLk7Zg6+zyQ7VkNzTK4fP3emJXnGHrSqlQ2DlRwPiTJqNVXyJfU2K03q0FXB6EoGYyFt4fE/jxloOQIBnsqdgnd3bjrn6qJUh0+ltxjKpMPYS/ow+dtSVJ4Wq+HzMBPamQLPrK/yiWOnrkB7NmewI1pkwjXi3z/HFxlAioSove0a0ZU89Qz96oUlXXPxFhaO13lGSGe K0fpMrwX S7yehM1p8QTApp92VLoJtyHbt5IwKJTCbEYgMWRKxE2/CDGR9tsXsAishgZRLQedlCA6IDIDYUByFl0axTSujWlAetZIGihwyRfGG8wzJuuxhJjFY3Hx8aKJ2gqDRiit4eQZyV4W9Fx+ciW3AFDwqPdW5KNxAsifjagD2kysJZhz/6VKqcDJyOZwKMUD1QU9M8YCC4aCO1suwvQlu4JKCwfYKnCXLACrNvOyA4OWNuF7SlSRGq4e0vstWEEh5KqqrfAhyR98k5qwLCsjfmcDjI5Ns83ItytyLtFcj91tYTwRI691Glo6olVJjtBZQVQIb6N5EZnwVhjpnP7o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/25/24 19:41, Matthew Wilcox wrote: > On Wed, Mar 13, 2024 at 06:02:46PM +0100, Pankaj Raghav (Samsung) wrote: >> @@ -239,8 +239,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >> * not worth getting one just for that. >> */ >> read_pages(ractl); >> - ractl->_index++; >> - i = ractl->_index + ractl->_nr_pages - index - 1; >> + ractl->_index += folio_nr_pages(folio); >> + i = ractl->_index + ractl->_nr_pages - index; >> continue; >> } >> >> @@ -252,13 +252,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >> folio_put(folio); >> read_pages(ractl); >> ractl->_index++; >> - i = ractl->_index + ractl->_nr_pages - index - 1; >> + i = ractl->_index + ractl->_nr_pages - index; >> continue; >> } > > You changed index++ in the first hunk, but not the second hunk. Is that > intentional? Hmm. Looks you are right; it should be modified, too. Will be fixing it up. Cheers, Hannes