From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D82C47DD9 for ; Mon, 22 Jan 2024 17:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897EC6B008C; Mon, 22 Jan 2024 12:34:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 847E86B0092; Mon, 22 Jan 2024 12:34:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C1E76B0093; Mon, 22 Jan 2024 12:34:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5C2AE6B008C for ; Mon, 22 Jan 2024 12:34:23 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1FCCF409B1 for ; Mon, 22 Jan 2024 17:34:23 +0000 (UTC) X-FDA: 81707646006.25.1C83706 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B172580023 for ; Mon, 22 Jan 2024 17:34:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FvOJgGsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705944860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JVhXCj+zVb64z4rJlyu7FmGbPuVGc4Yu55zzJnDneDw=; b=bben+MTJfdWGP0ZJsier1iO5AMVu5bgNFkrKrZHhNheWox0+0nOsjH877nUme3KcMOLYjm GrCAg7CVUTerdwxB9iLnbQI3lMhxOzt0FneRmL8Lkyj9g/mpZaB1fWF0hVf2U0jnUtAEUY rYAe156ucKwzvK8NGEk+x5JDWE6GEx4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FvOJgGsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705944860; a=rsa-sha256; cv=none; b=BHJ76eRYEwvA3CHQat0p+TK18IrLuiDIDVmuqCvGL7veCpcP5kGNnolEuLAV8wDPs1K3UO IYUci5YgkFrDGuDX+6zdIj/x3d5781gntSrXy1Vr5tc+F1v3pZNjaxzfNf6kKAEI1A3Uz3 bCyeLO6g7WS2PQOOyzgwzALHubHJVDE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705944860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JVhXCj+zVb64z4rJlyu7FmGbPuVGc4Yu55zzJnDneDw=; b=FvOJgGsH2hCFsGzBJFkUBCphpKEMW71AjNwNyS5UXp64T22WE1EWWJDhkxIBqIU3FqP6Kk WDys+UErxvDnjgiXHZTEKUEiGLl3tJrWXBp8kAHjg3zO4kgD4bqkSHfWQj675jdF3zae2c pu/n5R+1NO0sJZ9Hq5/2ucGa4W9Xf2s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-tF3jcMshO4CPGRCvb9dh3g-1; Mon, 22 Jan 2024 12:34:18 -0500 X-MC-Unique: tF3jcMshO4CPGRCvb9dh3g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40eaed9b181so9270045e9.0 for ; Mon, 22 Jan 2024 09:34:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705944857; x=1706549657; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JVhXCj+zVb64z4rJlyu7FmGbPuVGc4Yu55zzJnDneDw=; b=QUsBNlwDohml9ZvstQTifo8uvVU3em0UH5JuuUXDq/VS7TgE9nAB6ECEGAoXbwxp74 nantJqhumOzl6inTcKet5pSPAjNFnYssAdgBbU17vibnh5A127lwtGXT6rJweUDQu62K GZtPflK3aNRKpGByibW63WU3heFX9jm3+/NnlfCIZtpPE/bVBrzMFuhX1XTFCdBMX0ft wyCOPWGxMCdPup4fhfy3scbYeE4Dfqz8O5tNReZWQ3Zgyi0oPjcNhH/ul9mhcAmKV9zU 5bSHEEbeXPYAWCmfZT67F+rF2lJDZB+UJrmGZnKNWkcWN260I623T9ZORijGoKk20gjd UIgg== X-Gm-Message-State: AOJu0YygkJm6dfMHU6PLmaI+v22w/tDm3SThHLHDfb2aunvD9OkGfyA5 XqVg4ztUV5wvObat/uKLKn5yVsc3rWo0bji67ION7Cc7G6UQyO0i00ilLl8yw75BaBKAEIXrPaS F0GL/xB1n6IYQ282EFOp3H4lbPCiVuSDA03c+PV/2OubIsxz7 X-Received: by 2002:a05:600c:154b:b0:40e:a370:35d4 with SMTP id f11-20020a05600c154b00b0040ea37035d4mr1232145wmg.95.1705944857417; Mon, 22 Jan 2024 09:34:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2wvwTL5POCQU0i8HTDG1ylDcpgV+uQsddAbZ9gg5iMLxqyNNwE/AR7TQjFzCEmJ8juNrQOQ== X-Received: by 2002:a05:600c:154b:b0:40e:a370:35d4 with SMTP id f11-20020a05600c154b00b0040ea37035d4mr1232139wmg.95.1705944856977; Mon, 22 Jan 2024 09:34:16 -0800 (PST) Received: from ?IPV6:2003:cb:c737:f400:b194:1841:c4a5:75f5? (p200300cbc737f400b1941841c4a575f5.dip0.t-ipconnect.de. [2003:cb:c737:f400:b194:1841:c4a5:75f5]) by smtp.gmail.com with ESMTPSA id x7-20020a5d6507000000b003392940f749sm6716219wru.77.2024.01.22.09.34.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 09:34:16 -0800 (PST) Message-ID: <7214a9f5-367c-492c-b1bd-80bdc9b7ba4c@redhat.com> Date: Mon, 22 Jan 2024 18:34:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 28/40] mm/memory: page_remove_rmap() -> folio_remove_rmap_pte() To: Matthew Wilcox Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-29-david@redhat.com> <2445cedb-61fb-422c-8bfb-caf0a2beed62@arm.com> <007e83fa-16c7-4700-b326-ee8cb7809f9f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B172580023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: njwa4jgp8uqex5k6icemu4ze3ceqhfez X-HE-Tag: 1705944860-218768 X-HE-Meta: U2FsdGVkX18TpPwOrotQ3b1IcbsxALb3NY/XVTUvjL4YYLg5V2fSWkTYz4AiOoR6qx0htDCTgI3wCAzGWka7z9YNr6KVFagZDscec9Y1RFxT2ZfPKOwFi0toGaBojMTOD+K1IuT6b9jajxmytpjQ9HkcleIE+sisU7KufC3gA4G6WW760F/XsojQEMVUSi2isMo/jq7yvPu46wN1coBxDFUfElVDoZLKMS5iPZS+FsKYNPiJiJ6PoUcQAXoyNoF6Ti+MpQ/RzYOfcb/6VPs9EVMnli7pD0TAVPJiZbHEC6Li6fy5fX/u1QB93OFqihM93qu4aVq+8vUXN2qjmORybIZ+g7onTsJm4oWUdf/Fg6iHP7QHun8GiJNmXJprO50X2YYseWgeXXYZ5bFTMCnSujP14MSEKBNm9Vz3VXIdy6Nh+MDxLkrjXLn6Afcn+H6gQtR1sVQZVjEEjoFAQf0ICRGwwZnpy560C8aS4/z/e6lHLLNzN0CQuxCaD3/7uJm76NQaCmBzNyit7iJLT79ZhTr6jSyLGGCC1wW/dZ2T0oAcp7zotozX/QRm6aWq1tRTmzloarMF+SNjS+oeYhS1yqeryVslzaZVppF81Fj5E7YfQLrZxf+fJbsGtgeRj+UUpeVXJbXA2ocdD4XDr/++29pNbH1GY8I9XKmiASPH8/mQ3dc4KAyL5iDHmkcRsaenKWE1OI5tv4K3JrYEvyEBJz4/L/ZtVRq+pmx4kJYrg66nylgLSlp/KQYpAI7xKs0/be4pNF51DJx/mnuHWRrmNZ41TvdUV79fIRDvmuUsG4o0QO6ljkyHk++zMDkwvpzHTCsZ6+XxS6tZZ50QdRIuQOL45aGCV2+m+oXmrRmMTAAHK0kCtd7OSxd1Itw0pdgHla/q2GAlLlsnLfs3FFHmTbFdw9N6o+pv+vMu8G1hzzaItcxCJV4kK5jDeYNQ4kpY8g3C7R8YYvd0zn6Lfzf 17lOysJD hbs1P30najiMi///5BaWHlr2nPHpt7Co3JdO2YUHQllRX7TSAEb1ZNIt81IE66t9wqvHcRHmN3loP/aRTHPaZqF/EiNNZlLlgiZ5qXdjZQDh8luUqS4ION966POe4aXKAMRS1MGNT17Qz0nYI6yqboR6YPi9QBygpNO1KHn3V8b4vWPiSlyMwDnDR9KBUUzwKb/fwWtes6c6hRi10mIkR9VarvpXMxixfzztzQu+yjkDPLSi6xdxq18/fo4FuSBn0A9qDiczc2cJrvLwiFXgg7kjOXWxWdhQDkb7WObx+8BHWun/6e1Gq/OAM0mjtYyIMe3stzOnFpHgqhILf8QtIIfGDuKaGbFJLhKhpL2wjBC1+Tt1lDNsYmUrVo+YGjAKfRfQO5kIRUo6lLLi3ZFMAT7J5Ox5BzXSAnLDpFoBMD4uvtDOik1Oc4CcG0eUmdzwQG/ISYjYMsdTHDvROnVpZlNcT5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.24 18:20, Matthew Wilcox wrote: > On Mon, Jan 22, 2024 at 06:01:58PM +0100, David Hildenbrand wrote: >>> And folio_mark_dirty() is doing more than just setting teh PG_dirty bit. In my >>> equivalent change, as part of the contpte series, I've swapped set_page_dirty() >>> for folio_mark_dirty(). >> >> Good catch, that should be folio_mark_dirty(). Let me send a fixup. >> >> (the difference in naming for both functions really is bad) > > It really is, and I don't know what to do about it. > > We need a function that literally just sets the flag. For every other > flag, that's folio_set_FLAG. We can't use __folio_set_flag because that > means "set the flag non-atomically". > > We need a function that does all of the work involved with tracking > dirty folios. I chose folio_mark_dirty() to align with > folio_mark_uptodate() (ie mark is not just 'set" but also "do some extra > work"). > > But because we're converting from set_page_dirty(), the OBVIOUS rename > is to folio_set_dirty(), which is WRONG. And I made the same mistake at least also in "mm/huge_memory: page_remove_rmap() -> folio_remove_rmap_pmd()". I better double check all these so-simple-looking conversions that just went upstream. Interestingly, __split_huge_pmd_locked() used SetPageReferenced() instead of > > So we're in the part of the design space where the consistent naming and > the-obvious-thing-to-do-is-wrong are in collision, and I do not have a > good answer. > > Maybe we can call the first function _folio_set_dirty(), and we don't > have a folio_set_dirty() at all? We don't have a folio_set_uptodate(), > so there's some precedent there. Good question. This mark vs. set is confusing. We want some way to highlight that folio_set_dirty() is the one that we usually do not want to use. -- Cheers, David / dhildenb