From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A1CCFC60F for ; Fri, 11 Oct 2024 07:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98B538D0002; Fri, 11 Oct 2024 03:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B608D0001; Fri, 11 Oct 2024 03:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DCC08D0002; Fri, 11 Oct 2024 03:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5DCF28D0001 for ; Fri, 11 Oct 2024 03:53:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 708E680E66 for ; Fri, 11 Oct 2024 07:53:15 +0000 (UTC) X-FDA: 82660556034.16.B4E0B18 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id DE3B98000A for ; Fri, 11 Oct 2024 07:53:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GX/BTqHo"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728633152; a=rsa-sha256; cv=none; b=6h7TYHKW3zPosRv9Shq6wEOCuqm7d80lI2wKI39JM/m5TdQK08qLNZFKcl8km/FvjcDVLk b0JgAj6n9ZI5qWfBXgBPA/Cg2Lex0KAl1If0dfbsfZUHtzFQe+kYk+cDzTKShUDC6HETGH PNw7A1GntauhpMyx0coeOfd1ZgG+sA4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GX/BTqHo"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728633152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PB3uSJnSC730si8Kgmw/U9rozxxYLF8SiWvc5GKVcY8=; b=vwXiZ5BnL5XJ2xy8nPVOY/65HnR+SbU2zdLz7TyY5Vu8iYs29ds65BMTymFA72VyZ2w0Vr RZIIEZ9tk0zi9zGmenvaw91WHNk+MVqX4oNs669qBLJspSJ7RoltgALKkM6t+1WYwPpxdD 3imeRfy252RMpj8vS20CHVwbZbJvGKQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728633196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PB3uSJnSC730si8Kgmw/U9rozxxYLF8SiWvc5GKVcY8=; b=GX/BTqHo8h9T3XH56aCIfxB5QKkynKJ8sgwhgBuN2Upp3AkxrNFkCk8kfYr73QxSkHNG7Q fk+4Wjs/WS8IXZYW7SZ/NUFjdlgpFI+zdJMU0UgyjKfP4o6K1eBviaPtSDv+CMgq3bbGRM 4pHGoNGQu8OXhNCTHAKnzY6V7XC2YyQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-hoHrHwiTPDSPOxdiGjclew-1; Fri, 11 Oct 2024 03:53:14 -0400 X-MC-Unique: hoHrHwiTPDSPOxdiGjclew-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42f8ceb8783so12489015e9.1 for ; Fri, 11 Oct 2024 00:53:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728633193; x=1729237993; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PB3uSJnSC730si8Kgmw/U9rozxxYLF8SiWvc5GKVcY8=; b=rsHsxtSy2GptxVy1PmA1okFwI7RGCJ8Y2yPcNxLlrnAamREv6Ryjw1JupTURI6C3On xLkz2vcmEYK5rZG2JVvQ4OH6Mcy+iaJ8uDXm+6vIhOOp+7TMI/ygJ2tOEfyYUd/Wi1Ue VTGH9Dev/dcdu5TzpdOvSDQhdGrXelk67XfQh/4kW4wdlwAPsP8f12l8cvZK0n4iIWnv 3oyu8HevkVmVfuveFPuvYQ56c8rknvFVgWrOdRjKHeyMAG9XnBVqgB0lCEdp/LhkPIJF PdAey++lZWtUDLNImBk3WitxOpC62+qZ2Yav/gLmGkg8vMTc4CRt3tjvQ5oftshRxGI5 FKYA== X-Forwarded-Encrypted: i=1; AJvYcCUUqr7IptIah6Fqg+MBCNU9HrSgW+H5eeZi6kSsxNfEz4/a9dJ5E43zcfDCh7uRhi4eOnHhuRu3sA==@kvack.org X-Gm-Message-State: AOJu0YyHlXFz+Qme4JTyB5BEEBoPcDK49uk1lOfXAiBALZ8aJuc2TCbs kJ3zenPYkQN2g1KenSs3EvuyCWms3FWPyQFt7HC7MIbEKwkDiUmw2dzzxJ4wCTCRhPMT2N5ywLZ F6xjHoZgTEtnZxJuSjRtBz7AUMlP368YoGzeYJvI6gzQUjH9U X-Received: by 2002:a05:600c:1d97:b0:42c:c401:6d86 with SMTP id 5b1f17b1804b1-4311df42d68mr10844135e9.27.1728633193561; Fri, 11 Oct 2024 00:53:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwIQ/yKEmVUyysn1VXEN96vnq+NvP6biy+O4o5qiZGX5D5+I/aZQa0VEo7pJr2DRzAHDRUxA== X-Received: by 2002:a05:600c:1d97:b0:42c:c401:6d86 with SMTP id 5b1f17b1804b1-4311df42d68mr10843985e9.27.1728633193169; Fri, 11 Oct 2024 00:53:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:9100:c078:eec6:f2f4:dd3b? (p200300cbc7499100c078eec6f2f4dd3b.dip0.t-ipconnect.de. [2003:cb:c749:9100:c078:eec6:f2f4:dd3b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6cfb35sm3297405f8f.52.2024.10.11.00.53.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 00:53:11 -0700 (PDT) Message-ID: <71dc3853-45a6-4fa5-b3c6-b165e0ab6a1b@redhat.com> Date: Fri, 11 Oct 2024 09:53:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -V2] tdx, memory hotplug: Check whole hot-adding memory range for TDX To: "Huang, Ying" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" , x86@kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Kai Huang , "H. Peter Anvin" , Andy Lutomirski , Oscar Salvador References: <20241010074726.1397820-1-ying.huang@intel.com> <037801d9-8923-4d49-8423-072fd7c73069@redhat.com> <87o73ra0p7.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87o73ra0p7.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: DE3B98000A X-Rspamd-Server: rspam01 X-Stat-Signature: ugrdykihiufhmza4jspeb6dd7nkjw9hm X-HE-Tag: 1728633192-860264 X-HE-Meta: U2FsdGVkX181vI6db1Zh/cNVkY8cxu9ohrxR0JH/cJRPxMcuN5vtT3EGCAqjX1D4VlWHw4DvHa2tH8+WXOrzzsqS4pqZXSRhCM8O8Yq1LbFSapdQ4+FCBpqVr8AbpK6hY+nPoL5lioy2pVBbsMD3eL9nNBjlzZxQxBwTcBEdARa8K4aJPCOht4EXTtth6/2wF5J1WVxd5tr0UjLD07o1BItzwMXw6Fv/DNudVreqLwz8inh8mTUJP1COcNA/T1YylPR6GEF8mVfJw4HauU7aLgNgTlmPoE5ywC/NYkuLEls9a6qHMFmx81peU1kP7ZT8AqcdyBPVkwFVd3wmlgY6fBwNUNbBo0Jwzpg46IweTqgPUkNyMpsUbhWPCCkIeyy6VwR/ggvB3wGcJfMqGaKOQgdARSF2c3iFH+GzW40KEzb26z9nBczsM7e1rPIr+tKs41Taq9e+tv/SK40/g/mIt8f8GZqdR7D6hAX6+UxG0bgVJz6d+vWjiicgz+HWd004KBJEMH9S32hV7FVZezGOs5T9M+6qrmWBbjhJ8LR96iEK0SCRLOgiSZ/WkzJ+8iTgVjCiIE/gEZyx6QY8ECoGMw8PVbFs66W1X1UswN+6gq0sK6Vsca470i6BlWBigFcRweEAPMzD8QW4/TxBRcX3Hy97MR5nEz9hK1t2MnWfc+q6k6S3QCOTrpl+ymiKpo6GV1Sqnk4N0d4FHdH8x6D3c5PUofrLIJTGILhtmMbqtaySqL/SHhwnLmHg190OeJ7c3e7xjJJ+ChgSqBT0gytb+09QvFFwkxtS1nhW+oe4K5DXUs06B7TEh4Jv4hofHoEdxN48jR2EWYyipYBtWMmN2SjMpfjVlMddWN/5IrIaXRsuHvAYIEAxANjuS6L+qkvGQM2K3d1Hhe4G0b0jBSOEWmDqwh44aEhmLuxOkzHZqxSGOGpxnR9b2AYeqIckXSiILkHcSDQW5EbVL4JyBoF oBTX6Z0f FjsEM2U6uxsi1ua44gFLeSZFCZetACpFlw4sIRiUitJ6TTxwhCb2/vOCF8NkNyfWrvssAS/x8CxMI5U7Wc2PuCvk0b/VF1SzSlCBmUot3U0Kaw6dLXRFXMqyiYKAHDRUGCE5bPkC4kSmmFK1wBLpTlihyv1sa4vjnLU8TW+A2/jQSbUw/RCyjP3lyUIBDl8oBKK0cVFU9fiTtXyMFNgh+yEFcJAx1g8nAk2yN4O/HH2n7flbptlt6lE1Ip4ZrRMU4MXCrazb7vjKBTKDYzXY4vfHAMkf1OoiWu7xTH2PUn9TuWJ6ZLRnABZc5ag/ry/sGNZHYAKej21rUEuy4SHnE/ORTI4vVtKdmG8k9Nr0iCdHhZBzidFdaFLNM1CglNLp/mY2mr6CSieShLr5wb6WtGZHq4MWcZHIvNBowJuNm/tye8ig= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.10.24 03:27, Huang, Ying wrote: > David Hildenbrand writes: > >>> extern u64 max_mem_size; >>> extern int mhp_online_type_from_str(const char *str); >>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>> index 621ae1015106..c4769f24b1e2 100644 >>> --- a/mm/memory_hotplug.c >>> +++ b/mm/memory_hotplug.c >>> @@ -1305,6 +1305,11 @@ int try_online_node(int nid) >>> return ret; >>> } >>> +int __weak arch_check_hotplug_memory_range(u64 start, u64 size) >>> +{ >>> + return 0; >>> +} >> >> BTW, I remember that "__weak" doesn't always behave the way it would >> seem, which is the reason we're usually using >> >> #define arch_check_hotplug_memory_range arch_check_hotplug_memory_range >> >> #ifndef arch_check_hotplug_memory_range >> ... >> #endif >> >> >> Not that I remember the details, just that it can result in rather >> surprising outcomes (e.g., the wrong function getting called). > > I can replace __weak with #define/#ifndef. > > However, it appears that "__weak" is still widely used now. Probably better to avoid new ones. See also Documentation/dev-tools/checkpatch.rst I assume checkpatch.pl should complain as well? -- Cheers, David / dhildenb