From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3689C4332F for ; Mon, 6 Nov 2023 09:06:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC2608D000D; Mon, 6 Nov 2023 04:06:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4A4A8D0002; Mon, 6 Nov 2023 04:06:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9EFB8D000D; Mon, 6 Nov 2023 04:06:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A96E48D0002 for ; Mon, 6 Nov 2023 04:06:11 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77E891606DC for ; Mon, 6 Nov 2023 09:06:11 +0000 (UTC) X-FDA: 81426947742.14.0D67C5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 337601C0008 for ; Mon, 6 Nov 2023 09:06:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mp5bH6h2; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699261569; a=rsa-sha256; cv=none; b=cP9Lg5+RFek2y4L2XQtx+hUpbVpnyDdhPyKQUntCkG2LC19lFywsjroiOpJq3mMCUgkeTQ V+a55Gvavd+QhfHfB/GopZlYjTphwfEh4NOweNnVe8KXGRg3o6rgE7D2V/4OEf17qduamM xWCUZzrLgyvuxeBd+tW1p7jwqz6N7LA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mp5bH6h2; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699261569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BYBy2dNMIY24Mhy3u9xmGG7Mw1UOwwSG11VPZiqW4uI=; b=wpdOp8ltX4tWUYel1GsDUOL7Kvi87Ob5rS03Z9eAn85el+9zFgxPLLU4+rbP27pW+lLiLd 5miZ8/ju9Jzc6C+Bhvt+Y6GyvrCRerDXYYOAEBrvJFsImKJdVYiHUnt1At9TRHe0+8V48O cMu9J5kyOZpVSuejRgAv8IKAgyHQvAM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699261568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BYBy2dNMIY24Mhy3u9xmGG7Mw1UOwwSG11VPZiqW4uI=; b=Mp5bH6h2MYEoxrM+EEl8PvRryuG7FceibDAa2Y1mDMwaGNYhyAsfYyJX1F/BfoPoeW0/w3 APKArQkIN2z8wpgEa+5Hwnr6mgijaKM6RbWoqDRPBtVdIi617HTNX+XzMxOOJTUK+2ht2c H0rke9+kIgG/Bbu8KfW9epUZuqPS/CQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-OV9mfRBaMQavHOANU9U2Vg-1; Mon, 06 Nov 2023 04:06:07 -0500 X-MC-Unique: OV9mfRBaMQavHOANU9U2Vg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32da39f7f2bso2311569f8f.0 for ; Mon, 06 Nov 2023 01:06:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699261566; x=1699866366; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BYBy2dNMIY24Mhy3u9xmGG7Mw1UOwwSG11VPZiqW4uI=; b=nfmD26yeiT++QFhKIBBE2DhGQ7M1b/+hgLnoz+s0BN2OjJG2CbwNYm2Qs/nsEWKpjc BZigKcO9bNzsGMF9chzEvAimAzXFYTpUiMz3lvMR1zbUYMJWifFoYMm4CZlB+94I/9hv dufByWM3OZBloQ1BL3FJ+QblIf+Dp+ICdOJ13t5nlSEZossT+eDwFqIyLksaV2Iw4rjn XNVVJpNTnBL0f3IDwXaiDCMMylnEc7vBfT4D63JMT7CofvXuWL4SktNdsPNMB8tuC5oP TGwH8AGnpdJnjeuVXHFQbzuQJ789bXWpnhtJVWC7a+nbQbjGQDdUK7oFdQw22oAgWmt3 l+Ww== X-Gm-Message-State: AOJu0Yz9VmpGXNSKOtmbaOe3XZYoKhCRrV+nZPaWmHsTM6j5hpsq+Av/ f8obSAPHAwo00HET1wjxBKhugcfP2hK2wRMaWaTPvx2hBA570wR1SMw2D2dBq4UnkswEhBH17iE Erh16FfZzmh4= X-Received: by 2002:adf:d1ef:0:b0:32f:7db1:22fb with SMTP id g15-20020adfd1ef000000b0032f7db122fbmr20855283wrd.28.1699261565916; Mon, 06 Nov 2023 01:06:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHA42wJ56gmu5mh37nBffHnBUHylTAE96Top/AGloCfZiYJqwhNEp91gKpy2mZWZgvDqRsgjg== X-Received: by 2002:adf:d1ef:0:b0:32f:7db1:22fb with SMTP id g15-20020adfd1ef000000b0032f7db122fbmr20855255wrd.28.1699261565420; Mon, 06 Nov 2023 01:06:05 -0800 (PST) Received: from ?IPV6:2003:cb:c723:8300:17ef:a8f2:1ed1:81e6? (p200300cbc723830017efa8f21ed181e6.dip0.t-ipconnect.de. [2003:cb:c723:8300:17ef:a8f2:1ed1:81e6]) by smtp.gmail.com with ESMTPSA id r7-20020adff107000000b0032db8f7f378sm8929587wro.71.2023.11.06.01.06.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 01:06:05 -0800 (PST) Message-ID: <71d7ba18-8784-4b1c-9797-6fee088fa684@redhat.com> Date: Mon, 6 Nov 2023 10:06:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: mm/debug_vm_pgtable.c:860 warning triggered To: Michael Ellerman , Anshuman Khandual , "Daniel Walker (danielwa)" , Christophe Leroy , "Aneesh Kumar K . V" Cc: "David Beazley (dbeazley)" , "xe-linux-external(mailer list)" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" References: <87sf5jqutl.fsf@mail.lhotse> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87sf5jqutl.fsf@mail.lhotse> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 337601C0008 X-Stat-Signature: 361bpaahidg68tcm9ptapmnphw9bnpw6 X-Rspam-User: X-HE-Tag: 1699261569-277663 X-HE-Meta: U2FsdGVkX19uM4WuwVLSlF9jC2yJa1yDaU48dSD96aEd043oLHhqQU5LjMRX0UF/zKrOES422ObvdvR8AgQCqx0DMZ9baxj8Kocygj4d+bd0IU/SOjaiPQNaPwWjkRCPU5ihhH4OhMHiHR7YVGkm9EjfIhqXPgJ4iVcisYhe6XiheB62JqH0YUD5+DKfk181zSAYKookhxfEbni6YhjW/+om5slXDnpI+6cw+oodgINWUHtDkdWepnC+WmVBAzG96Yyn9InnulY2pcwPI3pB4XrZGv7pbYHXzUJlL1dTTxQT5xlBW02Hmlv3NcUhJcItZue2Acu2krHU71VzVKriGA0AyAEwJPXY5aJYE3vrcDIU8rTeIRoWyMQdcP2pV0PYCRKJdS8TDf6u0DZ/uL9VCi0DzUeSgHB/xVvxud5WppU7cXnMiqjb2IXmymnCYouyRNaDadAXNBwhQOHZqpsx7EB59NYeT3SqhrFhky8HPplrMGC8gm8huUBW1KxnNuakZW17jDMpv+BW8w1qqkm2nWjj3r0b5GasYcXoYvPai/T/1PyIO/bVckByUNRNuQNenp1U0C/vuVgcEG/a0Q5XKQ+D5sxJvw+z7L1yqglhobaGSGKKUwVVm0jtIH+Le9MzKouzkEkUB+c8FBqWaL4TxsqUjh1/t/icohi3ro9YRIOHfxK3z30bEZZ+idCKwijFUasUmcBr6qfPGwNkHQ2szS5k3E/cMnoI1bBrv4oQhfkPgchwchuekGj/O0oFltcN7MkreIekIiZw40xgaM7uimCjHU48sMWSZDpsFbOvPEqzMEeXxymxZbwdgnFRp8EsimWL6OPhjpUZbwjlgs1dlzeaSWb1mo+h12+QeTs+i/5QwSuBHlacNFys5BYCWsVpXue558pf/QmWFO1Peu4fIrCf1e5c2TMgOS14xLjYFhoNiDuP7ASHF1Mxtfsq4phvRfV9YJsTAj/qCc1RPHt KZy/YacM 5iHFT5dZzHFDR13qSdDgkNXWUY5PuhgxK/jdr09wOlbu2TQgupsS/lHs1jDW4ASgu0b1eJAyOCVrjZqRU5LagOGXW6bd8T3KD8Yln+co7YkNYeecZbFJ+XpKIhOf7/z7EQxYhFZYcwo9IsfmMYeyntgZ/tBFaZ2iIqvrqBVKphIhrfM18LXLWXNDNVohGlKNdAcQTCfYkbEbUA2+VwjAoRzIGWXgTeoCzTnZ068oqwsamJt8ARlRDqSedsYzyys9cHj+1U9aOwH9+tRwEEi15sSPJnOt/10REW6C4zCjkVGCNtLsIcZzOR9sETovHR2MqjXhTQMgtoLDS8G5ilfAzgx2gbBd1H7zyYGHbzrG4Qk2vadGynVS0j4IfFAmS3+GnKTbt94SRrbFLOjg+1UVYuFzzQgSSBjrVTOsMsjKXUfgeV+mqKKuHsTaCkLkSr8vWm5MEaUuCrIpqcilgpg1+ZEOvcunsg/hY5TICsAe6zIvkVjIQ1QiWeEOb8HTNo5vj2OwRpXd0asjurv1AhGhMKJENRVbtRCKKBqnO+lzKuPshYBZ1YMhLRFBB5HQ/peY41B4Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.11.23 07:06, Michael Ellerman wrote: > Anshuman Khandual writes: >> Hello Daniel, >> >> This test just ensures that PFN is preserved during pte <--> swap pte transformations >> , and the warning here seems to have been caused by powerpc platform specific helpers >> and/or its pte_t representation. Adding powerpc folks and platform mailing list here. > 32bit swp_entry_t with 64bit pte is supported by making sure that we never store a swap offset larger than what we can actually fit into the swp_entry_t. There is common code in place to handle that: see generic_max_swapfile_size(), which does to conversion back and forth to see how many bits of the offset actually survive the conversion. > Doesn't the test need a similar treatment to: > > 2321ba3e3733 ("mm/debug_vm_pgtable: more pte_swp_exclusive() sanity checks") > > Which said: > Especially, the pfn_pte() is dodgy when the swap PTE layout differs > heavily from ordinary PTEs. Let's properly construct a swap PTE from swap > type+offset. Sounds reasonable to me. -- Cheers, David / dhildenb