From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65222C3ABBC for ; Fri, 9 May 2025 09:45:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6A748E000A; Fri, 9 May 2025 05:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1BA38E0007; Fri, 9 May 2025 05:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B71418E000A; Fri, 9 May 2025 05:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 971438E0007 for ; Fri, 9 May 2025 05:45:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EAA31120334 for ; Fri, 9 May 2025 09:45:52 +0000 (UTC) X-FDA: 83422887744.23.3143385 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 7D0A014000E for ; Fri, 9 May 2025 09:45:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LaftQ3gq; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746783950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bu/8JLoeCoD1WqiQs57tUFU7TywIqe2UBHBIdfA/PFw=; b=D3C5QNyfRy28YCyw9Ix978oq50EU3e/l6waSEI4hralyzrBRsWglv4nNVhuLSA+Vp0xe8L 9lBwH5Z6fJR5a5kuI2ZAnv6wBoW55Xeyd4yFW2bHsp3XX9iG2QqIOfrpPnuXSJVKwtkdOP LwmeNnCxUjtQrzFIGqaF9OYahy8K0PE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LaftQ3gq; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746783950; a=rsa-sha256; cv=none; b=hfcH5qzqTDSo2xo/T1FsZoMKgyBms/1WTXx0z6QLI9I8LJB2JLJEIIV9ov9XGCRjVlXHQK ua75qw8wAn9ootMLQ0Pz5/FjZceWqnyPmRKGOxKFBKN4ZjDLlJAXhtEDS03O4B1ZbH2v9y Wvv6xeFRnaUyQpMe8s9K4uw0qfJSHNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746783949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bu/8JLoeCoD1WqiQs57tUFU7TywIqe2UBHBIdfA/PFw=; b=LaftQ3gqOIa1pP7jFHTYydeeicaeRwXnkwLXvoP2s+eC24VyMt8B+VPvHxlXnHXCcvZoeq WMpDjIAGellg8LP0Oj1ESHLwkf0ViEYgMQwKovLZtSxim38tJ4nUVsXazVQUBW93wKgKVM iUnimrrpvTL2ajaiSiwPjKLjFAVqG6M= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-dizWnnvPMo22COUYsuwT5g-1; Fri, 09 May 2025 05:45:48 -0400 X-MC-Unique: dizWnnvPMo22COUYsuwT5g-1 X-Mimecast-MFC-AGG-ID: dizWnnvPMo22COUYsuwT5g_1746783948 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39c1b1c0969so1148144f8f.1 for ; Fri, 09 May 2025 02:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746783947; x=1747388747; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bu/8JLoeCoD1WqiQs57tUFU7TywIqe2UBHBIdfA/PFw=; b=YhAmcq69WmAjeq5h6CqosAgbIPPN5r5K5Wkxgv/JE/DiiRS/qn2jcMdx4xKzKV1BpA aVxmdf1YqHXnCwLy3kzF0gyBVke/tpEYmUVtDYnHZ1Gjnt8vZk2H/Pnxk7BDdPKJsZPA ydXGghZ1F5xgjaesF5Wyv7xTWb5L08PNxe7gUz0jlEvaztDBKepZ3Wx5XchiaW4Pbr6+ pd+t7Qk00nXw4ziDhyANuYs5cCURMzvyyaEvsaCy/mAahR8pkrVyXJllNMYMAtB8EYaF N2+QQ5h275jMAJcQGG+hB7HHOkq7mroIwFq6L1g6352cVDCYEcN7HFc7HpsTybUhvF9f G27A== X-Forwarded-Encrypted: i=1; AJvYcCUABmNBKqCdxes7UW2s+D3r+kUgcDFpSyOCkMB7JRnJo6/C6/iUy3YDM5zSDyt1GDr+HjHZADjFbg==@kvack.org X-Gm-Message-State: AOJu0YwoVIHsn8NSMPVJsLmOuGqBGQyHHhZ6nEAdbnUyZMPXXcSUHuRR sUtlAAFwl2/DWfe0Z+03U/897TNN3I6Voj6HEmUMHe2eb4asnccmWARKwcd/9rQvQFFix2ZeM2h vGMX2jVeehTgo4ttOT/iFlaYbs5qRxiKV2qyAdjREdQUOa5M/ X-Gm-Gg: ASbGncuLWUjwne9ND5bZB8+ECRNvZn4WX8Hm23IffD4+oqP/DGcrip85bT3TwHJ99xe rfxml0oAodOdJJPLqJrHEYMZb66kEjru80OlnQmI9lfw8wKga5O22qVjqPEJ5YAzdkPHgxUdJKw ab3gwD7SYQ17YfWobtl+6pgzJpB1HGAv9lIYakpTRnhdrisCpbdJ9ImObcvAAp6U6reZdgZMPNs rwnXBwcneaq9ClVvLS1KqoaEjDQ5jECmyeAYBjaFaYq982wVT0odZPBEqumFKjQ7+Si1YTFeT2r M3X7Fxv7QK/Hnmh+8r5/AkpbnhXUvU+IcTu+xKZDPRtGHnMwVMYw5ingJ3UJRl1zqcCwRexGaDh Mdfmg7GxMl+8RwhE2JVhbAPdLpgSadlOWAcVjizU= X-Received: by 2002:a05:6000:3107:b0:39e:db6a:4744 with SMTP id ffacd0b85a97d-3a1f646d9abmr2212123f8f.32.1746783947558; Fri, 09 May 2025 02:45:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqWyAH3LOt/3cZP9Rvihrl0+ejLa3IRZjY7TLv9wiabkFRe6nuDbo+0JpbmOS1yW5BiT5eqA== X-Received: by 2002:a05:6000:3107:b0:39e:db6a:4744 with SMTP id ffacd0b85a97d-3a1f646d9abmr2212107f8f.32.1746783947216; Fri, 09 May 2025 02:45:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f45:5500:8267:647f:4209:dedd? (p200300d82f4555008267647f4209dedd.dip0.t-ipconnect.de. [2003:d8:2f45:5500:8267:647f:4209:dedd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57de087sm2762774f8f.16.2025.05.09.02.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 02:45:46 -0700 (PDT) Message-ID: <71cb8335-ad53-409a-b947-d7ded8a3ef02@redhat.com> Date: Fri, 9 May 2025 11:45:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm/vma: remove mmap() retry merge To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IkJqkvnCfrTciFQSvsqGl47cK4MpggMEVJt1ZsRjP9o_1746783948 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: pw7ifn4m83k7irjon4nn15pqcqwrsxs9 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7D0A014000E X-Rspam-User: X-HE-Tag: 1746783950-780331 X-HE-Meta: U2FsdGVkX1+UPos0BUMb8ZbvliDGWT4niEs0YsYSZMDzgwamwqT/YLGu8OWKKyEXlLvoJskU5GzOnwgQkj7TYQ32wa98D/6y0HN1a/+aL/hDJmHaLckpVHgw0x2H397VSLmQJYLJEuvRN6niRoEkm46bfK0WTLtMbSWyjibTAoSAnAI+iiuG+smyyome6j+bkb31OUbvyWu6bDuu4Wc8bqotfEzGz5cKYK4IWOB/C/8WkYo7Voc/hY2F+wNIcn7i6BViosTmg3CxlWatu5lrpVvVD3vbEXpTf4IkC8Ie4Kyuh5R3rx2zo7XfdFDMdZLca/jTj9oF7QRV1II23aHDJ9apRrs2UnuEZOQqNgAzwUNpwvIw8cyEaE1AwV+x41wIhB+BVvP7k5JobRYiJbu2MCVdXIs3T1lWTI3k2N/6+f+KZusncds5NUEOgR3q06lEsCTzuRR6sZ1mVXJSvifrVSM8sEFAHd90PybVsySsYtqiPsUu987vpKeCeVIvbEwYaMmjhtX2iXsG1XDYq2MaEl4IdZ7/joGjWKXhTnn+hp0/eQjl0fCL9DXyN9uMgFuwRy1y60SoGeHrLiHTokO0Git/X82iBcuwAluxWr6TfDcz8CyMByKbN7l2dBYYWnhiM/diH2dZOk3DaQ2E/Nyt6CmyYVvYmNFdTMOstT3gHDCyfoUgDPoiQ/Iga9Hw83LnVFMZgk/8Pbp06tNU7wxCj35eIECU7nvAbTp6s5h/wGCZo703HmGmwyoUhRpZf+J5I6o/bxI1KxqSXWstlAao8GXNrZv8dpIgwOvDrnPdr5Yl42F+pKUaPSomYE6a+Kt+ryVO0HEaeumer+Bh39NzNcUDqXo4M3oLc52or6/8YkoUiRuoqTrI/96ySdp9gOQmqBCdf3BJ+Xb/tB7v/I01xdWS3XpjMtLZkt6TILRkaQLEYQho8lIE1NidyKKhMFJLOw+0tmxKysTP2fFRZbo faupK+Ug e4anLYuEUSAb1cgw47iNuRU1DnQbUVs96c0T7OvDAa0p0Ve31OmxXR/au0wTTXtPYzVLN9zwPuVowHMcPUXKE+tO6JITT1/3fG10f5NnLrF0n+wD5ccJgZMHPJQ5igFkVuJCJ3YBOKhpycW2MlWazeztllLHxrzOHAoKi1z6ozHRfiMoM0yIX1PrpfDpmFIoHyY4iaiUTuTBEOP4mPHDVILJiq9Mk/QAZHoivz8Fn1NCuuUVCJWoiCBeTfXD5iyQKX0OPGm0Q/TgRAdxUp3tfzymzFjNQwa8/5mWVY0lr2lDGVGrruHe14j0lkdhr73MI4yFLs6ir6rnQ3+2MVSrfDOUeLjiqsDhR3jmKviHuuqinaYLnHyasY4hs08nKo3l5cYrcoiKnk5ZNJiOjKVEbPZ/8VyKCuBnxvAzFX25j/AViJs7y7pSKilFk8uftfZJ+Jyurj+jPixIHimo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 13:03, Lorenzo Stoakes wrote: > We have now introduced a mechanism that obviates the need for a reattempted > merge via the mmap_prepare() file hook, so eliminate this functionality > altogether. > > The retry merge logic has been the cause of a great deal of complexity in > the past and required a great deal of careful manoeuvring of code to ensure > its continued and correct functionality. > > It has also recently been involved in an issue surrounding maple tree > state, which again points to its problematic nature. > > We make it much easier to reason about mmap() logic by eliminating this and > simply writing a VMA once. This also opens the doors to future optimisation > and improvement in the mmap() logic. > > For any device or file system which encounters unwanted VMA fragmentation > as a result of this change (that is, having not implemented .mmap_prepare > hooks), the issue is easily resolvable by doing so. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb