From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1B4C369D9 for ; Wed, 30 Apr 2025 14:16:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7B076B00B5; Wed, 30 Apr 2025 10:16:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E01346B00B9; Wed, 30 Apr 2025 10:16:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC72A6B00BA; Wed, 30 Apr 2025 10:16:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AEEB76B00B5 for ; Wed, 30 Apr 2025 10:16:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 017F6121B81 for ; Wed, 30 Apr 2025 14:16:16 +0000 (UTC) X-FDA: 83390909994.27.9C22F27 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 36216A001F for ; Wed, 30 Apr 2025 14:16:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746022575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q9sGMxkfhSmUxYY9kPs/I9g0L6OY0L2n8uvV0LMHmBQ=; b=q/FSonUE690mWXnm/2L1QnSfWB7eH6bbs6uYIYM5OOkykQsVFXgueftmtZUc7tXYJxXQp5 D91IwbMUJGrcTbhJF337tkGsAcQovBkCLH8xbnBxHMIVn9HR5jGN2vzZTyHK2FEKoPxrUU MI8JP9FAdTnrspK1A8mnnjTpa0u8kac= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746022575; a=rsa-sha256; cv=none; b=ii6MBjK7+1j9TKmM4LJ9CgNVBeqcBaelBwUtPY9b79b3Jx4q1L9gTupynwOmTZDwqUkJ5e 5gWTnClMQbt+e9/jplGmLHSRU7rYqI/TGu+qIQLRX449JHlpQwvSMxn3FyIU+F8ZyS1jKr RZYQ3WDLcAvDk0xyUuyptIwHP2auYhc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 035EB106F; Wed, 30 Apr 2025 07:16:07 -0700 (PDT) Received: from [10.57.84.121] (unknown [10.57.84.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C5B03F673; Wed, 30 Apr 2025 07:16:09 -0700 (PDT) Message-ID: <71cb77b8-c4b8-4d63-8b59-105440527c15@arm.com> Date: Wed, 30 Apr 2025 15:16:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] mm: Add batched versions of ptep_modify_prot_start/commit Content-Language: en-GB To: Dev Jain , akpm@linux-foundation.org Cc: david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <20250429052336.18912-1-dev.jain@arm.com> <20250429052336.18912-4-dev.jain@arm.com> From: Ryan Roberts In-Reply-To: <20250429052336.18912-4-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: oghhiatwe6skjd1kk7gdrha3bxi1x5u1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 36216A001F X-Rspam-User: X-HE-Tag: 1746022575-714456 X-HE-Meta: U2FsdGVkX1/HpaLDuPXtX1HJq5cFAZVkhDQllUwpLo0ksr9OdQoQFqC7mN10GeER6TBo4ogPkrkJUZ1zyQ/tBAaDoIu+SRx5tEsYJ4B13aCMRd0ZWxK3BTty9pALsL5CB6Suktg7a6L6Xpi9YWdPYCKFU2dKCLjvFHVYapmeQacbjbU+R0wMcoRfwbHBFxzpmcFBJziRFtNoky3/f6MN27de4qW+SqbetXPU9e514bcyxROyRvuxK0EPWEAWGCdJE8sx/MX5WlDnksKPtaqIw473J95++lMmATwo1uYfUcleNINbzpCdwIYDwwXLb10PRaGQLw2Tl/LaYChq3k4ST98EHlgJKeOXwZqe72EosbeqSeOCXxm97xi+TFCcZJUbdyUNp01c1DXqGvjc6JBbPZ07ebj9ot3omRfGmAMX+TNlCcnxD6kwm1feszjtJ9TsaG1ER2j6tWHZ1fyYwPRnKBzjF+FOSbpCKaq31OkuC4g6PRvRoWyHHoIiQOxPiLf2CvHKnrT+dUGaVPGPwTgePKh92kTX21KX2EBa1/6GleQbz2+PONesrtjwtWIKd9r8XJgkdDwULGwYcSu4pWDiNq0cPhmwfoXtf6PLlyKk26mh2CXWdj+LVjET8CT0MFIeW73HtXdT4YIr6rc54WaDT7sz22qjq6+ZHl1ZW43Ve2SaCyH9n4mzHLQq/lT2KLBiEZD0Lvyate/APMC5K4U2Irff71/ODGzhuDvhY2MnQU2pKg1JQH7210OwifCrfd64bVGvDFtRXrv76PtDDbasXC+AqE+Wj1Shr3IKfcmAIzXrxhnH+AoI5298Ag90x+4xMRzaZo3dy1XI8/R55tHXJBtYkm+6NBvxAn6YkJNhDYERlchqjQrtLk5pQiYifx+rQ2ajg71ZAZojXy53pocr4Sh1kmUkXmdvid5GNrg1chVBmNbdThPsRjPFPtIDyvoQe/D0mSuak+AN9tPVeuf lk3Jd0Hy bJ2br+ArznKH5rl/1r1Ql0rpM9338uYDfQElgTFP5VJHsZoI0PUpBXoNhGjKfHvL08Z8N/AUxIN/0AMiKl0nAybdEY6GRREnR5/EMjBMWjJnTbpoPRpW6ooPIwTfzM4n+n/lHTl+UuNBDoJtya4qrIKi5qF/B2t9yw69vcqPwKX062G5QQcuKzvB2b9iIZToqA6gw45kHl29XopAQ8gkUef5R9JC4S58TUF5hDiuj92F6CurEPZLsUeFgcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29/04/2025 06:23, Dev Jain wrote: > Batch ptep_modify_prot_start/commit in preparation for optimizing mprotect. > Architecture can override these helpers. I would suggest merging this with patch #7 since that's where they actually get used. Then you can add a single patch after that to specialize them for arm64, which will give a performance win. Thanks, Ryan > > Signed-off-by: Dev Jain > --- > include/linux/pgtable.h | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index b50447ef1c92..ed287289335f 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -891,6 +891,44 @@ static inline void wrprotect_ptes(struct mm_struct *mm, unsigned long addr, > } > #endif > > +/* See the comment for ptep_modify_prot_start */ > +#ifndef modify_prot_start_ptes > +static inline pte_t modify_prot_start_ptes(struct vm_area_struct *vma, > + unsigned long addr, pte_t *ptep, unsigned int nr) > +{ > + pte_t pte, tmp_pte; > + > + pte = ptep_modify_prot_start(vma, addr, ptep); > + while (--nr) { > + ptep++; > + addr += PAGE_SIZE; > + tmp_pte = ptep_modify_prot_start(vma, addr, ptep); > + if (pte_dirty(tmp_pte)) > + pte = pte_mkdirty(pte); > + if (pte_young(tmp_pte)) > + pte = pte_mkyoung(pte); > + } > + return pte; > +} > +#endif > + > +/* See the comment for ptep_modify_prot_commit */ > +#ifndef modify_prot_commit_ptes > +static inline void modify_prot_commit_ptes(struct vm_area_struct *vma, unsigned long addr, > + pte_t *ptep, pte_t old_pte, pte_t pte, unsigned int nr) > +{ > + for (;;) { > + ptep_modify_prot_commit(vma, addr, ptep, old_pte, pte); > + if (--nr == 0) > + break; > + ptep++; > + addr += PAGE_SIZE; > + old_pte = pte_next_pfn(old_pte); > + pte = pte_next_pfn(pte); > + } > +} > +#endif > + > /* > * On some architectures hardware does not set page access bit when accessing > * memory page, it is responsibility of software setting this bit. It brings