From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41920C61D85 for ; Tue, 21 Nov 2023 00:38:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970B96B0374; Mon, 20 Nov 2023 19:38:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9211A6B0377; Mon, 20 Nov 2023 19:38:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E8C06B037C; Mon, 20 Nov 2023 19:38:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D60D6B0374 for ; Mon, 20 Nov 2023 19:38:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 22EAA1A09F0 for ; Tue, 21 Nov 2023 00:38:56 +0000 (UTC) X-FDA: 81480101472.11.7BB3CC6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 372BD4000C for ; Tue, 21 Nov 2023 00:38:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cY3Az4cq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of "SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700527134; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/yQG65p3mrcq4/bnK8tkFfM+zDVrbkpApp8K1lo6dI=; b=nbhVdoB7/MGTb6s09WK1Oic3OsCexiTyMTHmDHPuVSe1gKA0HgCz+9lu1Pr9Oixa8Ggwxh UDcPtXwK/U75M2KjWqkuvx6tlBs8RSoESCP0iIadlQhVkuNZgrZNq928Goglo3x/fFONMm zfOe4EICoisFBefvftxQbTS2BmpUkwM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cY3Az4cq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of "SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700527134; a=rsa-sha256; cv=none; b=Vp7JYtfd6CAf5Lsd96k9OIKPUjO+K0NZ04npMIlL/hZraKRiBLQ/rfh1gwjQ8K7TE7p+V0 txC2OgPfioLJjH93HS5rlowFA8LOUJ0FuwcJjqQRYMzuZ11aBbuFH5+JeSsHwarQNl0Jij VGbE5acsakO/Cv9D1ako96Np6qcKxto= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 48388615E2; Tue, 21 Nov 2023 00:38:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E70DFC433CB; Tue, 21 Nov 2023 00:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700527132; bh=Rdi3fgN5bNqPzN6X1N6jg3BAkEwpO3di158/L11Dhe4=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=cY3Az4cqVXdlbO3a0lOi4XTNvTFTfbfh1P5F6QRWXyiiNzxF5v1+jF0NZfqE9tCz0 N2XUMaazXkK1d1/nxObrUEXy463/lN04GDVmVj28lEH87XS3ufDkjiPo68xMvYLr+V tT2IjO+eV+ANYQzT8tH+RG+LWCin+oOkRpIZ6n4hFO2HoMeW0jvVbYUc7afqqWkla5 CHSd0AASfPmk/u3wFkbzFBQ6o2hNgahnnqNOPxo2ATqMSrMOPdh8Ns0Ue8k8pBjKVX gLXcTB62uqw3ig2kOSBW8q6K/rX092i/67JEidzY1Ak7uqm1RVUWrPoiOsU/NKBJVh SS9W2jvJG013Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 9E905CE1390; Mon, 20 Nov 2023 16:38:52 -0800 (PST) Date: Mon, 20 Nov 2023 16:38:52 -0800 From: "Paul E. McKenney" To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 50/86] rcu: TASKS_RCU does not need to depend on PREEMPTION Message-ID: <71b83b93-dc68-4c71-972a-5f0ccc3a59da@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-51-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107215742.363031-51-ankur.a.arora@oracle.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 372BD4000C X-Stat-Signature: 9oqjeqxrmguemgq8jdnpwbryoi1spcpo X-Rspam-User: X-HE-Tag: 1700527134-967599 X-HE-Meta: U2FsdGVkX1817yrbT4h2sWnyFttBBBd19eo/FEjeYtcKW/QymgpkMu09zTYxDos+AF6OzxoDEih3hPRgYG3kmy3TE/c+DdigLaOy2HI32/YOXS1IJ17ZzfGtZGuR+WBEFm+okwh4AcFdd+Q0ZFvLMgkP/7rAFs1N3/jZVsmPqdowh8ySKxagBoYfqA/GLW1lO738ZwzYtKP7F99ugUgpaLPYoxkwdoqVqY/kGptuPvY90kDNAT2JAFNEBtuTMykmUUQKxB+sugBQFtonplq0Kor1t783hLY78xCFqOv7MN4B7V+se2RRMrb3PJiBhS1hubbBQSoLyKKaRbX/bJH+P552JEv4XUZp1zMfIKpgMlCIjMuxt/0GNX4fsyBtQ+ah5GBdOKf0rLYQywrk5ZGnI6sn3Hf3Rz+TYkbBufoCEvcg6GSdC3D2FQP1XyUc/J+JZmcjUSzwDL0CaPdjtp2yynd7NbvIVCzaMzFRYd4pNyrAbpp1f7KdilY5qpE4q72j3x1MaPZZAK2OVV8c7WDATZptA864EXMQEP7zjAyy6x/Hnt3YSylk95kghlt0oJi3kC6oeyDV/+BVEhVBCTMMYkkP+FAd3775rsPQkpM7gbP3oEfD3wp1W+seiW57A5PBKBJ1xqJi3xy99AWsaQLiprnBOlVOhqKuCHb8LBJxC5k9RRdRewwayHtB8RFfCH1lUw+nvM1xFKYGvor8FwOx35ZPiCWwhIAziAMwnjJozz7jYV+ahhu9SnCctXvulFPCya4PCLadUy/RSw9EV9oX7vU3vFCtqZ9JRq1vTcGiVIgntoHin/CQFWF48f5SGXvkJC7qEnhsDdkCUaK9utBcQgKK6RCm7tI934zkVYZqLLXCUC0LcDQ21Vm6WpdrVfEKJC+6OKKC/bODutaxWs1MIoxFr3kh5Q+O5sF/b/IS3X4ysxaufJ+kc5OphWyDE2RXYDLiD1bIGcvezWXqz3t ui98kKdm gLIQBt2n4VHOy/BzTT27/iCLSdOc+ZfQFIuOpJaFJRaB2q65a/a7MSXEVcALhAMabxsSIm8+zn117XDP5pQ25YlVtU6hD/w+BLLSWQCuJIFQfoilvn5p0RNuOStIDODzbBlxQmDgCiXBf6rxfiyNq9Ul3ah/gYkzOCpthF9tN2OoY5e5JI8Ue98vVllxQ0GdZEQWtZy7Go4gjhmRmWy28TkmXtPbXusX5GZzS4XeR3fbY2PUBnKZ4JBi1gihgvVTObScjL3/BmtpwUIBUIBeL+5X9lMPDOj2zP1aXNwolkykpdz04z/xcnbf98i+c7nv2dCyb/tw6PpSq66oKUSxJzbL4YDbKKNu2BtEicFRW/aPyVXlst/LG6RkUEgcVNIw1Wv/RedKtBK6tyhNBLUCx3BAvED7LquRIKbTiHv0ePXwg1AHf21N1lkAD1Hai3jACyez7WtPWtIuXHW+F591XaHTLkH24+O83d1sAMrlv0IXGZNrjS+MCxoSVLiGmwu29rm6sfdAA+t6jKDRwan9a9YBFvRun1gWe66NxG8P6AfbtMMsIP+UYD6XkusKKrysz+B917H359XDkiekIf8WtNZhHSSbDIc3sZeIqKHX6Wx0/Mewn99Hf8D/cHLiS4Rk2zdbPFx6NIohMaOyq8dkBWIluacj9j/6F4b2DvZPXMjdy81FSoMAWSVsLzy6Qe6YPrc74ZaHFtERRxPor8B0mvb0Og6lXT22GX63gX/ES4gVxasX+GDfRpeSLbqYtbUJiwZxI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 01:57:36PM -0800, Ankur Arora wrote: > With PREEMPTION being always enabled, we don't need TASKS_RCU > to be explicitly conditioned on it. > > Suggested-by: Paul E. McKenney > Signed-off-by: Ankur Arora Reviewed-by: Paul E. McKenney > --- > arch/Kconfig | 4 ++-- > include/linux/rcupdate.h | 4 ---- > kernel/bpf/Kconfig | 2 +- > kernel/trace/Kconfig | 4 ++-- > 4 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 05ce60036ecc..f5179b24072c 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -55,7 +55,7 @@ config KPROBES > depends on MODULES > depends on HAVE_KPROBES > select KALLSYMS > - select TASKS_RCU if PREEMPTION > + select TASKS_RCU > help > Kprobes allows you to trap at almost any kernel address and > execute a callback function. register_kprobe() establishes > @@ -104,7 +104,7 @@ config STATIC_CALL_SELFTEST > config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > - select TASKS_RCU if PREEMPTION > + select TASKS_RCU > > config KPROBES_ON_FTRACE > def_bool y > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h > index 5e5f920ade90..7246ee602b0b 100644 > --- a/include/linux/rcupdate.h > +++ b/include/linux/rcupdate.h > @@ -171,10 +171,6 @@ static inline void rcu_nocb_flush_deferred_wakeup(void) { } > } while (0) > void call_rcu_tasks(struct rcu_head *head, rcu_callback_t func); > void synchronize_rcu_tasks(void); > -# else > -# define rcu_tasks_classic_qs(t, preempt) do { } while (0) > -# define call_rcu_tasks call_rcu > -# define synchronize_rcu_tasks synchronize_rcu > # endif > > # ifdef CONFIG_TASKS_TRACE_RCU > diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig > index 6a906ff93006..e3231b28e2a0 100644 > --- a/kernel/bpf/Kconfig > +++ b/kernel/bpf/Kconfig > @@ -27,7 +27,7 @@ config BPF_SYSCALL > bool "Enable bpf() system call" > select BPF > select IRQ_WORK > - select TASKS_RCU if PREEMPTION > + select TASKS_RCU > select TASKS_TRACE_RCU > select BINARY_PRINTF > select NET_SOCK_MSG if NET > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 61c541c36596..e090387b1c2d 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -163,7 +163,7 @@ config TRACING > select BINARY_PRINTF > select EVENT_TRACING > select TRACE_CLOCK > - select TASKS_RCU if PREEMPTION > + select TASKS_RCU > > config GENERIC_TRACER > bool > @@ -204,7 +204,7 @@ config FUNCTION_TRACER > select GENERIC_TRACER > select CONTEXT_SWITCH_TRACER > select GLOB > - select TASKS_RCU if PREEMPTION > + select TASKS_RCU > select TASKS_RUDE_RCU > help > Enable the kernel to trace every kernel function. This is done > -- > 2.31.1 >