From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4938C04FFE for ; Fri, 17 May 2024 06:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 448556B0085; Fri, 17 May 2024 02:02:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D0736B0088; Fri, 17 May 2024 02:02:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2983B6B0089; Fri, 17 May 2024 02:02:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 08DDF6B0085 for ; Fri, 17 May 2024 02:02:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8CA7FC0148 for ; Fri, 17 May 2024 06:02:47 +0000 (UTC) X-FDA: 82126843974.06.8D9D4BF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 79B2B14000F for ; Fri, 17 May 2024 06:02:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715925765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbfDHWJNEW9HvuPDjSMmNF8ov3t3borLcg64UT809XI=; b=vRZQERXivaKnd+1TQMhY1zcDpjrdGxmSQRC1w3RWTLC/KxM64WGRinx6i4rm+Gjpby0Amu aClxljt3NOtsqSWNu/eb0H5zhYtj3aHLKYIu45VTW0bIUoDq4GBFre3/pMpUBOezfazgC9 kKvo7BR3WHKZQOS8yfC1IzM7JH/3H8o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715925765; a=rsa-sha256; cv=none; b=haFMXbRJZvJf+AoPqhRoJWI+oru5Na1lMc1sEI8pF8jgrYWLdawkorzgKKzkSQNx2Kt5UT /szBiZLmCMuteOslo4TMvffJk6Em0suvTzVvWa2T0ikYxBXNQsaO8q4d6/gKl0MytHTln8 CvBJTjnjVvJ+0+xIxZXV8SbHmQUAvNQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D3101424; Thu, 16 May 2024 23:03:08 -0700 (PDT) Received: from [10.163.37.42] (unknown [10.163.37.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 603833F762; Thu, 16 May 2024 23:02:42 -0700 (PDT) Message-ID: <71b08fe0-277b-451e-868f-1d81e1b3e810@arm.com> Date: Fri, 17 May 2024 11:32:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: Drop node_alloc_noretry from alloc_fresh_hugetlb_folio Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Peter Xu References: <20240516081035.5651-1-osalvador@suse.de> From: Anshuman Khandual In-Reply-To: <20240516081035.5651-1-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: a7a6rwokzz78rynu5jnqqas457y1t7rd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 79B2B14000F X-HE-Tag: 1715925765-149785 X-HE-Meta: U2FsdGVkX1/dUFnIh6njGxVxJQVDIuRaHJFlGa+XogIfZGabbO9l5gipmDBc3uM2FVhtgMh3h5TGREyqbGJVjeJ5vEls2j+ziVPFCFga8XCMgs+OYkpAGBsuQUqf54mwMdBnb+E2Ga7acwD5yWxRXgdh7lz3r5vfLyld9S4DBJ4+IrrM9Q9sDG88dxKK1A4dGOfDpvBVMIETalP8hb/Lw/lBX2nkujWWYjfJKoNq1E3T5RreWR1drFK5fx1kipdgyf3aKAKXV3Ujq7GarbRnrIBt79buXUXpo+9rhZHWjm0QjLapKtmF21E2FP3A8Hj5tbRpwaT0VBTSE7KsLX90Z2CZFRmI1dy4/zTZHOHhNNdnPSgVdBBzQienjxZrRLU+6PalEAMxUERX4cDHzItUGIuXwfXsVzk3SEnvw79i8rDTvuN8+wMPjooSMYPSJw6tnKurqLmmHt3gjvywhbCBgSFoYYIyn/O7DhbgGxt3cXQjltEa1NcQ173RSajrYxdlOFD2RSIX9+JVw0THjj/5w+heUwcIrysTCAnJ1oSUAO9GP1hFKfSOHnO2dCajPR61Z8gdX6YaKL5au0ImrjeHHgpFmAeOw594PxpQonTG7BbJRBmEUiuAFN3iGAKxFQGv71efvadh+spdXBnWX/aKP/7SMhxrekUdTvprd58ptmdYp8jqKgdfKPHi2RVzFEGtimcaszgSNOKeKRdSHAEigj6EDzibpC9AV2im/0kmhay//BA3psxAn3rnEkN0hCfDWEJLWPdRjanw0/4hMs1qEMio7/eAi4aewdoVZ9BF7PojzLvyFGhYkZ/BO54nf6thQYM8WUtFtiB31WoMxaI/nJBQQLyaX8Cs1evZblxamv36vxgRVrGyucrlfkOr8GX2q7VsL5HBw81CUaiW+uLPo6pLhfJ0nPQF+0m2CIgqOQNpdI1fOlQ/H37IQ+DsicExyYC9uLKHmgD2Zr+eZXi r/8OgZWI wXR1/J8dWVnmijcwLLmUrHecXZMoNVw8ws0WkUcmelTHHiK16tI3EZza7y8dkaJgb3/c10Tamjee5ptJFF59lxTZU1raJSzE1DAl/CxvQzh6wgPf6oAs15Eypyx3wxSfmx0P/o2IXbVgzeQk/4rYYXDaTvZEbMGyIFAZ9yfqe7rycpLfCUzgNNnqB39qMng7Exc2uu6j9fAwajdDi4R24LW2ztJeXt+HH1/8KfaGUnyQV7UNi2QjMLdGGxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/24 13:40, Oscar Salvador wrote: > Since commit d67e32f26713 ("hugetlb: restructure pool allocations"), > the parameter node_alloc_noretry from alloc_fresh_hugetlb_folio() > is not used, so drop it. > > Signed-off-by: Oscar Salvador > --- > mm/hugetlb.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6be78e7d4f6e..fedce00ff839 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2289,13 +2289,11 @@ static struct folio *only_alloc_fresh_hugetlb_folio(struct hstate *h, > * pages is zero. > */ > static struct folio *alloc_fresh_hugetlb_folio(struct hstate *h, > - gfp_t gfp_mask, int nid, nodemask_t *nmask, > - nodemask_t *node_alloc_noretry) > + gfp_t gfp_mask, int nid, nodemask_t *nmask) > { > struct folio *folio; > > - folio = __alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, > - node_alloc_noretry); > + folio = __alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL); > if (!folio) > return NULL; > > @@ -2513,7 +2511,7 @@ static struct folio *alloc_surplus_hugetlb_folio(struct hstate *h, > goto out_unlock; > spin_unlock_irq(&hugetlb_lock); > > - folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL); > + folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask); > if (!folio) > return NULL; > > @@ -2549,7 +2547,7 @@ static struct folio *alloc_migrate_hugetlb_folio(struct hstate *h, gfp_t gfp_mas > if (hstate_is_gigantic(h)) > return NULL; > > - folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL); > + folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask); > if (!folio) > return NULL; > > @@ -3474,7 +3472,7 @@ static void __init hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid) > gfp_t gfp_mask = htlb_alloc_mask(h) | __GFP_THISNODE; > > folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, > - &node_states[N_MEMORY], NULL); > + &node_states[N_MEMORY]); > if (!folio) > break; > free_huge_folio(folio); /* free it into the hugepage allocator */ Reviewed-by: Anshuman Khandual