From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1DDC282D1 for ; Mon, 3 Mar 2025 17:47:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24CC1280005; Mon, 3 Mar 2025 12:47:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FC1D280002; Mon, 3 Mar 2025 12:47:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EB18280005; Mon, 3 Mar 2025 12:47:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E4FE3280002 for ; Mon, 3 Mar 2025 12:47:48 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F63880D6A for ; Mon, 3 Mar 2025 17:47:48 +0000 (UTC) X-FDA: 83180972616.02.0821A17 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf24.hostedemail.com (Postfix) with ESMTP id 8CBB418000F for ; Mon, 3 Mar 2025 17:47:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=aleLwJo1; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf24.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741024066; a=rsa-sha256; cv=none; b=Xw+bVrp56aYdC8U0wKbpQwUxtocRE0+Vv+WGbQocM6V4QPh+CyNWxE8Cb3YfkbZYjhT+KV TbmFGiJNM1uZ4dkLUa8cagoHKHCoq6614mFed1SvarvJtbUv9xdkqDMf2XwdT9yWv9cIZB GhrfGksulgqDFcbocB+0axCGVn0WQWQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=aleLwJo1; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf24.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741024066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6l28tj5apUgSjS+gT72dtU2gZOIbJpHIOU3LLXJqmqQ=; b=XnvdCTvtNCn7CnNRDoUdPIHnjffYhjSHMwaQYkEa1EPHlkkZ1U9Qg5wJrIPvDLR09yRhTf 6ykm7Tau538KslXViQQD2IuQ/MUiT+XMalGypetcAbe9Kh1zqaQYQe6guHGD7PGH9KEuXm yykBtSflj/VaGnsL0wojRW1TgmYzqEM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1741023575; bh=FiY2u3I0Pn5QWdXrH/UVFOT449MBOOEniXOmPNiVtSM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aleLwJo10drgxiQ8VelxmBmtSUDjoYcsjlrw6+qC2RIGoWqcD6WQx0khgwFHRp6O1 ErIsghXIVgcf7gycpWmO+SYJOofkK4Hr+8/oePSe32M8E0qa4G9QUB1Owa4XVrBpBa GWgO/g9QxyYmRgd2796+ILlhX36WhVMbCp43P9mo= Received: by gentwo.org (Postfix, from userid 1003) id 928C5401E6; Mon, 3 Mar 2025 09:39:35 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 9193A401E4; Mon, 3 Mar 2025 09:39:35 -0800 (PST) Date: Mon, 3 Mar 2025 09:39:35 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Lilith Gkini cc: Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, harry.yoo@oracle.com Subject: Re: [PATCH] slub: Fix Off-By-One in the While condition in on_freelist() In-Reply-To: Message-ID: <71ae6abc-d900-d5a2-84cf-8480a518e29b@gentwo.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8CBB418000F X-Stat-Signature: kxo8ki889tqus676huwzrox1fkdm1zy5 X-HE-Tag: 1741024066-765123 X-HE-Meta: U2FsdGVkX1+ysZkdweNAA8Zx1dGDpR6jQ3Myg/bHf/E+FHHhe5ZJLL6nCb15d5TpfE3bevL6s3vNnfp7WnZcIfrkgQA5W7im11yaIdfwtwhZNZWaBlBxc1Az2VVkkrq9hWupuL0fUW8TEqrXZ8KwnywH3nWoqm3U7frTJA/YYHIH7dY4a7ncdNJIODTplfED4I6TC2A3mFpych8abBFo2liL7bjY6tNGWdUIevWhoTjBquQzcTAiA3T/CQJzTMTlVQINnYEV9Uz67+5I8V2xW4PVexqYZ/78d2AP2g0ilDCs3FVCohlOKZeePptMRGmBCdtnZDTysJYvPG1u8n1DXGD25PTJMIPppFjAQ/m6RexUPrwdLrL1VO4TmXEoRM5o7HLFr1x++Gi61mHcDLSKt5bE6kvr56NQvTJMGyMOCgZsjGsyR6VR1rAZAW+aUm8c2ITgsJtZRoO+dFqmqDIEEuavWmq6/J+Ou3dYNTQ8wnSSGTUMffANFq9i3QqhiD/wWhf7MSiaxEFlIuUR1+LFEhVMgo+u9h22dB+c35lREGtdTExlgQT52Id3NBlROrm7zmWZr7NUqu1OgYeHGVusaASp8EJH7rC3eiaTMFAWeVrIcdLx4zUad+cfCEUhyddLh3SwYEwptRjiSbnwdmJRUDOfPSVg+RjhRcPB9N5c8VTHUVOUvZkR4Sw+pGbI9oiUQbnzIvueygKYB7Em4ljog3TAjEWETgkrq0ZdYeDn2t44cRNKZsP8m2G1pzy4DSdsctMxTuQ3Dgfi7YAnA7qkS9MBS0YxDLitaJVflAXLoCD4Hs2kaE3W0H3nbygYQhkhV1FVqoDFngURbclpIWafquAt7aV16mxqLg3j+WtcT1mV1RNchXtLpl4zZGbNXb3qrdBb6Oosd+Z027WxtTGFMecGLSZeT1RdyHTl6rM3Erd7AJJyOxvgEkfkjN1um18sKOtuu2aPUAXvDppoKkf nE7NEjS0 Lt5uYxQZzv0UO0cGirSNKVboSlQeGyEiEUfgyVr9oBz5ZFpEr80SKOpEgefPJE4IM+HztGUlSvCJGirNS0IR24wrwg5J4HeQ/ft15ZwU58Q490yBpj7910RQ9BqUkn5aLRqnjDsqh8Jb5f+o1m5EMyoGApMZmeHfHYS6OiZht/9JoVRW7EiAH/vTdKs7W9CazWLzWMsSEOsSEn7uWApARkV7VBRdsF6EJgFwLGGgbwY55Tq1g6Pdi0Y4rmoJREwJU/UA+mM7UJrUXAr/Symo1hXuOtixxo0r5mTZOItMmbtZhk5vzpJ+LLBO1dIuJaqEn/Fb4HbBgvB2Pa6Kv+cpjV56IBVSFuvoGk/6xR6hnQ/sdF1c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000078, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In Mon, 3 Mar 2025, Lilith Gkini wrote: > Alright, If you want to be more technical it's > `1 (true), otherwise 0 (false).` > Its just easier to communicate with the true or false concepts, but in C > we usually don't use bools cause its just 1s or 0s. Its not about "technicalities". Please use the bool return type as provided for kernel code. Compare f.e. static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) { #ifdef CONFIG_SLUB_CPU_PARTIAL return !kmem_cache_debug(s); #else return false; #endif }