From: "Christoph Lameter (Ampere)" <cl@gentwo.org>
To: Lilith Gkini <lilithpgkini@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
harry.yoo@oracle.com
Subject: Re: [PATCH] slub: Fix Off-By-One in the While condition in on_freelist()
Date: Mon, 3 Mar 2025 09:39:35 -0800 (PST) [thread overview]
Message-ID: <71ae6abc-d900-d5a2-84cf-8480a518e29b@gentwo.org> (raw)
In-Reply-To: <Z8XbomV9WCabATIM@Arch>
In Mon, 3 Mar 2025, Lilith Gkini wrote:
> Alright, If you want to be more technical it's
> `1 (true), otherwise 0 (false).`
> Its just easier to communicate with the true or false concepts, but in C
> we usually don't use bools cause its just 1s or 0s.
Its not about "technicalities". Please use the bool return type as
provided for kernel code.
Compare f.e.
static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s)
{
#ifdef CONFIG_SLUB_CPU_PARTIAL
return !kmem_cache_debug(s);
#else
return false;
#endif
}
next prev parent reply other threads:[~2025-03-03 17:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 18:01 Lilith Persefoni Gkini
2025-03-03 11:06 ` Vlastimil Babka
2025-03-03 16:41 ` Lilith Gkini
2025-03-03 17:39 ` Christoph Lameter (Ampere) [this message]
2025-03-03 19:06 ` Vlastimil Babka
2025-03-04 8:24 ` Lilith Gkini
2025-03-04 8:41 ` Vlastimil Babka
2025-03-04 11:06 ` Lilith Gkini
2025-03-04 11:20 ` Vlastimil Babka
2025-03-04 12:18 ` Lilith Gkini
2025-03-04 14:25 ` Vlastimil Babka
2025-03-04 17:14 ` Lilith Gkini
2025-03-05 15:48 ` [PATCH] slub: Adds a way to handle freelist cycle " Lilith Gkini
2025-03-06 8:34 ` Harry Yoo
2025-03-06 8:46 ` Vlastimil Babka
-- strict thread matches above, loose matches on Subject: below --
2025-02-15 16:57 [PATCH] slub: Fix Off-By-One in the While condition " Lilitha Persefoni Gkini
2025-02-20 8:20 ` Harry Yoo
2025-02-20 9:21 ` Harry Yoo
2025-02-21 14:57 ` Lilith Gkini
2025-02-22 3:58 ` Harry Yoo
2025-02-22 9:24 ` Lilith Gkini
2025-02-24 0:00 ` Harry Yoo
2025-02-24 12:12 ` Lilith Gkini
2025-02-25 10:08 ` Harry Yoo
2025-02-27 16:40 ` Lilith Gkini
2025-03-02 13:11 ` Harry Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71ae6abc-d900-d5a2-84cf-8480a518e29b@gentwo.org \
--to=cl@gentwo.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=lilithpgkini@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox