From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD52C02182 for ; Thu, 23 Jan 2025 06:20:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA7136B0082; Thu, 23 Jan 2025 01:20:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B55BC6B0083; Thu, 23 Jan 2025 01:20:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A44F56B0085; Thu, 23 Jan 2025 01:20:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8961C6B0082 for ; Thu, 23 Jan 2025 01:20:31 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 08565120C08 for ; Thu, 23 Jan 2025 06:20:31 +0000 (UTC) X-FDA: 83037717462.11.F445A8A Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 8C86FC0004 for ; Thu, 23 Jan 2025 06:20:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737613228; a=rsa-sha256; cv=none; b=CBleUOns2QBxn+HIc1+q2M6Y4kbLU22r1x/KaVGcXjTXmMT3Uz1/V5vZcd3DHiabdjKxrM Ggjx4I26bkoPSLJR6DM9CiNTDaNBMTwvVqRH0iN9aeBQlNwYqLRx3KCgK38X8i0GqFXxzS KsY6sq/RXEyip5eaOsy52cf/X5Vvg+0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737613228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hq8INVp32U5jMW//VoTgccA6lxYMJS+yZAnuM+FysO0=; b=kxXtHLS2GCsfi1ZmKR0G1ntTAeOm/lju1mkvVXjUrV20wZYy48EI+Wz8vGjxXIOEgNgqBz AQtU5jyFN7gdr40kj0R+O2DSgbz1AoWO2nurLGbuuGyd0ArWzmEowMHLjvqTH4dKxJQdiS pAiD4Yrr5LpxVxCMvn8xzAS6ykjw1+E= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4YdrQJ0xDkz4f3jLJ for ; Thu, 23 Jan 2025 14:19:52 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 106F41A06DE for ; Thu, 23 Jan 2025 14:20:14 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgBXuV2M35Fn2Oz3Bg--.39538S2; Thu, 23 Jan 2025 14:20:13 +0800 (CST) Subject: Re: [PATCH] mm/compaction: fix UBSAN shift-out-of-bounds warning To: Liu Shixin , Andrew Morton , Kefeng Wang , Baolin Wang , Mel Gorman , David Hildenbrand , Matthew Wilcox , Nanyong Sun Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250123021029.2826736-1-liushixin2@huawei.com> From: Kemeng Shi Message-ID: <71a9cabf-974e-08bf-45b6-e760425ec6cc@huaweicloud.com> Date: Thu, 23 Jan 2025 14:19:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20250123021029.2826736-1-liushixin2@huawei.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgBXuV2M35Fn2Oz3Bg--.39538S2 X-Coremail-Antispam: 1UD129KBjvdXoWruF4fCr4fKr48uw13Kr4rXwb_yoWkuFXE9a 1qyF4fAanIqr92yFnrCF1fZF1UGa48Zw17ta4DGr42vas2qan2gF1DXryftryfJF9rWFnI kwn5ZFWkKwnI9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUba8YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS 07AlzVAYIcxG8wCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4 IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1r MI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJV WUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcS sGvfC2KfnxnUUI43ZEXa7IU17KsUUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8C86FC0004 X-Stat-Signature: t89qjeipfz68o7ue9tqonzqqesznzmji X-Rspam-User: X-HE-Tag: 1737613227-801164 X-HE-Meta: U2FsdGVkX1+nHnLBncBghzh0ycYX+stEvtZFEynfTtV15O6vuh7Qc55s+eD7wLz2QcXRDn0fFWuX+pnVQPMWuMTASWj8qbApI/AHSb1SfI6fWusal2FIEEkJH1ODzRpH8k+OmFUnMihl6nQQQ3/AeMfwvtM4cuYji866OgCy7tG2IiudPqHjtiyQG5L2l0iMP0ikspjQ8ozhLTR699ktTxBBnKdlFicm7Ym7L5F3B+7b6F05GT+r+D9JwPkRj+fHnG+C1XvNjV5oLk1Tuq+zpTK4gHbLep+bnZTdeO9wYBrvPLXdmeA6hOLczqKalY80Yk191Fp+cVsQSMfC/D150wjofvwesjYW1Bfq97MOsokH6D9bllTPN6dg4MRGACilWUOC5xY3Ai6q+OJLhIg0xRXgSMGS/e+Ng27DGjViSQettdaHspeBZD5T6vLUI0plhpybs1a8Lksa39acC48yzp0MDmGSXnZmCjJpLKf/N1c1ljOh/0jX0qoP6rWvExeoWc+C2nUEhbi/b+hg05p7JcO2q3lmP5WsbunD0fnV+OyXRQjF/3NOfZW/2E2ZVuU7My5yW372ZrKSKd8I3Zang/Adlu4BGj+GEyiCDXAmsssMWhcjX+vbUWnub1i63HIlxSsIvTCNU8sMse+bznImG01WoKtfur8rRnImzlAsY+kUBG9OS3zCzQycVyAoQKXC/WuWwLnpJcHgWZsE2fnV5AJpDmOLa9Xl49qT/wlMOrwZwaBeezh3GB7/OwjpiV25r5tF12AHspu7q91hJ8KvMWXJWZ1EzVfcwUBfKvE9r2xXrRELbZVAlPkkEFCqxWI4Fqu9pzQxWRY+edbd9dVp2AIs7BSQAiH9LNKanQCySGDv2OL3lZUVRy0edYCx/GJwbaXHX5y3vz/YGFbF4RJ1OZZQniRH9q2D0m80Sf0K3RRExzbFcOWr2wKogqYeozdNfjkMdn2ea8oWjBCaLRM lvnCg2xs xghYIg1N2ZuNrGxZrKIL3P/wZGCm96qJNIcpvuCh8bsf1lltnIo2OqI2ExyfPxfg9G95BhT8Huv9moBbsKYQ2wP+WxCn+ubFx1k8tDG8W88knE2rypUfVjcUKxbmPKX7AL8XD14t1h8dx/mfZYygKPgHIda3z5plJVHWk+UOdvvBebHN8IcTJbSj/2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000206, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 1/23/2025 10:10 AM, Liu Shixin wrote: > syzkaller reported a UBSAN shift-out-of-bounds warning of (1UL << order) > in isolate_freepages_block(). The bogus compound_order can be any value > because it is union with flags. Add back the MAX_PAGE_ORDER check to fix > the warning. > > Fixes: 3da0272a4c7d ("mm/compaction: correctly return failure with bogus compound_order in strict mode") > Signed-off-by: Liu Shixin > --- > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a2b16b08cbbff..384e4672998e5 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -630,7 +630,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > if (PageCompound(page)) { > const unsigned int order = compound_order(page); > > - if (blockpfn + (1UL << order) <= end_pfn) { > + if ((order <= MAX_PAGE_ORDER) && > + (blockpfn + (1UL << order) <= end_pfn)) { > blockpfn += (1UL << order) - 1; > page += (1UL << order) - 1; > nr_scanned += (1UL << order) - 1; > Look good to me, feel free to add Reviewed-by: Kemeng Shi