From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1CCC433FE for ; Thu, 3 Nov 2022 02:52:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CF728E0002; Wed, 2 Nov 2022 22:52:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57F558E0001; Wed, 2 Nov 2022 22:52:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46DEA8E0002; Wed, 2 Nov 2022 22:52:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B7B78E0001 for ; Wed, 2 Nov 2022 22:52:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 007E3AB551 for ; Thu, 3 Nov 2022 02:52:14 +0000 (UTC) X-FDA: 80090607030.04.EAA6D9F Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf05.hostedemail.com (Postfix) with ESMTP id 8D52B100004 for ; Thu, 3 Nov 2022 02:52:14 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1667443933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lp0yfXzlfHhvEOMOaUivoS1iKMpFYQIUksinGRVVzMA=; b=aGfPf6SZQPy8RYJ0buYLhhBk9mO/wQB+ZliJxfhUWRqccZiuQp+ypccJf+t6gNdW1hI4ju ms3JQf6Okf8a3VPDX0R0wfTfy9pWKySRgloOn5n8jzWBmdPxBbqhWws+htNa4nkzDvJjT8 Kr5/qjKKGqSM0nM6M5W4d4x6qocScrI= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 3 Nov 2022 10:51:59 +0800 Cc: Muchun Song , Mike Kravetz , Andrew Morton , Gerald Schaefer , Linux Memory Management List , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev> References: To: Vasily Gorbik X-Migadu-Flow: FLOW_OUT ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667443934; a=rsa-sha256; cv=none; b=DqCN2Xm3JbLGTCpTHrU+yNQxQXqg3qDhiWVeCuJGne6tJ185VGo8OwgHQHpKu650FNFCoO WJLsuzNx+hXzcZk4SpTBm6qsR5gK5nCjNp6G8aIpsyKF7l0YbzkEgJE3tp+03b5vfv8dZj MqgUK+z6nTqCktionYKbWGM/ZyWPn/I= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aGfPf6SZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667443934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lp0yfXzlfHhvEOMOaUivoS1iKMpFYQIUksinGRVVzMA=; b=D6vHEuyxqhBDEEFph2zoAqwU51R4PoblDo8lRYvVSTEaXmr7YdILDg7MV1g0k8wkzbjkLP MwPW9dailjDpXikgjcQj2ZpqvqFEVFVPG9ff0FqtZkwQ1d+CXEd7clBYTMYvUKAG825L5m dDnpV7fH3tFOzvjJ0TIpl6McYHvknXY= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aGfPf6SZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev X-Stat-Signature: ut436rnckomfsk1geypfkicg8rzx7gmt X-Rspamd-Queue-Id: 8D52B100004 X-HE-Tag: 1667443934-424642 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 3, 2022, at 02:09, Vasily Gorbik wrote: >=20 > The kernel test robot reported build failures with a 'randconfig' on = s390: >>> mm/hugetlb_vmemmap.c:421:11: error: a function declaration without a > prototype is deprecated in all versions of C = [-Werror,-Wstrict-prototypes] > core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0); > ^ >=20 > Link: = https://lore.kernel.org/linux-mm/202210300751.rG3UDsuc-lkp@intel.com/ > Reported-by: kernel test robot > Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with = core_param()") Thanks for your fixing. However, the correct commit that should be fixed = is 42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP"). Reviewed-by: Muchun Song