From: Muchun Song <muchun.song@linux.dev>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h
Date: Thu, 3 Nov 2022 10:51:59 +0800 [thread overview]
Message-ID: <71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev> (raw)
In-Reply-To: <patch.git-296b83ca939b.your-ad-here.call-01667411912-ext-5073@work.hours>
> On Nov 3, 2022, at 02:09, Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> The kernel test robot reported build failures with a 'randconfig' on s390:
>>> mm/hugetlb_vmemmap.c:421:11: error: a function declaration without a
> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0);
> ^
>
> Link: https://lore.kernel.org/linux-mm/202210300751.rG3UDsuc-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()")
Thanks for your fixing. However, the correct commit that should be fixed is
42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP").
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
next prev parent reply other threads:[~2022-11-03 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 18:09 Vasily Gorbik
2022-11-03 2:51 ` Muchun Song [this message]
2022-11-03 16:02 ` Vasily Gorbik
2022-11-04 23:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox