From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D1ED68BEA for ; Sat, 16 Nov 2024 10:11:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35AD6B00D0; Sat, 16 Nov 2024 05:11:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE5816B00D1; Sat, 16 Nov 2024 05:11:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5ED36B00D2; Sat, 16 Nov 2024 05:11:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B6D2E6B00D0 for ; Sat, 16 Nov 2024 05:11:01 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46074C17A9 for ; Sat, 16 Nov 2024 10:11:01 +0000 (UTC) X-FDA: 82791537528.13.2343957 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf13.hostedemail.com (Postfix) with ESMTP id 35B602000D for ; Sat, 16 Nov 2024 10:10:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731751794; a=rsa-sha256; cv=none; b=yQx8zp7PKcA2CUGDY0f6L81ocV+CcELusGeDS0Hn9aZLiwJ1UlZh+qlg6a4CFJp8CA3sKy RJRfjvL0ARiKwTMxkN9d6r1ezNT1+or4fw0jK7GR+3QcmpefkSJmSmxjBrrCnsjAQIqcZZ GvgwYFb52omscuyo0lUTbHBZW15G5T4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731751794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z/h9Fo8qzxX+vwj/gnHe49MO7XxCnXAh2+BwoWgtDC0=; b=pjAhj1Q6IopyZwPS5BL3DDmgMIMDjE4CvcA2RKGyS5IukBWIuyob06KFqiXeBsnP+Tcva9 Fdvh1ganDDEJpspa5lKqTcaV1PJHZpL+ZW38r86RMtErKRsJWzFFJe9JaS1K4WevhAqqlR ce0/qVpIZNL7Hn58zkl142tMN4SDfKs= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Xr8mJ70Cyz9sSc; Sat, 16 Nov 2024 11:10:56 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TVeBAyqMk-DH; Sat, 16 Nov 2024 11:10:56 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Xr8mJ5nMzz9sSZ; Sat, 16 Nov 2024 11:10:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AD1708B7A7; Sat, 16 Nov 2024 11:10:56 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 44RvYN3jGzXi; Sat, 16 Nov 2024 11:10:56 +0100 (CET) Received: from [192.168.232.159] (POS169858.IDSI0.si.c-s.fr [192.168.232.159]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 35D3D8B763; Sat, 16 Nov 2024 11:10:53 +0100 (CET) Message-ID: <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> Date: Sat, 16 Nov 2024 11:10:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 35B602000D X-Rspamd-Server: rspam01 X-Stat-Signature: hnqmiheibge59jpief3z3c7bk74bpgtn X-HE-Tag: 1731751810-274090 X-HE-Meta: U2FsdGVkX18L/ZmE6S5QTAsOcbl11UbYB5ItF6xJ+XI+NC2ZHvsUnpl4NI05J18BVX8UJSXA9pHx+kfGKcpt5iNxNJY1KRyQsfR9o3dKVWMvOPUYf1fG7fLZT+u7KhRC0RXv7fm9zPUkMCUd7D7zAacasdC1niAT0pQkDFwD5diH80yP+bPfXrTAJeRq1VACENOqxoK/25/VYaBUP5OeQ/HYh9hiL4lhifvTpFYQgQy/Icd1VzK5Wz/IXeGCjVacovEKnVTOrdCLZVOfrzTYrhtu1k8Hg6CcrKYh1zq+4XgNyVUlkbT02MauO3WzjshUACzHo6aZyHoZtYlLpRRROu0uM2m2sI3VeMS4TwfiZyjc36QPuOfWr/GCGORbqbONgITx/7STIU/0922NwtNEzce1Fqc+JkXHfdatNjeqDInm6XjYTufAzY4NmerhQzmGqD1LSxgArtLPeBYQscDr0AMbR3a8g/NGHfimwrkdW/UXSiH37D4Z7/17IunqdQpfeUvw5WMJqVQj/q4B2iZTy7meatVlzUPsdX1HPNREYrG29czHLOzxNquyQqoaCnPsvkYJkz7qTriuPoN1fX8/8FpQylbDDIill+GUqNCrh3E7isnn2R9Bl9VJ8BmGJRtfiih8vbwKLS47ICIJFbXZ/e+9D59yoHt/S0fbTyJ9Azz48YZlp9rRsSqDI/yP3aHcaq//RMtBTAAZpEKZ1/vCEv6ICKA8R9w43Mj0NURn3fCs/OybY9Pm5PasV9B5gZuUJJe8Hbo8dyxu5yOzqO/w+ZqPjVoaTojLWyEPyvzz1/RZYANSvXvkRYFOrHt93yLdJmJEwvRqWcqzF8/gE5VrTVVAmhEASLRjSGuS1RyzCRZRtSwVMwIz+AIdc+H/ts/oyYr80vI8OKTQRDbnown6aPGqf8UqgbzR0uqzSMnjHlQymzk20zwB/foH/YfuRD/JoaR0anBPA6TL7sNNFJ2 7oXrt90X 7jfEDnVyt6G7+j8NUnN9ABudzZJ0+HXtSzNu2DcJ/z41xKHDJrz4KI8VzrMQ3Q8ASUwODt91ZCe1pM61vJ4BTA9feEAkXZCmN0snGWW50mNf5/7J2854dQoncWAGfGfkQJTlK84NgeWYikRvOCXm4KIW3sXydN7UtQZWwoWwLlvDqvfltC1hAcKH5m3St4xVrmNKzItLZz524s1ibF8Ys6hD9bK00kvyIPHs1W2xFuivtKzLgaFsdu9d897euaokgnGkjX4lR4ujddRwbr5fX5pp5JIVr/mVAVbHtAA3nd3V5LZx8YQ+dGKyaxl6AJWhrlQuo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > samples/livepatch/livepatch-callbacks-busymod.c | 2 +- > samples/livepatch/livepatch-shadow-fix1.c | 2 +- > samples/livepatch/livepatch-shadow-mod.c | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c > index 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba 100644 > --- a/samples/livepatch/livepatch-callbacks-busymod.c > +++ b/samples/livepatch/livepatch-callbacks-busymod.c > @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void) > { > pr_info("%s\n", __func__); > schedule_delayed_work(&work, > - msecs_to_jiffies(1000 * 0)); > + secs_to_jiffies(0)); Using secs_to_jiffies() is pointless, 0 is universal, should become schedule_delayed_work(&work, 0); > return 0; > } > > diff --git a/samples/livepatch/livepatch-shadow-fix1.c b/samples/livepatch/livepatch-shadow-fix1.c > index 6701641bf12d454a770e49abeeb0dea92560e55e..948ea1f5760fed2fa27baf478c97cf98ad5c99a8 100644 > --- a/samples/livepatch/livepatch-shadow-fix1.c > +++ b/samples/livepatch/livepatch-shadow-fix1.c > @@ -73,7 +73,7 @@ static struct dummy *livepatch_fix1_dummy_alloc(void) > return NULL; > > d->jiffies_expire = jiffies + > - msecs_to_jiffies(1000 * EXPIRE_PERIOD); > + secs_to_jiffies(EXPIRE_PERIOD); > > /* > * Patch: save the extra memory location into a SV_LEAK shadow > diff --git a/samples/livepatch/livepatch-shadow-mod.c b/samples/livepatch/livepatch-shadow-mod.c > index 7e753b0d2fa611524c9e2adbe02c8fa3e9b6015e..79296e6ccb119f521e86a121623855d841c9fc5e 100644 > --- a/samples/livepatch/livepatch-shadow-mod.c > +++ b/samples/livepatch/livepatch-shadow-mod.c > @@ -102,7 +102,7 @@ static __used noinline struct dummy *dummy_alloc(void) > return NULL; > > d->jiffies_expire = jiffies + > - msecs_to_jiffies(1000 * EXPIRE_PERIOD); > + secs_to_jiffies(EXPIRE_PERIOD); Should fit on a single line, avoid multiple lines when possible. > > /* Oops, forgot to save leak! */ > leak = kzalloc(sizeof(*leak), GFP_KERNEL); > @@ -153,7 +153,7 @@ static void alloc_work_func(struct work_struct *work) > mutex_unlock(&dummy_list_mutex); > > schedule_delayed_work(&alloc_dwork, > - msecs_to_jiffies(1000 * ALLOC_PERIOD)); > + secs_to_jiffies(ALLOC_PERIOD)); Should fit on a single line, avoid multiple lines when possible. > } > > /* > @@ -185,15 +185,15 @@ static void cleanup_work_func(struct work_struct *work) > mutex_unlock(&dummy_list_mutex); > > schedule_delayed_work(&cleanup_dwork, > - msecs_to_jiffies(1000 * CLEANUP_PERIOD)); > + secs_to_jiffies(CLEANUP_PERIOD)); Should fit on a single line, avoid multiple lines when possible. > } > > static int livepatch_shadow_mod_init(void) > { > schedule_delayed_work(&alloc_dwork, > - msecs_to_jiffies(1000 * ALLOC_PERIOD)); > + secs_to_jiffies(ALLOC_PERIOD)); Should fit on a single line, avoid multiple lines when possible. > schedule_delayed_work(&cleanup_dwork, > - msecs_to_jiffies(1000 * CLEANUP_PERIOD)); > + secs_to_jiffies(CLEANUP_PERIOD)); Should fit on a single line, avoid multiple lines when possible. > > return 0; > } > > -- > 2.34.1 >