From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dave Chinner" <david@fromorbit.com>,
"Qi Zheng" <zhengqi.arch@bytedance.com>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"David Hildenbrand" <david@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
kernel-team@android.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-mm@kvack.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 3/5] mm: export zap_page_range_single and list_lru_add/del
Date: Thu, 5 Feb 2026 12:18:02 +0000 [thread overview]
Message-ID: <718079e8-dd1e-400c-9b81-4c833722c83a@lucifer.local> (raw)
In-Reply-To: <aYSH5KG36fVQFePL@google.com>
On Thu, Feb 05, 2026 at 12:07:00PM +0000, Alice Ryhl wrote:
> On Thu, Feb 05, 2026 at 11:29:04AM +0000, Lorenzo Stoakes wrote:
> > We either need a wrapper that eliminates this parameter (but then we're adding a
> > wrapper to this behaviour that is literally for one driver that is _temporarily_
> > being modularised which is weak justifiction), or use of a function that invokes
> > it that is currently exported.
>
> I have not talked with distros about it, but quite a few of them enable
> Binder because one or two applications want to use Binder to emulate
> Android. I imagine that even if Android itself goes back to built-in,
> distros would want it as a module so that you don't have to load it for
> every user, rather than for the few users that want to use waydroid or
> similar.
>
> A few examples:
> https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/blob/5711a17344ec7cfd90443374a30d5cd3e9a9439e/config#L10993
> https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/config/arm64/config?ref_type=heads#L106
> https://gitlab.com/cki-project/kernel-ark/-/blob/os-build/redhat/configs/fedora/generic/x86/CONFIG_ANDROID_BINDER_IPC?ref_type=heads
I mean you should update the cover letter to make this clear and drop the whole
reference to things being temporary, this is a lot more strident than the cover
letter is.
In any case, that has nothing to do with whether or not we export internal
implementation details to a module.
Something being in-tree compiled gets to use actually far too many internal
interfaces that really should not have been exposed, we've been far too leniant
about that, and that's something I want to address (mm has mm/*.h internal-only
headers, not sure how we'll deal with that with rust though).
Sadly even with in-tree, every interface you make available leads to driver
abuse. So something compiled in-tree using X, Y or Z interface doesn't mean that
it's correct or even wise, and modularising forces you to rethink that.
folio_mkclean() is a great example, we were about to be able to make that
mm-internal then 2 more filesystems started using it oops :)
>
> Alice
Cheers, Lorenzo
next prev parent reply other threads:[~2026-02-05 12:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 10:51 [PATCH 0/5] Make Rust Binder build as a module Alice Ryhl
2026-02-05 10:51 ` [PATCH 1/5] export file_close_fd and task_work_add Alice Ryhl
2026-02-05 11:20 ` Lorenzo Stoakes
2026-02-05 11:42 ` Alice Ryhl
2026-02-05 11:53 ` Lorenzo Stoakes
2026-02-05 13:45 ` Alice Ryhl
2026-02-09 15:21 ` Lorenzo Stoakes
2026-02-10 8:47 ` Alice Ryhl
2026-02-05 11:38 ` Christian Brauner
2026-02-05 11:52 ` Jan Kara
2026-02-05 12:07 ` Alice Ryhl
2026-02-05 10:51 ` [PATCH 2/5] security: export binder symbols Alice Ryhl
2026-02-20 0:00 ` Paul Moore
2026-02-05 10:51 ` [PATCH 3/5] mm: export zap_page_range_single and list_lru_add/del Alice Ryhl
2026-02-05 10:59 ` David Hildenbrand (arm)
2026-02-05 11:04 ` Alice Ryhl
2026-02-05 11:12 ` David Hildenbrand (arm)
2026-02-05 11:18 ` Alice Ryhl
2026-02-05 11:30 ` David Hildenbrand (arm)
2026-02-05 11:29 ` Lorenzo Stoakes
2026-02-05 11:43 ` David Hildenbrand (arm)
2026-02-05 11:57 ` David Hildenbrand (arm)
2026-02-05 12:01 ` Lorenzo Stoakes
2026-02-05 12:06 ` David Hildenbrand (arm)
2026-02-05 12:07 ` Lorenzo Stoakes
2026-02-05 11:57 ` Lorenzo Stoakes
2026-02-05 12:03 ` David Hildenbrand (arm)
2026-02-05 12:12 ` Lorenzo Stoakes
2026-02-05 12:24 ` Miguel Ojeda
2026-02-05 12:28 ` Lorenzo Stoakes
2026-02-05 11:58 ` Alice Ryhl
2026-02-05 12:10 ` Lorenzo Stoakes
2026-02-05 12:13 ` David Hildenbrand (arm)
2026-02-05 12:19 ` Alice Ryhl
2026-02-05 12:24 ` Lorenzo Stoakes
2026-02-05 12:30 ` David Hildenbrand (Arm)
2026-02-09 15:22 ` Lorenzo Stoakes
2026-02-05 12:16 ` Alice Ryhl
2026-02-05 12:07 ` Alice Ryhl
2026-02-05 12:18 ` Lorenzo Stoakes [this message]
2026-02-05 10:51 ` [PATCH 4/5] ipc: export init_ipc_ns and put_ipc_ns Alice Ryhl
2026-02-05 10:51 ` [PATCH 5/5] rust_binder: mark ANDROID_BINDER_IPC_RUST tristate Alice Ryhl
2026-02-05 13:21 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=718079e8-dd1e-400c-9b81-4c833722c83a@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=david@fromorbit.com \
--cc=david@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jmorris@namei.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=surenb@google.com \
--cc=tmgross@umich.edu \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox