From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD4AC77B7A for ; Thu, 29 Aug 2024 06:25:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B16D6B00B1; Thu, 29 Aug 2024 02:25:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362806B00B3; Thu, 29 Aug 2024 02:25:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202C76B00BC; Thu, 29 Aug 2024 02:25:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F2AE86B00B1 for ; Thu, 29 Aug 2024 02:25:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D0D9C09B1 for ; Thu, 29 Aug 2024 06:25:56 +0000 (UTC) X-FDA: 82504297512.03.B7A1089 Received: from mout.web.de (mout.web.de [212.227.17.12]) by imf02.hostedemail.com (Postfix) with ESMTP id 194D580003 for ; Thu, 29 Aug 2024 06:25:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=BbD8ahth; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf02.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724912733; a=rsa-sha256; cv=none; b=UeVQxvhcy5xuu7zXZBkEgg000LYEDG5ZCzAf6CzDkpqmFmSPuZ094TV655VVe789svc/g+ H+G5fxrAC0LgsCYn54OxH/6wiO63PdXbCVPgoA3zojEy62BxHKhzC7nSNyC8lUWb2VjzAr c90VY8L0vD0Ndxhu16jqpQu4ec1XJgI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=BbD8ahth; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf02.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724912733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HIW23CZzXcXcZJuHDzldiRyWNruWFM0jw+ALZdzsRJI=; b=yzf5DUQS/h4IbXgQRsgHmU5Evj0ZFedrQVbbMr33Fonp8t27WavoTY753gRNXIKyusUl7o TdPpXpjthq53eoEpHUwE1jtEjK/wJOuS0EXjN30ckbOQ9y/q48OiLasZ9d7jsCogRCeBBr 4LvNs/eqtAMHpDrSY7z+pEqfIpalIgc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1724912747; x=1725517547; i=markus.elfring@web.de; bh=HIW23CZzXcXcZJuHDzldiRyWNruWFM0jw+ALZdzsRJI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=BbD8ahthxTdDh4iOqi8w/69UdP4aQ3VREJnUDlX559vTevgUEVJAQTx84crfsPdL 5WXY1eRSBtLBg7ZojoWecyD9BEK0m3cojOgVT0C65by4pH9CSdmdgPqeOZpve1k1v VMRRU+2CfFIxqlE3R7rE3uxemmwo7LqiffgM48qU1u20TGwFZEgWKbwB1FyYOxgEk GEXnye9JIUHOG8ym6+beQsFXAOwxVCnxG5pvtgQEfFxd0lSFUFJDx4812LIcjM7x+ dWTR8UcfF0lGQVlOHicRyHc2hOoutZwEcQZu7H+U+jYS2QnERLyWqcvZ9HRCJcFhR uqUkxnQLfspi6WoDVQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.84.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4eCL-1s3iyj3rbr-00xbLA; Thu, 29 Aug 2024 08:25:46 +0200 Message-ID: <716f7466-562d-4bbe-a8ec-851a0b289db5@web.de> Date: Thu, 29 Aug 2024 08:25:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhu Jun , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton Cc: LKML References: <20240829055621.3890-1-zhujun2@cmss.chinamobile.com> Subject: Re: [PATCH] tools/mm: Use calloc and check the potential memory allocation failure Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240829055621.3890-1-zhujun2@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9prvbxVevokm958741Min2OcUnei7T7YdduuG/Xc3BV5BGBfg0C ye1/tUbYLxKdBNxgR5QsRpuCSa0aRX1EYjfreae41IPQXqCQTaRVVfVfoDxX781dytZkZCM 2SEKZfQ9/MtsjxNE0WMJJyW/acU4wb6orZWb0uAEyCEQZxCgxT4lSHACHjA2Zbiad10e/kN H+bXBLSVVAJKcXqllkh6Q== UI-OutboundReport: notjunk:1;M01:P0:HRznMeMAbUg=;dGwIw0IeJ/A+SqIhr7kg9ecNdjU kqH1WmdGyjmsTEYp0Y0UNuh83lB0H1KhzRG6DKahpqziFNRqaXk9IXdg7l4tRUH8qDz9gL5ou pWLYhZuWi137xuU7dIurc8NlFdU3LFbbulSc+FAyrcIvvbhPvlL/WXq3hK3eOmk4Tkpquy2Pl 16TyKaVkq8YtfLxsKUfqgZl1YTf5bumjgP3NfPuvxWGJtsBYJ6AZIuSj0yPn7+0mdDHXQIFRV uhdLTKgz+qI1EuIyj8kAprTnfW6jF34Zl3RSV+m3xFvHM6aH3CBf0fWY47Yi7EDefsdMHH69P 1WR2VlTSeW/0IyotHM5uzg2UrdrUqhxOkM1xxIpaOqu8WwJOUa9NEvywCa+Cyf0bwNwYJEhDK XG1/1vX5tTN+QNcEBwqlLr8FBseQ256BLvGuAjflYQ5KJ14g7sP7PAyGRyTvGcYRyYOHZBteg CLwCd1F6YYCq8M27amplH55myXzzFnY3EaPiKnX76atuaoXNxDebfBDGuOJ9xn3OzazeMpqIh 1XUUW84qmtaGQvmv+cbtktVBP49xs7Sk00wpxf7xAcgT4NiIq3w9AcFzNh/ex7lK6WDr5NMnX u1t+Ts6VJDHo+QKkmpx+y2rx81P+rHVb+Z2X46JvNgiC7yH6Afq5YWSaEIL3G18DoNTsDiiej 1PghmRF+6QBJSqZLkbHVpw7EmM08jpWORf6Kr9dzH1GBBRHA9dpeGbEkqBf+TAcooEY93KLaI 2gFOpZQLoAoKD0JVmZHQXfQxAqpKCiHGGvMB3JpW0nejNnzAwMS0CtUlqweOmco8IOGNXGIP1 CfrGV3XxN+i0YgyGtwnfij+Q== X-Rspam-User: X-Rspamd-Queue-Id: 194D580003 X-Rspamd-Server: rspam01 X-Stat-Signature: mms8cgwuhexmaozirq68hak5rmzz5r79 X-HE-Tag: 1724912753-800191 X-HE-Meta: U2FsdGVkX1+UUEWL+H6nXrIwjCjm6A2Weyp7LUQpXdbLazGjhlw+8Ggkc+4dNW4RzG/Y6m1cfpo2NWFPQiDbuNXaL2psJ+mSeuCq5z2+CBvEyISpDRVoTVOIAhCPn2kiYe2/ZVQqwo6RJS/VDLPDOXIffpl5Yds89zcWucTi3I99un8rbdxIHPxg+2STLDq9pwy23uq1QXBi+fxtqwKl3UXqmTXzzqPK2SHiD6/cU9v6MNsg888Qz3X7jsQ8Z3NOH1qqXGT+/vSVRgKcWmNp5zGwks1bF6lWki+kvGPho7M3YsYjSw5nuSQK6lTJBkUpWHqIeIeP9qyn5Z4mF4q5LTJE30DTF3PaxdCgmhCVmF3UxhQkwnFtuL6IJuefOTIf0EDHPLMyjUFuerQ/oZ9Mn6QVWD50wecpgUQwTxi1DqjxsTSvvqiayMPnKqUzHNXD1hnJb1ygXbe7lz12LDI0ONrX68SlpHPlIlJtR+hUzUEYN7Gx/1eFN3PVXlwNhEEz9uVcl0ihrY7wzlDVGso61B7SECQnfw0naavPmdOTXTRIlLYEgBKSk5qPup6MBaTdGjqXdjnkzylLOQnkseHUjEmJlHir9fy7UQEHvKbSlZ7rBX09s2J6jyr2Ez0vroBaNEPNICkK0044BqAEK2jCqY2d3UsRtdnn1VWf9CkxjyolFHi3POmSy/DvytjhczntnVlqvFCjKukjV629SU4zpog/G46m43EZ7qge39gPIpSn0b2hUYnPuEn6guTcQfbwP39o3v+diLPli/m3Z3c4Dqa8oviKmmgr5P/oYuamAfoWsHnv0KhoL2mcO6sR/SpeCuQTb3unTn0AJS6nNIbVAYkyctAC3SLHuaiUdvmenHVpg9BxZSHMWH3uzNPx8I9/sE++3ZIEgX+kHNkyZm7cXxEpDQbwMX5/kGTQzrSVAIia6QNNV+dYRYvEGP2hn8zHzVK8b1iKC1PsUuZHmA3 E3M5mSbK EXPnworzYfLFD+CG0Hr+A2Mzcz3I8wf5WiAeeZ4KAFhXhPoFlXksDM/hmAm9ZyYFu3kTJSqYXhxEjarUgDFBKKZ+G/iQj7fX2FstrfUjHIwxpVLzN0qSlTLkb8p/AibzWioPv5/rN5zKn0/X2UCyA4ku99knIDqiIkW504r1gteZVl43KmNCeoemzMQqz5dc07ZQnydh20Nd7OMm3IOiXdvBopedXbeBFZ0N7FLB+wuOpQflFf0pSk20NOU9QMl9kbbZJXE/vfwBdqfCfJ5tlF1V9sY8DMY8eZ+oPICg8m1t4MwuNvq+WzPIoQ1G0Wm8vFEjt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Replace malloc with calloc and add memory allocating check memset(=E2=80=A6, 0, =E2=80=A6) call by calloc()? > of comm_str before used. * Add also a null pointer check for the detection of a memory allocation f= ailure. * Would you like to improve such a change description another bit (with tags like =E2=80=9CFixes=E2=80=9D and =E2=80=9CCc=E2=80=9D)? * How do you think about to omit the statement =E2=80=9Cfprintf(stderr, "O= ut of memory\n");=E2=80=9D? * I suggest to omit the word =E2=80=9Cpotential=E2=80=9D from the summary = phrase. Regards, Markus