From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE48C63797 for ; Mon, 16 Jan 2023 11:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532DA6B0071; Mon, 16 Jan 2023 06:37:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E31A6B0072; Mon, 16 Jan 2023 06:37:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D1EB6B0073; Mon, 16 Jan 2023 06:37:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2FA5E6B0071 for ; Mon, 16 Jan 2023 06:37:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E85301C6232 for ; Mon, 16 Jan 2023 11:37:44 +0000 (UTC) X-FDA: 80360462448.04.E3EFE7B Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf17.hostedemail.com (Postfix) with ESMTP id 5049F40006 for ; Mon, 16 Jan 2023 11:37:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673869062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lFjgpE9pJFUIcd83UHKLIysa12cBr+MKTfeqNKk8Ovs=; b=kavZr8cFXVhLvaIbYHiV/M4Ng7l2VShDHU+fIBUe6O9X+0KFY57NkiKUUZOgOmtrYV0qff AxRWpuUWHSObyxMRZcDC6m50Vnd6AKTGmPVgolq/fKHr1O0NfkRxthK+mD9ddlR2YjCr9a m+iNfU3J0j8BehMLj1gjSutP0OgBX4I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673869062; a=rsa-sha256; cv=none; b=4JT1zM9p1liGm8PlQvorRM7PPw8ho31aD+z4//wDRqfWnAvZBQUKlgDOOzqr69m+vO4lm0 axEQBA4xj7JttDnaExkQep6txeuICazILejRoR75A3tfvRWN/AIxxy50hjL1dMSIVJ11M/ uY9btHo97PZzxYgl5zmktugJEQI0ruQ= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NwVJj35N8zJqkv; Mon, 16 Jan 2023 19:33:25 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 16 Jan 2023 19:37:37 +0800 Message-ID: <715cfcd3-47c3-f7f4-7dd1-4d76c6b147f8@huawei.com> Date: Mon, 16 Jan 2023 19:37:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate() Content-Language: en-US To: Matthew Wilcox CC: , , References: <20230112083006.163393-1-wangkefeng.wang@huawei.com> <20230112083006.163393-8-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5049F40006 X-Stat-Signature: tskfs84c48jsqgq786ka3kfqfti5udi7 X-HE-Tag: 1673869061-103375 X-HE-Meta: U2FsdGVkX194OTG/SqsWOXYRNcfmw5LfEj1omxexhbuy61pWdbk6jXYhG7YKhGFuFrlt9cnPv+/26GKY3mg12DeuNE3ktWpOaQ5liuLUGzoalBSziXQbQeeIpZcLvosgGw6afZFB5VYuKlEHnyGWwHnP0pvJXlO/dVOE+LL++atfisTd1/eyfjA7Kx1lLLOVfTiyXCWwfNzMLmv02yK37J2CQImrIoWkzW/7TPxWS1A2VoeO5SHd/P/Ke9glSkeLCAGZn7J6/at7XNM3ow8teDOuOLJ2QnX+Wo8Wf72X9QsQrjOJJkh49lZOoTAgyYdI1aVEgeLB2vI6sh5nG2IWKouyvJ5UwJEsPHDNyzvhARbmVkrXzuc56RjAgjOPXDKKoIXHrwSJfGRtjxjILdvddrUsbKmLmw1RcEEx2U9vRKX6DNbSMVQJwmPwAhyb/ASrJRnkXj+IAC/kQhM2g91Pqv5FBi2lGQ67fMYFc31ag6BIdIrJFpmbSMwbwaxMfBpYxFM/Zw7TeG3dYFOkhu/OMYkQVT4cnPqNa9wFyCPcNrB5Hd03ik0UMl/7+a9jbYhNxZyCB4owzxJtk/xRt90wzSJOKjJLnUPp4y3ofGVoz2mijgoT0f2uWN3HxbLVCVLnngcWaRpWogxo2X3mA3gVWYD+n/2Fk14+BElSs6Egmz/kj4W9xMLCeZuIRPQ3qrycOktt90isSDKC3ASg/8xtN7nuu4RvpJMp6/Hlq8PuMvskAyYSZ+xahK7a8Y66+jL5vRnkd1mDL4omsxP5f2kbtpsu3JBjlnv2r5COJKA81/Iwp626Wh/mzM/i/qGY7Gbly3uTXrwYh22SRcTvtxAMOrfzRWh4uQTkDMklQQs5T5qAloZehQ5t5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On 2023/1/13 23:50, Matthew Wilcox wrote: > On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote: >> All the callers of cgroup_throttle_swaprate() are converted to >> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate() >> to take a folio, and drop unused cgroup_throttle_swaprate(). > > Shouldn't __cgroup_throttle_swaprate() then be called > __folio_throttle_swaprate()? Sure. > >> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask); > > Also you can drop the 'extern'. Ok. > >> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask) > > And it's not a gfp mask. It's gfp_flags (we have this mistake all > through the mm). Or you can just call it 'gfp'. > > Thanks for your kindly review and advise, will update.